baomingyu commented on code in PR #11820:
URL: https://github.com/apache/inlong/pull/11820#discussion_r2041693165
##########
inlong-sort/sort-formats/format-common/src/main/java/org/apache/inlong/sort/formats/inlongmsg/IgnoreFailureHandler.java:
##########
@@ -47,6 +49,13 @@ public void onConvertingRowFailure(InLongMsgHead head,
InLongMsgBody body, Excep
LOG.warn("Cannot properly convert the InLongMsg ({}, {})", head, body,
exception);
}
+ @Override
+ public void onConvertingFieldFailure(String fieldName, String fieldText,
FormatInfo formatInfo,
+ Exception exception) throws Exception {
+ LOG.warn("Cannot convert the InLongMsg Filed (fieldName = {},
formatInfo = {}, fieldText = {}),"
+ + " exception = {}", fieldName, formatInfo, fieldText,
exception);
Review Comment:
done
##########
inlong-sort/sort-formats/format-common/src/main/java/org/apache/inlong/sort/formats/inlongmsg/NoOpFailureHandler.java:
##########
@@ -51,6 +53,13 @@ public void onConvertingRowFailure(InLongMsgHead head,
InLongMsgBody body, Excep
throw exception;
}
+ @Override
+ public void onConvertingFieldFailure(String fieldName, String fieldText,
FormatInfo formatInfo,
+ Exception exception) throws Exception {
+ LOG.warn("Cannot convert the InLongMsg Filed (fieldName = {},
formatInfo = {}, fieldText = {}),"
+ + " exception = {}", fieldName, formatInfo, fieldText,
exception);
+ }
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
