marcv81 commented on code in PR #11872:
URL: https://github.com/apache/inlong/pull/11872#discussion_r2109447951
##########
inlong-sdk/dataproxy-sdk-twins/dataproxy-sdk-golang/util/id.go:
##########
@@ -29,12 +29,14 @@ var (
)
func init() {
+ var id uint32 = 0
+
+ // Generate the ID from an IP if possible.
ip, err := GetOneIP()
- if err != nil {
- log.Fatal(err)
Review Comment:
Good point. `sync.Once` is faster than `sync.Mutex` for a large number of
calls. I amended the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@inlong.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
