dark-Qy commented on PR #11933: URL: https://github.com/apache/inlong/pull/11933#issuecomment-3067788190
Hello @gunli and all contributors, My sincere apologies, I have just realized that I did not follow the correct contribution process required by the "Rhino-bird Program" I am participating in. According to the program's guidelines, I should have pushed my code to a dedicated branch (INLONG-11929) in my personal fork and then contacted the mentors via email for a review, rather than opening a Pull Request directly against the main repository. To comply with the community's contribution workflow, I will be closing this Pull Request now. Thank you very much, @gunli , for taking the time to provide such a detailed and insightful review. Your suggestions are incredibly helpful, and I will refactor my code based on your feedback (such as creating a NewHTTPClient and implementing a separate httpClient struct). I will then follow the correct submission procedure. I am very sorry for any inconvenience this has caused. Thank you for your understanding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
