spiritxishi commented on code in PR #12146: URL: https://github.com/apache/inlong/pull/12146#discussion_r3449525716
########## inlong-common/src/main/java/org/apache/inlong/common/util/PathValidationUtils.java: ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.inlong.common.util; + +import java.util.Set; + +/** + * Utility class for validating file path patterns, providing protection + * against path traversal attacks and allowed-directory enforcement. + */ +public class PathValidationUtils { + + /** + * Check whether the given path contains path traversal patterns. + * A traversal is detected when ".." appears as a complete path segment. + * + * @param path the path string to validate, may be null or empty + * @return true if the path contains a traversal segment, false otherwise + */ + public static boolean containsPathTraversal(String path) { + if (path == null || path.isEmpty()) { + return false; + } + // Normalize backslashes to forward slashes and split into segments + String normalized = path.replace('\\', '/'); + for (String segment : normalized.split("/")) { Review Comment: InlongConstants.java is in module 'manager-common', depends on 'inlong-common'，and this code is in 'inlong-common'. Should I add an var in inlong.common.constant.Constatns.java(in 'inlong-common' module) and named 'SLASH' and 'SLASH_CHAR'? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
