This is an automated email from the ASF dual-hosted git repository. tanxinyu pushed a commit to branch master_performance in repository https://gitbox.apache.org/repos/asf/iotdb.git
commit 680730439b468f1f67f774114eceea023ffe8014 Author: Mrquan <[email protected]> AuthorDate: Thu Nov 25 17:26:12 2021 +0800 add info logs (#4464) Co-authored-by: 权思屹 <[email protected]> --- server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java | 1 + .../org/apache/iotdb/db/engine/storagegroup/TsFileProcessor.java | 3 +++ .../iotdb/db/engine/storagegroup/VirtualStorageGroupProcessor.java | 3 +++ .../src/main/java/org/apache/iotdb/db/qp/executor/PlanExecutor.java | 1 + service-rpc/src/main/java/org/apache/iotdb/rpc/RpcUtils.java | 6 ++++++ .../src/main/java/org/apache/iotdb/session/SessionConnection.java | 1 + 6 files changed, 15 insertions(+) diff --git a/server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java b/server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java index 35900c7..df84d7b 100644 --- a/server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java +++ b/server/src/main/java/org/apache/iotdb/db/engine/StorageEngine.java @@ -642,6 +642,7 @@ public class StorageEngine implements IService { try { blockInsertionIfReject(null); } catch (WriteProcessRejectException e) { + logger.info("Insert tablet reject"); TSStatus[] results = new TSStatus[insertTabletPlan.getRowCount()]; Arrays.fill(results, RpcUtils.getStatus(TSStatusCode.WRITE_PROCESS_REJECT)); throw new BatchProcessException(results); diff --git a/server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileProcessor.java b/server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileProcessor.java index 0f0d827..a1403ae 100644 --- a/server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileProcessor.java +++ b/server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileProcessor.java @@ -291,6 +291,7 @@ public class TsFileProcessor { } } catch (WriteProcessException e) { for (int i = start; i < end; i++) { + logger.info("Insert tablet: write_process_reject"); results[i] = RpcUtils.getStatus(TSStatusCode.WRITE_PROCESS_REJECT, e.getMessage()); } throw new WriteProcessException(e); @@ -304,6 +305,7 @@ public class TsFileProcessor { } } catch (Exception e) { for (int i = start; i < end; i++) { + logger.info("Insert tablet: internal_server_error"); results[i] = RpcUtils.getStatus(TSStatusCode.INTERNAL_SERVER_ERROR, e.getMessage()); } if (enableMemControl && memIncrements != null) { @@ -320,6 +322,7 @@ public class TsFileProcessor { } } catch (WriteProcessException e) { for (int i = start; i < end; i++) { + logger.info("Insert tablet: internal_server_error"); results[i] = RpcUtils.getStatus(TSStatusCode.INTERNAL_SERVER_ERROR, e.getMessage()); } throw new WriteProcessException(e); diff --git a/server/src/main/java/org/apache/iotdb/db/engine/storagegroup/VirtualStorageGroupProcessor.java b/server/src/main/java/org/apache/iotdb/db/engine/storagegroup/VirtualStorageGroupProcessor.java index df72353..98239cf 100755 --- a/server/src/main/java/org/apache/iotdb/db/engine/storagegroup/VirtualStorageGroupProcessor.java +++ b/server/src/main/java/org/apache/iotdb/db/engine/storagegroup/VirtualStorageGroupProcessor.java @@ -950,6 +950,7 @@ public class VirtualStorageGroupProcessor { long currTime = insertTabletPlan.getTimes()[loc]; // skip points that do not satisfy TTL if (!isAlive(currTime)) { + logger.info("Insert tablet out of TTL"); results[loc] = RpcUtils.getStatus( TSStatusCode.OUT_OF_TTL_ERROR, @@ -962,6 +963,7 @@ public class VirtualStorageGroupProcessor { } // loc pointing at first legal position if (loc == insertTabletPlan.getRowCount()) { + logger.info("Insert tablet out of TTL of all points"); throw new BatchProcessException(results); } @@ -1079,6 +1081,7 @@ public class VirtualStorageGroupProcessor { TsFileProcessor tsFileProcessor = getOrCreateTsFileProcessor(timePartitionId, sequence); if (tsFileProcessor == null) { for (int i = start; i < end; i++) { + logger.info("Insert tablet: internal_server_error"); results[i] = RpcUtils.getStatus( TSStatusCode.INTERNAL_SERVER_ERROR, diff --git a/server/src/main/java/org/apache/iotdb/db/qp/executor/PlanExecutor.java b/server/src/main/java/org/apache/iotdb/db/qp/executor/PlanExecutor.java index b4a778f..2142758 100644 --- a/server/src/main/java/org/apache/iotdb/db/qp/executor/PlanExecutor.java +++ b/server/src/main/java/org/apache/iotdb/db/qp/executor/PlanExecutor.java @@ -1598,6 +1598,7 @@ public class PlanExecutor implements IPlanExecutor { return; } try { + logger.info("Execute insert tablet {}", insertTabletPlan.getRowCount()); insertTabletPlan.setMeasurementMNodes( new IMeasurementMNode[insertTabletPlan.getMeasurements().length]); diff --git a/service-rpc/src/main/java/org/apache/iotdb/rpc/RpcUtils.java b/service-rpc/src/main/java/org/apache/iotdb/rpc/RpcUtils.java index d383003..88dd51a 100644 --- a/service-rpc/src/main/java/org/apache/iotdb/rpc/RpcUtils.java +++ b/service-rpc/src/main/java/org/apache/iotdb/rpc/RpcUtils.java @@ -26,6 +26,9 @@ import org.apache.iotdb.service.rpc.thrift.TSFetchResultsResp; import org.apache.iotdb.service.rpc.thrift.TSIService; import org.apache.iotdb.service.rpc.thrift.TSStatus; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + import java.lang.reflect.Proxy; import java.text.SimpleDateFormat; import java.time.Instant; @@ -38,6 +41,7 @@ import java.util.Map; public class RpcUtils { + private static final Logger logger = LoggerFactory.getLogger(RpcUtils.class); /** How big should the default read and write buffers be? Defaults to 1KB */ public static final int THRIFT_DEFAULT_BUF_CAPACITY = 1024; /** @@ -137,11 +141,13 @@ public class RpcUtils { } public static void verifySuccess(List<TSStatus> statuses) throws BatchExecutionException { + logger.info("Multiple error in executing insert tablet, sub status: {}", statuses.size()); StringBuilder errMsgs = new StringBuilder(); for (TSStatus status : statuses) { if (status.getCode() != TSStatusCode.SUCCESS_STATUS.getStatusCode() && status.getCode() != TSStatusCode.NEED_REDIRECTION.getStatusCode()) { errMsgs.append(status.getMessage()).append(";"); + logger.info("error status {} ", status.getCode()); } } if (errMsgs.length() > 0) { diff --git a/session/src/main/java/org/apache/iotdb/session/SessionConnection.java b/session/src/main/java/org/apache/iotdb/session/SessionConnection.java index b5d479c..f140551 100644 --- a/session/src/main/java/org/apache/iotdb/session/SessionConnection.java +++ b/session/src/main/java/org/apache/iotdb/session/SessionConnection.java @@ -564,6 +564,7 @@ public class SessionConnection { throws IoTDBConnectionException, StatementExecutionException, RedirectException { request.setSessionId(sessionId); try { + logger.info("Execute insert tablet {}", request.getSize()); RpcUtils.verifySuccessWithRedirection(client.insertTablet(request)); } catch (TException e) { if (reconnect()) {
