This is an automated email from the ASF dual-hosted git repository.
qiaojialin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iotdb.git
The following commit(s) were added to refs/heads/master by this push:
new 2f78450 [IOTDB-2614]Fix inserting tablet with null value in
TsFileWriter (#5244)
2f78450 is described below
commit 2f784502e52e15548babb2e4b9133f0a0731ba44
Author: 周沛辰 <[email protected]>
AuthorDate: Tue Mar 15 21:44:27 2022 +0800
[IOTDB-2614]Fix inserting tablet with null value in TsFileWriter (#5244)
---
.../main/java/org/apache/iotdb/SessionExample.java | 5 +-
.../write/chunk/AlignedChunkGroupWriterImpl.java | 9 +-
.../chunk/NonAlignedChunkGroupWriterImpl.java | 6 ++
.../iotdb/tsfile/write/chunk/ValueChunkWriter.java | 12 ++-
.../apache/iotdb/tsfile/write/record/Tablet.java | 7 ++
.../iotdb/tsfile/write/TsFileWriteApiTest.java | 99 ++++++++++++++++++++++
6 files changed, 129 insertions(+), 9 deletions(-)
diff --git a/example/session/src/main/java/org/apache/iotdb/SessionExample.java
b/example/session/src/main/java/org/apache/iotdb/SessionExample.java
index b49f883..b86a4cb 100644
--- a/example/session/src/main/java/org/apache/iotdb/SessionExample.java
+++ b/example/session/src/main/java/org/apache/iotdb/SessionExample.java
@@ -451,10 +451,7 @@ public class SessionExample {
Tablet tablet = new Tablet(ROOT_SG1_D1, schemaList, 100);
// Method 1 to add tablet data
- tablet.bitMaps = new BitMap[schemaList.size()];
- for (int s = 0; s < 3; s++) {
- tablet.bitMaps[s] = new BitMap(tablet.getMaxRowNumber());
- }
+ tablet.initBitMaps();
long timestamp = System.currentTimeMillis();
for (long row = 0; row < 100; row++) {
diff --git
a/tsfile/src/main/java/org/apache/iotdb/tsfile/write/chunk/AlignedChunkGroupWriterImpl.java
b/tsfile/src/main/java/org/apache/iotdb/tsfile/write/chunk/AlignedChunkGroupWriterImpl.java
index 6c69d3a..79d9ed2 100644
---
a/tsfile/src/main/java/org/apache/iotdb/tsfile/write/chunk/AlignedChunkGroupWriterImpl.java
+++
b/tsfile/src/main/java/org/apache/iotdb/tsfile/write/chunk/AlignedChunkGroupWriterImpl.java
@@ -37,7 +37,12 @@ import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import java.io.IOException;
-import java.util.*;
+import java.util.ArrayList;
+import java.util.HashSet;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
public class AlignedChunkGroupWriterImpl implements IChunkGroupWriter {
private static final Logger LOG =
LoggerFactory.getLogger(AlignedChunkGroupWriterImpl.class);
@@ -150,7 +155,7 @@ public class AlignedChunkGroupWriterImpl implements
IChunkGroupWriter {
// check isNull by bitMap in tablet
if (tablet.bitMaps != null
&& tablet.bitMaps[columnIndex] != null
- && !tablet.bitMaps[columnIndex].isMarked(row)) {
+ && tablet.bitMaps[columnIndex].isMarked(row)) {
isNull = true;
}
ValueChunkWriter valueChunkWriter =
diff --git
a/tsfile/src/main/java/org/apache/iotdb/tsfile/write/chunk/NonAlignedChunkGroupWriterImpl.java
b/tsfile/src/main/java/org/apache/iotdb/tsfile/write/chunk/NonAlignedChunkGroupWriterImpl.java
index 8b6038e..f806327 100644
---
a/tsfile/src/main/java/org/apache/iotdb/tsfile/write/chunk/NonAlignedChunkGroupWriterImpl.java
+++
b/tsfile/src/main/java/org/apache/iotdb/tsfile/write/chunk/NonAlignedChunkGroupWriterImpl.java
@@ -94,6 +94,12 @@ public class NonAlignedChunkGroupWriterImpl implements
IChunkGroupWriter {
long time = tablet.timestamps[row];
boolean hasOneColumnWritten = false;
for (int column = 0; column < timeseries.size(); column++) {
+ // check isNull in tablet
+ if (tablet.bitMaps != null
+ && tablet.bitMaps[column] != null
+ && tablet.bitMaps[column].isMarked(row)) {
+ continue;
+ }
String measurementId = timeseries.get(column).getMeasurementId();
checkIsHistoryData(measurementId, time);
hasOneColumnWritten = true;
diff --git
a/tsfile/src/main/java/org/apache/iotdb/tsfile/write/chunk/ValueChunkWriter.java
b/tsfile/src/main/java/org/apache/iotdb/tsfile/write/chunk/ValueChunkWriter.java
index 9ea3310..3ece00b 100644
---
a/tsfile/src/main/java/org/apache/iotdb/tsfile/write/chunk/ValueChunkWriter.java
+++
b/tsfile/src/main/java/org/apache/iotdb/tsfile/write/chunk/ValueChunkWriter.java
@@ -207,13 +207,19 @@ public class ValueChunkWriter {
public long getCurrentChunkSize() {
/**
- * It may happen if pageBuffer stores empty bits and subsequent write
operations are all out of
- * order, then count of statistics in this chunk will be 0 and this chunk
will not be flushed.
+ * It may happen if subsequent write operations are all out of order, then
count of statistics
+ * in this chunk will be 0 and this chunk will not be flushed.
*/
- if (pageBuffer.size() == 0 || statistics.getCount() == 0) {
+ if (pageBuffer.size() == 0) {
return 0;
}
+ // Empty chunk, it may happen if pageBuffer stores empty bits and only
chunk header will be
+ // flushed.
+ if (statistics.getCount() == 0) {
+ return ChunkHeader.getSerializedSize(measurementId, pageBuffer.size());
+ }
+
// return the serialized size of the chunk header + all pages
return ChunkHeader.getSerializedSize(measurementId, pageBuffer.size())
+ (long) pageBuffer.size();
diff --git
a/tsfile/src/main/java/org/apache/iotdb/tsfile/write/record/Tablet.java
b/tsfile/src/main/java/org/apache/iotdb/tsfile/write/record/Tablet.java
index 9cfabc1..dd919f4 100644
--- a/tsfile/src/main/java/org/apache/iotdb/tsfile/write/record/Tablet.java
+++ b/tsfile/src/main/java/org/apache/iotdb/tsfile/write/record/Tablet.java
@@ -110,6 +110,13 @@ public class Tablet {
this.schemas = schemas;
}
+ public void initBitMaps() {
+ this.bitMaps = new BitMap[schemas.size()];
+ for (int column = 0; column < schemas.size(); column++) {
+ this.bitMaps[column] = new BitMap(getMaxRowNumber());
+ }
+ }
+
public void addTimestamp(int rowIndex, long timestamp) {
timestamps[rowIndex] = timestamp;
}
diff --git
a/tsfile/src/test/java/org/apache/iotdb/tsfile/write/TsFileWriteApiTest.java
b/tsfile/src/test/java/org/apache/iotdb/tsfile/write/TsFileWriteApiTest.java
index 6f5c8ea..cafa4a0 100644
--- a/tsfile/src/test/java/org/apache/iotdb/tsfile/write/TsFileWriteApiTest.java
+++ b/tsfile/src/test/java/org/apache/iotdb/tsfile/write/TsFileWriteApiTest.java
@@ -24,7 +24,9 @@ import org.apache.iotdb.tsfile.file.metadata.enums.TSDataType;
import org.apache.iotdb.tsfile.file.metadata.enums.TSEncoding;
import org.apache.iotdb.tsfile.fileSystem.FSFactoryProducer;
import org.apache.iotdb.tsfile.read.common.Path;
+import org.apache.iotdb.tsfile.utils.Binary;
import org.apache.iotdb.tsfile.utils.TsFileGeneratorUtils;
+import org.apache.iotdb.tsfile.write.record.Tablet;
import org.apache.iotdb.tsfile.write.schema.MeasurementSchema;
import org.junit.After;
@@ -42,6 +44,9 @@ public class TsFileWriteApiTest {
private final String deviceId = "root.sg.d1";
private final List<MeasurementSchema> alignedMeasurementSchemas = new
ArrayList<>();
private final List<MeasurementSchema> measurementSchemas = new ArrayList<>();
+ private int oldChunkGroupSize =
TSFileDescriptor.getInstance().getConfig().getGroupSizeInByte();
+ private int oldMaxNumOfPointsInPage =
+ TSFileDescriptor.getInstance().getConfig().getMaxNumberOfPointsInPage();
@Before
public void setUp() {
@@ -53,6 +58,8 @@ public class TsFileWriteApiTest {
@After
public void end() {
if (f.exists()) f.delete();
+
TSFileDescriptor.getInstance().getConfig().setMaxNumberOfPointsInPage(oldMaxNumOfPointsInPage);
+
TSFileDescriptor.getInstance().getConfig().setGroupSizeInByte(oldChunkGroupSize);
}
private void setEnv(int chunkGroupSize, int pageSize) {
@@ -324,4 +331,96 @@ public class TsFileWriteApiTest {
}
}
}
+
+ @Test
+ public void writeNonAlignedWithTabletWithNullValue() {
+ setEnv(100, 30);
+ try (TsFileWriter tsFileWriter = new TsFileWriter(f)) {
+ measurementSchemas.add(new MeasurementSchema("s1", TSDataType.TEXT,
TSEncoding.PLAIN));
+ measurementSchemas.add(new MeasurementSchema("s2", TSDataType.TEXT,
TSEncoding.PLAIN));
+ measurementSchemas.add(new MeasurementSchema("s3", TSDataType.TEXT,
TSEncoding.PLAIN));
+
+ // register nonAligned timeseries
+ tsFileWriter.registerTimeseries(new Path(deviceId), measurementSchemas);
+
+ Tablet tablet = new Tablet(deviceId, measurementSchemas);
+ long[] timestamps = tablet.timestamps;
+ Object[] values = tablet.values;
+ tablet.initBitMaps();
+ long sensorNum = measurementSchemas.size();
+ long startTime = 0;
+ for (long r = 0; r < 10000; r++) {
+ int row = tablet.rowSize++;
+ timestamps[row] = startTime++;
+ for (int i = 0; i < sensorNum; i++) {
+ if (i == 1 && r > 1000) {
+ tablet.bitMaps[i].mark((int) r % tablet.getMaxRowNumber());
+ continue;
+ }
+ Binary[] textSensor = (Binary[]) values[i];
+ textSensor[row] = new Binary("testString.........");
+ }
+ // write
+ if (tablet.rowSize == tablet.getMaxRowNumber()) {
+ tsFileWriter.write(tablet);
+ tablet.reset();
+ }
+ }
+ // write
+ if (tablet.rowSize != 0) {
+ tsFileWriter.write(tablet);
+ tablet.reset();
+ }
+
+ } catch (Throwable e) {
+ e.printStackTrace();
+ Assert.fail("Meet errors in test: " + e.getMessage());
+ }
+ }
+
+ @Test
+ public void writeAlignedWithTabletWithNullValue() {
+ setEnv(100, 30);
+ try (TsFileWriter tsFileWriter = new TsFileWriter(f)) {
+ measurementSchemas.add(new MeasurementSchema("s1", TSDataType.TEXT,
TSEncoding.PLAIN));
+ measurementSchemas.add(new MeasurementSchema("s2", TSDataType.TEXT,
TSEncoding.PLAIN));
+ measurementSchemas.add(new MeasurementSchema("s3", TSDataType.TEXT,
TSEncoding.PLAIN));
+
+ // register aligned timeseries
+ tsFileWriter.registerAlignedTimeseries(new Path(deviceId),
measurementSchemas);
+
+ Tablet tablet = new Tablet(deviceId, measurementSchemas);
+ long[] timestamps = tablet.timestamps;
+ Object[] values = tablet.values;
+ tablet.initBitMaps();
+ long sensorNum = measurementSchemas.size();
+ long startTime = 0;
+ for (long r = 0; r < 10000; r++) {
+ int row = tablet.rowSize++;
+ timestamps[row] = startTime++;
+ for (int i = 0; i < sensorNum; i++) {
+ if (i == 1 && r > 1000) {
+ tablet.bitMaps[i].mark((int) r % tablet.getMaxRowNumber());
+ continue;
+ }
+ Binary[] textSensor = (Binary[]) values[i];
+ textSensor[row] = new Binary("testString.........");
+ }
+ // write
+ if (tablet.rowSize == tablet.getMaxRowNumber()) {
+ tsFileWriter.writeAligned(tablet);
+ tablet.reset();
+ }
+ }
+ // write
+ if (tablet.rowSize != 0) {
+ tsFileWriter.writeAligned(tablet);
+ tablet.reset();
+ }
+
+ } catch (Throwable e) {
+ e.printStackTrace();
+ Assert.fail("Meet errors in test: " + e.getMessage());
+ }
+ }
}
