This is an automated email from the ASF dual-hosted git repository. jackietien pushed a commit to branch AddDetailLog in repository https://gitbox.apache.org/repos/asf/iotdb.git
commit 07b2414907f99efbac30b738310f4d3ab404a835 Author: JackieTien97 <[email protected]> AuthorDate: Tue Sep 6 14:37:21 2022 +0800 Change some useless logs to debug level --- .../commons/client/sync/SyncThriftClientWithErrorHandler.java | 6 +++--- .../iotdb/db/mpp/execution/exchange/MPPDataExchangeManager.java | 1 + .../org/apache/iotdb/db/mpp/execution/exchange/SinkHandle.java | 3 ++- .../org/apache/iotdb/db/mpp/execution/exchange/SourceHandle.java | 7 ++++++- 4 files changed, 12 insertions(+), 5 deletions(-) diff --git a/node-commons/src/main/java/org/apache/iotdb/commons/client/sync/SyncThriftClientWithErrorHandler.java b/node-commons/src/main/java/org/apache/iotdb/commons/client/sync/SyncThriftClientWithErrorHandler.java index 0601ebe251..e2b47622c6 100644 --- a/node-commons/src/main/java/org/apache/iotdb/commons/client/sync/SyncThriftClientWithErrorHandler.java +++ b/node-commons/src/main/java/org/apache/iotdb/commons/client/sync/SyncThriftClientWithErrorHandler.java @@ -62,7 +62,7 @@ public class SyncThriftClientWithErrorHandler implements MethodInterceptor { if (cur instanceof TException) { int level = 0; while (cur != null) { - LOGGER.error( + LOGGER.debug( "level-{} Exception class {}, message {}", level, cur.getClass().getName(), @@ -77,13 +77,13 @@ public class SyncThriftClientWithErrorHandler implements MethodInterceptor { if (rootCause != null) { // if the exception is SocketException and its error message is Broken pipe, it means that // the remote node may restart and all the connection we cached before should be cleared. - LOGGER.error( + LOGGER.debug( "root cause message {}, LocalizedMessage {}, ", rootCause.getMessage(), rootCause.getLocalizedMessage(), rootCause); if (isConnectionBroken(rootCause)) { - LOGGER.error( + LOGGER.debug( "Broken pipe error happened in calling method {}, we need to clear all previous cached connection, err: {}", method.getName(), t); diff --git a/server/src/main/java/org/apache/iotdb/db/mpp/execution/exchange/MPPDataExchangeManager.java b/server/src/main/java/org/apache/iotdb/db/mpp/execution/exchange/MPPDataExchangeManager.java index 2742816e0f..e14672ec88 100644 --- a/server/src/main/java/org/apache/iotdb/db/mpp/execution/exchange/MPPDataExchangeManager.java +++ b/server/src/main/java/org/apache/iotdb/db/mpp/execution/exchange/MPPDataExchangeManager.java @@ -262,6 +262,7 @@ public class MPPDataExchangeManager implements IMPPDataExchangeManager { @Override public void onFinish(ISinkHandle sinkHandle) { + logger.info("onFinish is invoked"); removeFromMPPDataExchangeManager(sinkHandle); context.finished(); } diff --git a/server/src/main/java/org/apache/iotdb/db/mpp/execution/exchange/SinkHandle.java b/server/src/main/java/org/apache/iotdb/db/mpp/execution/exchange/SinkHandle.java index 4cc0539a01..8d58327bed 100644 --- a/server/src/main/java/org/apache/iotdb/db/mpp/execution/exchange/SinkHandle.java +++ b/server/src/main/java/org/apache/iotdb/db/mpp/execution/exchange/SinkHandle.java @@ -279,7 +279,7 @@ public class SinkHandle implements ISinkHandle { Pair<TsBlock, Long> pair = sequenceIdToTsBlock.get(sequenceId); if (pair == null || pair.left == null) { logger.error( - "The data block doesn't exist. Sequence ID is {}, remaining map is {}", + "The TsBlock doesn't exist. Sequence ID is {}, remaining map is {}", sequenceId, sequenceIdToTsBlock.entrySet()); throw new IllegalStateException("The data block doesn't exist. Sequence ID: " + sequenceId); @@ -307,6 +307,7 @@ public class SinkHandle implements ISinkHandle { freedBytes += entry.getValue().right; bufferRetainedSizeInBytes -= entry.getValue().right; iterator.remove(); + logger.info("ack TsBlock {}.", entry.getKey()); } } if (isFinished()) { diff --git a/server/src/main/java/org/apache/iotdb/db/mpp/execution/exchange/SourceHandle.java b/server/src/main/java/org/apache/iotdb/db/mpp/execution/exchange/SourceHandle.java index c0a353f8b9..bd95291eb9 100644 --- a/server/src/main/java/org/apache/iotdb/db/mpp/execution/exchange/SourceHandle.java +++ b/server/src/main/java/org/apache/iotdb/db/mpp/execution/exchange/SourceHandle.java @@ -410,7 +410,12 @@ public class SourceHandle implements ISourceHandle { } break; } catch (Throwable e) { - logger.error("failed to get data block, attempt times: {}", attempt, e); + logger.error( + "failed to get data block [{}, {}), attempt times: {}", + startSequenceId, + endSequenceId, + attempt, + e); if (attempt == MAX_ATTEMPT_TIMES) { synchronized (SourceHandle.this) { bufferRetainedSizeInBytes -= reservedBytes;
