(iotdb) branch master updated: [IOTDB-6206] Metric Core: Shrink ringBuffer length to optimize histogram and timer's record performance (#11500)

[tanxinyu]

This is an automated email from the ASF dual-hosted git repository.

tanxinyu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iotdb.git


The following commit(s) were added to refs/heads/master by this push:
     new a4510266fdb [IOTDB-6206] Metric Core: Shrink ringBuffer length to 
optimize histogram and timer's record performance (#11500)
a4510266fdb is described below

commit a4510266fdb74e95f0cfabec36ad3f16155eaa60
Author: Peng Junzhi <78788603+peng...@users.noreply.github.com>
AuthorDate: Thu Nov 9 10:32:07 2023 +0800

    [IOTDB-6206] Metric Core: Shrink ringBuffer length to optimize histogram 
and timer's record performance (#11500)
---
 .../java/org/apache/iotdb/metrics/core/IoTDBMetricManager.java |  3 ++-
 .../java/org/apache/iotdb/metrics/AbstractMetricManager.java   | 10 +++-------
 .../org/apache/iotdb/metrics/impl/DoNothingMetricManager.java  |  2 +-
 3 files changed, 6 insertions(+), 9 deletions(-)

diff --git 
a/iotdb-core/metrics/core/src/main/java/org/apache/iotdb/metrics/core/IoTDBMetricManager.java
 
b/iotdb-core/metrics/core/src/main/java/org/apache/iotdb/metrics/core/IoTDBMetricManager.java
index 5f8ceb4444f..5e0616bc21b 100644
--- 
a/iotdb-core/metrics/core/src/main/java/org/apache/iotdb/metrics/core/IoTDBMetricManager.java
+++ 
b/iotdb-core/metrics/core/src/main/java/org/apache/iotdb/metrics/core/IoTDBMetricManager.java
@@ -67,6 +67,7 @@ public class IoTDBMetricManager extends AbstractMetricManager 
{
     DistributionStatisticConfig distributionStatisticConfig =
         DistributionStatisticConfig.builder()
             .percentiles(0.5, 0.99)
+            .bufferLength(2)
             .build()
             .merge(defaultHistogramConfig);
 
@@ -106,7 +107,7 @@ public class IoTDBMetricManager extends 
AbstractMetricManager {
   }
 
   @Override
-  public Timer createTimer(MetricInfo metricInfo) {
+  public Timer createTimer() {
     // set pauseDetector
     PauseDetector pauseDetector = new NoPauseDetector();
 
diff --git 
a/iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/AbstractMetricManager.java
 
b/iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/AbstractMetricManager.java
index a32201b5166..b070d6e963e 100644
--- 
a/iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/AbstractMetricManager.java
+++ 
b/iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/AbstractMetricManager.java
@@ -283,7 +283,7 @@ public abstract class AbstractMetricManager {
         metrics.computeIfAbsent(
             metricInfo,
             key -> {
-              Timer timer = createTimer(metricInfo);
+              Timer timer = createTimer();
               nameToMetaInfo.put(name, metricInfo.getMetaInfo());
               notifyReporterOnAdd(timer, metricInfo);
               return timer;
@@ -294,12 +294,8 @@ public abstract class AbstractMetricManager {
     throw new IllegalArgumentException(metricInfo + ALREADY_EXISTS);
   }
 
-  /**
-   * Create timer according to metric framework.
-   *
-   * @param metricInfo the metricInfo of metric
-   */
-  protected abstract Timer createTimer(MetricInfo metricInfo);
+  /** Create timer according to metric framework. */
+  protected abstract Timer createTimer();
 
   // endregion
 
diff --git 
a/iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/impl/DoNothingMetricManager.java
 
b/iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/impl/DoNothingMetricManager.java
index 9fea7ceae80..d46b28a6d9c 100644
--- 
a/iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/impl/DoNothingMetricManager.java
+++ 
b/iotdb-core/metrics/interface/src/main/java/org/apache/iotdb/metrics/impl/DoNothingMetricManager.java
@@ -67,7 +67,7 @@ public class DoNothingMetricManager extends 
AbstractMetricManager {
   }
 
   @Override
-  public Timer createTimer(MetricInfo metricInfo) {
+  public Timer createTimer() {
     return DO_NOTHING_TIMER;
   }