(iotdb) branch master updated: Fix some code smells of JDBC module (#11588)

[wangchao316]

This is an automated email from the ASF dual-hosted git repository.

wangchao316 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iotdb.git


The following commit(s) were added to refs/heads/master by this push:
     new b2b17d5aa02 Fix some code smells of JDBC module (#11588)
b2b17d5aa02 is described below

commit b2b17d5aa02d98718874826ff0b5a6b4043edbc4
Author: Bo Cui <cuibo0...@163.com>
AuthorDate: Tue Nov 21 13:25:48 2023 +0800

    Fix some code smells of JDBC module (#11588)
    
    Fix some code smells of JDBC module (#11588)
---
 .../src/main/java/org/apache/iotdb/jdbc/IoTDBJDBCResultSet.java   | 2 +-
 .../jdbc/src/main/java/org/apache/iotdb/jdbc/StringUtils.java     | 8 +++-----
 2 files changed, 4 insertions(+), 6 deletions(-)

diff --git 
a/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBJDBCResultSet.java 
b/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBJDBCResultSet.java
index 86a68ca0bea..61102f74f11 100644
--- 
a/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBJDBCResultSet.java
+++ 
b/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBJDBCResultSet.java
@@ -481,7 +481,7 @@ public class IoTDBJDBCResultSet implements ResultSet {
         this.sgColumns = ((IoTDBJDBCResultSet) 
statement.getResultSet()).getSgColumns();
       }
     } catch (SQLException throwables) {
-      LOGGER.error(String.format("get meta data error:%s", 
throwables.getMessage()));
+      LOGGER.error("get meta data error: {}", throwables.getMessage());
     }
     return new IoTDBResultMetadata(
         nonAlign,
diff --git 
a/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/StringUtils.java 
b/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/StringUtils.java
index c6485647257..959aa7304ca 100644
--- a/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/StringUtils.java
+++ b/iotdb-client/jdbc/src/main/java/org/apache/iotdb/jdbc/StringUtils.java
@@ -55,7 +55,7 @@ public class StringUtils {
     try {
       toPlainStringMethod = BigDecimal.class.getMethod("toPlainString");
     } catch (NoSuchMethodException nsme) {
-      LOGGER.info(String.format("To plain String method Error: %s", nsme));
+      LOGGER.warn("To plain String method Error:", nsme);
     }
   }
 
@@ -66,10 +66,8 @@ public class StringUtils {
     if (toPlainStringMethod != null) {
       try {
         return (String) toPlainStringMethod.invoke(decimal, null);
-      } catch (InvocationTargetException invokeEx) {
-        LOGGER.info(String.format("consistent to String Error: %s", invokeEx));
-      } catch (IllegalAccessException accessEx) {
-        LOGGER.info(String.format("consistent to String Error: %s", accessEx));
+      } catch (InvocationTargetException | IllegalAccessException e) {
+        LOGGER.warn("consistent to String Error:", e);
       }
     }
     return decimal.toString();