This is an automated email from the ASF dual-hosted git repository.

lancelly pushed a commit to branch BinaryTransformer
in repository https://gitbox.apache.org/repos/asf/iotdb.git

commit 75c179b6e6cd03442b07793ae80483ef2b5b2103
Author: lancelly <[email protected]>
AuthorDate: Tue Nov 28 16:04:28 2023 +0800

    accelerate Binary compare
---
 .../dag/column/binary/CompareBinaryColumnTransformer.java              | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git 
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/transformation/dag/column/binary/CompareBinaryColumnTransformer.java
 
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/transformation/dag/column/binary/CompareBinaryColumnTransformer.java
index cdd9d3e3712..970d3f9ee25 100644
--- 
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/transformation/dag/column/binary/CompareBinaryColumnTransformer.java
+++ 
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/transformation/dag/column/binary/CompareBinaryColumnTransformer.java
@@ -36,7 +36,8 @@ public abstract class CompareBinaryColumnTransformer extends 
BinaryColumnTransfo
   @Override
   protected void doTransform(
       Column leftColumn, Column rightColumn, ColumnBuilder builder, int 
positionCount) {
-    // if either column is all null, append nullCount
+    // if either column is all null, append nullCount. For now, a 
RunLengthEncodeColumn with
+    // mayHaveNull == true is all null
     if ((leftColumn.mayHaveNull() && leftColumn instanceof 
RunLengthEncodedColumn)
         || (rightColumn.mayHaveNull() && rightColumn instanceof 
RunLengthEncodedColumn)) {
       builder.appendNull(positionCount);

Reply via email to