This is an automated email from the ASF dual-hosted git repository.

tanxinyu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iotdb.git


The following commit(s) were added to refs/heads/master by this push:
     new 177cc9a0e5b Add log for NotEnoughDataNodeException (#11815)
177cc9a0e5b is described below

commit 177cc9a0e5b42eec27c21400308d56ab43435b04
Author: Yongzao <[email protected]>
AuthorDate: Tue Jan 2 14:56:41 2024 +0800

    Add log for NotEnoughDataNodeException (#11815)
    
    * finish
    
    * code smell
---
 .../confignode/exception/NotEnoughDataNodeException.java    | 13 +++++++++++--
 .../confignode/manager/load/balancer/RegionBalancer.java    |  2 +-
 2 files changed, 12 insertions(+), 3 deletions(-)

diff --git 
a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/exception/NotEnoughDataNodeException.java
 
b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/exception/NotEnoughDataNodeException.java
index 7aacf4f8ea3..fa54afc48b0 100644
--- 
a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/exception/NotEnoughDataNodeException.java
+++ 
b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/exception/NotEnoughDataNodeException.java
@@ -19,9 +19,18 @@
 
 package org.apache.iotdb.confignode.exception;
 
+import org.apache.iotdb.common.rpc.thrift.TDataNodeConfiguration;
+
+import java.util.List;
+
 public class NotEnoughDataNodeException extends ConfigNodeException {
 
-  public NotEnoughDataNodeException() {
-    super("DataNode is not enough, please register more.");
+  public NotEnoughDataNodeException(
+      List<TDataNodeConfiguration> dataNodeConfigurations, int 
replicationFactor) {
+    super(
+        String.format(
+            "DataNode is not enough, please register more. "
+                + "Current DataNodes: %s, replicationFactor: %d",
+            dataNodeConfigurations, replicationFactor));
   }
 }
diff --git 
a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/balancer/RegionBalancer.java
 
b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/balancer/RegionBalancer.java
index 9fb45628f50..9c91c862845 100644
--- 
a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/balancer/RegionBalancer.java
+++ 
b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/load/balancer/RegionBalancer.java
@@ -84,7 +84,7 @@ public class RegionBalancer {
       int replicationFactor =
           getClusterSchemaManager().getReplicationFactor(database, 
consensusGroupType);
       if (availableDataNodes.size() < replicationFactor) {
-        throw new NotEnoughDataNodeException();
+        throw new NotEnoughDataNodeException(availableDataNodes, 
replicationFactor);
       }
     }
 

Reply via email to