This is an automated email from the ASF dual-hosted git repository.
haonan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iotdb.git
The following commit(s) were added to refs/heads/master by this push:
new f53a3fab371 Remove useless writing metric item (#11889)
f53a3fab371 is described below
commit f53a3fab3710ec6acaa53b23c0fd7cbde3befac0
Author: shuwenwei <[email protected]>
AuthorDate: Fri Jan 12 16:32:57 2024 +0800
Remove useless writing metric item (#11889)
---
.../apache/iotdb/db/service/metrics/WritingMetrics.java | 16 +---------------
.../storageengine/dataregion/wal/buffer/WALBuffer.java | 2 --
2 files changed, 1 insertion(+), 17 deletions(-)
diff --git
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/metrics/WritingMetrics.java
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/metrics/WritingMetrics.java
index 505ecd2d529..efe2dacda2d 100644
---
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/metrics/WritingMetrics.java
+++
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/metrics/WritingMetrics.java
@@ -222,7 +222,6 @@ public class WritingMetrics implements IMetricSet {
private Timer globalMemoryTableInfoTimer =
DoNothingMetricManager.DO_NOTHING_TIMER;
private Timer createMemoryTableTimer =
DoNothingMetricManager.DO_NOTHING_TIMER;
private Timer flushMemoryTableTimer =
DoNothingMetricManager.DO_NOTHING_TIMER;
- private Timer serializeOneWalInfoEntryTimer =
DoNothingMetricManager.DO_NOTHING_TIMER;
private Timer serializeWalEntryTotalTimer =
DoNothingMetricManager.DO_NOTHING_TIMER;
private Timer syncTimer = DoNothingMetricManager.DO_NOTHING_TIMER;
private Timer fsyncTimer = DoNothingMetricManager.DO_NOTHING_TIMER;
@@ -252,14 +251,6 @@ public class WritingMetrics implements IMetricSet {
MAKE_CHECKPOINT,
Tag.TYPE.toString(),
CheckpointType.FLUSH_MEMORY_TABLE.toString());
- serializeOneWalInfoEntryTimer =
- metricService.getOrCreateTimer(
- Metric.WAL_COST.toString(),
- MetricLevel.IMPORTANT,
- Tag.STAGE.toString(),
- SERIALIZE_WAL_ENTRY,
- Tag.TYPE.toString(),
- SERIALIZE_ONE_WAL_INFO_ENTRY);
serializeWalEntryTotalTimer =
metricService.getOrCreateTimer(
Metric.WAL_COST.toString(),
@@ -290,7 +281,6 @@ public class WritingMetrics implements IMetricSet {
globalMemoryTableInfoTimer = DoNothingMetricManager.DO_NOTHING_TIMER;
createMemoryTableTimer = DoNothingMetricManager.DO_NOTHING_TIMER;
flushMemoryTableTimer = DoNothingMetricManager.DO_NOTHING_TIMER;
- serializeOneWalInfoEntryTimer = DoNothingMetricManager.DO_NOTHING_TIMER;
serializeWalEntryTotalTimer = DoNothingMetricManager.DO_NOTHING_TIMER;
syncTimer = DoNothingMetricManager.DO_NOTHING_TIMER;
fsyncTimer = DoNothingMetricManager.DO_NOTHING_TIMER;
@@ -307,7 +297,7 @@ public class WritingMetrics implements IMetricSet {
MAKE_CHECKPOINT,
Tag.TYPE.toString(),
type));
- Arrays.asList(SERIALIZE_ONE_WAL_INFO_ENTRY, SERIALIZE_WAL_ENTRY_TOTAL)
+ Arrays.asList(SERIALIZE_WAL_ENTRY_TOTAL)
.forEach(
type ->
metricService.remove(
@@ -739,10 +729,6 @@ public class WritingMetrics implements IMetricSet {
}
}
- public void recordSerializeOneWALInfoEntryCost(long costTimeInNanos) {
- serializeOneWalInfoEntryTimer.updateNanos(costTimeInNanos);
- }
-
public void recordSerializeWALEntryTotalCost(long costTimeInNanos) {
serializeWalEntryTotalTimer.updateNanos(costTimeInNanos);
}
diff --git
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/buffer/WALBuffer.java
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/buffer/WALBuffer.java
index cdae8baa1c7..dea4a55c4ab 100644
---
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/buffer/WALBuffer.java
+++
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/buffer/WALBuffer.java
@@ -281,9 +281,7 @@ public class WALBuffer extends AbstractWALBuffer {
int size = byteBufferView.position();
try {
- long start = System.nanoTime();
walEntry.serialize(byteBufferView);
- WRITING_METRICS.recordSerializeOneWALInfoEntryCost(System.nanoTime() -
start);
size = byteBufferView.position() - size;
} catch (Exception e) {
logger.error(
