(iotdb) branch master updated: Warn user if they use GraalVM (#12238)

[tanxinyu]

This is an automated email from the ASF dual-hosted git repository.

tanxinyu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iotdb.git


The following commit(s) were added to refs/heads/master by this push:
     new 6bee4cc6b7f Warn user if they use GraalVM (#12238)
6bee4cc6b7f is described below

commit 6bee4cc6b7f22da585d7b2b7d7518af2ffe267a6
Author: Li Yu Heng <liyuheng55...@126.com>
AuthorDate: Tue Mar 26 18:51:53 2024 +0800

    Warn user if they use GraalVM (#12238)
---
 .../iotdb/commons/service/StartupChecks.java       | 43 +++++++++++++++-------
 1 file changed, 30 insertions(+), 13 deletions(-)

diff --git 
a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/service/StartupChecks.java
 
b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/service/StartupChecks.java
index cd247bf3b79..6199c18ee9f 100644
--- 
a/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/service/StartupChecks.java
+++ 
b/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/service/StartupChecks.java
@@ -25,6 +25,8 @@ import org.apache.iotdb.commons.utils.JVMCommonUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import java.lang.management.ManagementFactory;
+import java.lang.management.RuntimeMXBean;
 import java.util.ArrayList;
 import java.util.List;
 
@@ -33,18 +35,7 @@ public abstract class StartupChecks {
   private static final Logger logger = 
LoggerFactory.getLogger(StartupChecks.class);
 
   private final String nodeRole;
-  private static final StartupCheck checkJDK =
-      () -> {
-        int version = JVMCommonUtils.getJdkVersion();
-        if (version < IoTDBConstant.MIN_SUPPORTED_JDK_VERSION) {
-          throw new StartupException(
-              String.format(
-                  "Requires JDK version >= %d, current version is %d.",
-                  IoTDBConstant.MIN_SUPPORTED_JDK_VERSION, version));
-        } else {
-          logger.info("JDK version is {}.", version);
-        }
-      };
+
   protected final List<StartupCheck> preChecks = new ArrayList<>();
 
   protected StartupChecks(String nodeRole) {
@@ -76,9 +67,35 @@ public abstract class StartupChecks {
     }
   }
 
+  private void checkJDK() throws StartupException {
+    int version = JVMCommonUtils.getJdkVersion();
+    if (version < IoTDBConstant.MIN_SUPPORTED_JDK_VERSION) {
+      throw new StartupException(
+          String.format(
+              "Requires JDK version >= %d, current version is %d.",
+              IoTDBConstant.MIN_SUPPORTED_JDK_VERSION, version));
+    } else {
+      logger.info("JDK version is {}.", version);
+    }
+  }
+
+  private void checkJVM() {
+    RuntimeMXBean bean = ManagementFactory.getRuntimeMXBean();
+    logger.info("JVM version is {} {}.", bean.getVmName(), 
bean.getVmVersion());
+    try {
+      // For more information, visit 
https://github.com/oracle/graal/issues/8638
+      Class.forName("org.graalvm.home.Version");
+    } catch (ClassNotFoundException e) {
+      return;
+    }
+    logger.warn(
+        "Perhaps you are using GraalVM, which is strongly not recommended. 
Using GraalVM may cause strange problems after the system runs for a while. 
Please check your JVM version.");
+  }
+
   protected void envCheck() {
     preChecks.add(() -> checkJMXPort(nodeRole));
-    preChecks.add(checkJDK);
+    preChecks.add(this::checkJDK);
+    preChecks.add(this::checkJVM);
   }
   /** execute every pretest. */
   protected void verify() throws StartupException {