This is an automated email from the ASF dual-hosted git repository.
rong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iotdb.git
The following commit(s) were added to refs/heads/master by this push:
new fa2a14a1a7e Pipe: Added debug logger after schema/config event is
successfully transferred (#12362)
fa2a14a1a7e is described below
commit fa2a14a1a7efff19b43882ae338dbd68e5bb4ab0
Author: Caideyipi <[email protected]>
AuthorDate: Thu Apr 18 15:05:10 2024 +0800
Pipe: Added debug logger after schema/config event is successfully
transferred (#12362)
---
.../protocol/IoTDBConfigRegionConnector.java | 44 ++++++++++++----------
.../thrift/sync/IoTDBDataNodeSyncConnector.java | 22 ++++++-----
.../thrift/sync/IoTDBSchemaRegionConnector.java | 14 +++----
3 files changed, 45 insertions(+), 35 deletions(-)
diff --git
a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/connector/protocol/IoTDBConfigRegionConnector.java
b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/connector/protocol/IoTDBConfigRegionConnector.java
index 6058fed3027..28387ad699c 100644
---
a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/connector/protocol/IoTDBConfigRegionConnector.java
+++
b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/connector/protocol/IoTDBConfigRegionConnector.java
@@ -55,43 +55,43 @@ public class IoTDBConfigRegionConnector extends
IoTDBSslSyncConnector {
@Override
protected IoTDBSyncClientManager constructClient(
- List<TEndPoint> nodeUrls,
- boolean useSSL,
- String trustStorePath,
- String trustStorePwd,
- boolean useLeaderCache,
- String loadBalanceStrategy) {
+ final List<TEndPoint> nodeUrls,
+ final boolean useSSL,
+ final String trustStorePath,
+ final String trustStorePwd,
+ final boolean useLeaderCache,
+ final String loadBalanceStrategy) {
return new IoTDBConfigNodeSyncClientManager(
nodeUrls, useSSL, trustStorePath, trustStorePwd, loadBalanceStrategy);
}
@Override
protected PipeTransferFilePieceReq getTransferSingleFilePieceReq(
- String fileName, long position, byte[] payLoad) {
+ final String fileName, final long position, final byte[] payLoad) {
throw new UnsupportedOperationException(
"The config region connector does not support transferring single file
piece req.");
}
@Override
protected PipeTransferFilePieceReq getTransferMultiFilePieceReq(
- String fileName, long position, byte[] payLoad) throws IOException {
+ final String fileName, final long position, final byte[] payLoad) throws
IOException {
return PipeTransferConfigSnapshotPieceReq.toTPipeTransferReq(fileName,
position, payLoad);
}
@Override
- public void transfer(TabletInsertionEvent tabletInsertionEvent) throws
Exception {
+ public void transfer(final TabletInsertionEvent tabletInsertionEvent) throws
Exception {
throw new UnsupportedOperationException(
"IoTDBConfigRegionConnector can't transfer TabletInsertionEvent.");
}
@Override
- public void transfer(TsFileInsertionEvent tsFileInsertionEvent) throws
Exception {
+ public void transfer(final TsFileInsertionEvent tsFileInsertionEvent) throws
Exception {
throw new UnsupportedOperationException(
"IoTDBConfigRegionConnector can't transfer TsFileInsertionEvent.");
}
@Override
- public void transfer(Event event) throws Exception {
+ public void transfer(final Event event) throws Exception {
if (event instanceof PipeConfigRegionWritePlanEvent) {
doTransfer((PipeConfigRegionWritePlanEvent) event);
} else if (event instanceof PipeConfigRegionSnapshotEvent) {
@@ -102,7 +102,8 @@ public class IoTDBConfigRegionConnector extends
IoTDBSslSyncConnector {
}
}
- private void doTransfer(PipeConfigRegionWritePlanEvent writePlanEvent)
throws PipeException {
+ private void doTransfer(final PipeConfigRegionWritePlanEvent
pipeConfigRegionWritePlanEvent)
+ throws PipeException {
final Pair<IoTDBSyncClient, Boolean> clientAndStatus =
clientManager.getClient();
final TPipeTransferResp resp;
@@ -112,13 +113,13 @@ public class IoTDBConfigRegionConnector extends
IoTDBSslSyncConnector {
.getLeft()
.pipeTransfer(
PipeTransferConfigPlanReq.toTPipeTransferReq(
- writePlanEvent.getConfigPhysicalPlan()));
- } catch (Exception e) {
+ pipeConfigRegionWritePlanEvent.getConfigPhysicalPlan()));
+ } catch (final Exception e) {
clientAndStatus.setRight(false);
throw new PipeConnectionException(
String.format(
"Network error when transfer config region write plan %s,
because %s.",
- writePlanEvent.getConfigPhysicalPlan().getType(),
e.getMessage()),
+
pipeConfigRegionWritePlanEvent.getConfigPhysicalPlan().getType(),
e.getMessage()),
e);
}
@@ -134,12 +135,16 @@ public class IoTDBConfigRegionConnector extends
IoTDBSslSyncConnector {
status,
String.format(
"Transfer config region write plan %s error, result status %s.",
- writePlanEvent.getConfigPhysicalPlan().getType(), status),
- writePlanEvent.getConfigPhysicalPlan().toString());
+
pipeConfigRegionWritePlanEvent.getConfigPhysicalPlan().getType(), status),
+ pipeConfigRegionWritePlanEvent.getConfigPhysicalPlan().toString());
+ }
+
+ if (LOGGER.isDebugEnabled()) {
+ LOGGER.debug("Successfully transferred config event {}.",
pipeConfigRegionWritePlanEvent);
}
}
- private void doTransfer(PipeConfigRegionSnapshotEvent snapshotEvent)
+ private void doTransfer(final PipeConfigRegionSnapshotEvent snapshotEvent)
throws PipeException, IOException {
final File snapshotFile = snapshotEvent.getSnapshotFile();
final File templateFile = snapshotEvent.getTemplateFile();
@@ -164,7 +169,7 @@ public class IoTDBConfigRegionConnector extends
IoTDBSslSyncConnector {
Objects.nonNull(templateFile) ? templateFile.length() :
0,
snapshotEvent.getFileType(),
snapshotEvent.toSealTypeString()));
- } catch (Exception e) {
+ } catch (final Exception e) {
clientAndStatus.setRight(false);
throw new PipeConnectionException(
String.format(
@@ -188,6 +193,7 @@ public class IoTDBConfigRegionConnector extends
IoTDBSslSyncConnector {
snapshotFile, resp.getStatus()),
snapshotFile.toString());
}
+
LOGGER.info("Successfully transferred config region snapshot {}.",
snapshotFile);
}
}
diff --git
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/thrift/sync/IoTDBDataNodeSyncConnector.java
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/thrift/sync/IoTDBDataNodeSyncConnector.java
index 61493b31212..3bfadf2036d 100644
---
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/thrift/sync/IoTDBDataNodeSyncConnector.java
+++
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/thrift/sync/IoTDBDataNodeSyncConnector.java
@@ -52,7 +52,7 @@ public abstract class IoTDBDataNodeSyncConnector extends
IoTDBSslSyncConnector {
protected IoTDBDataNodeSyncClientManager clientManager;
@Override
- public void validate(PipeParameterValidator validator) throws Exception {
+ public void validate(final PipeParameterValidator validator) throws
Exception {
super.validate(validator);
final IoTDBConfig iotdbConfig = IoTDBDescriptor.getInstance().getConfig();
@@ -80,19 +80,19 @@ public abstract class IoTDBDataNodeSyncConnector extends
IoTDBSslSyncConnector {
@Override
protected IoTDBSyncClientManager constructClient(
- List<TEndPoint> nodeUrls,
- boolean useSSL,
- String trustStorePath,
- String trustStorePwd,
- boolean useLeaderCache,
- String loadBalanceStrategy) {
+ final List<TEndPoint> nodeUrls,
+ final boolean useSSL,
+ final String trustStorePath,
+ final String trustStorePwd,
+ final boolean useLeaderCache,
+ final String loadBalanceStrategy) {
clientManager =
new IoTDBDataNodeSyncClientManager(
nodeUrls, useSSL, trustStorePath, trustStorePwd, useLeaderCache,
loadBalanceStrategy);
return clientManager;
}
- protected void doTransfer(PipeSchemaRegionWritePlanEvent
pipeSchemaRegionWritePlanEvent)
+ protected void doTransfer(final PipeSchemaRegionWritePlanEvent
pipeSchemaRegionWritePlanEvent)
throws PipeException {
final Pair<IoTDBSyncClient, Boolean> clientAndStatus =
clientManager.getClient();
@@ -104,7 +104,7 @@ public abstract class IoTDBDataNodeSyncConnector extends
IoTDBSslSyncConnector {
.pipeTransfer(
PipeTransferPlanNodeReq.toTPipeTransferReq(
pipeSchemaRegionWritePlanEvent.getPlanNode()));
- } catch (Exception e) {
+ } catch (final Exception e) {
clientAndStatus.setRight(false);
throw new PipeConnectionException(
String.format(
@@ -124,5 +124,9 @@ public abstract class IoTDBDataNodeSyncConnector extends
IoTDBSslSyncConnector {
pipeSchemaRegionWritePlanEvent.getPlanNode().getType(), status),
pipeSchemaRegionWritePlanEvent.getPlanNode().toString());
}
+
+ if (LOGGER.isDebugEnabled()) {
+ LOGGER.debug("Successfully transferred schema event {}.",
pipeSchemaRegionWritePlanEvent);
+ }
}
}
diff --git
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/thrift/sync/IoTDBSchemaRegionConnector.java
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/thrift/sync/IoTDBSchemaRegionConnector.java
index 8a8563a6b12..e5e0a75390a 100644
---
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/thrift/sync/IoTDBSchemaRegionConnector.java
+++
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/thrift/sync/IoTDBSchemaRegionConnector.java
@@ -47,19 +47,19 @@ public class IoTDBSchemaRegionConnector extends
IoTDBDataNodeSyncConnector {
private static final Logger LOGGER =
LoggerFactory.getLogger(IoTDBSchemaRegionConnector.class);
@Override
- public void transfer(TabletInsertionEvent tabletInsertionEvent) throws
Exception {
+ public void transfer(final TabletInsertionEvent tabletInsertionEvent) throws
Exception {
throw new UnsupportedOperationException(
"IoTDBSchemaRegionConnector can't transfer TabletInsertionEvent.");
}
@Override
- public void transfer(TsFileInsertionEvent tsFileInsertionEvent) throws
Exception {
+ public void transfer(final TsFileInsertionEvent tsFileInsertionEvent) throws
Exception {
throw new UnsupportedOperationException(
"IoTDBSchemaRegionConnector can't transfer TsFileInsertionEvent.");
}
@Override
- public void transfer(Event event) throws Exception {
+ public void transfer(final Event event) throws Exception {
if (event instanceof PipeSchemaRegionWritePlanEvent) {
doTransfer((PipeSchemaRegionWritePlanEvent) event);
} else if (event instanceof PipeSchemaRegionSnapshotEvent) {
@@ -70,7 +70,7 @@ public class IoTDBSchemaRegionConnector extends
IoTDBDataNodeSyncConnector {
}
}
- private void doTransfer(PipeSchemaRegionSnapshotEvent snapshotEvent)
+ private void doTransfer(final PipeSchemaRegionSnapshotEvent snapshotEvent)
throws PipeException, IOException {
final File mTreeSnapshotFile = snapshotEvent.getMTreeSnapshotFile();
final File tagLogSnapshotFile = snapshotEvent.getTagLogSnapshotFile();
@@ -95,7 +95,7 @@ public class IoTDBSchemaRegionConnector extends
IoTDBDataNodeSyncConnector {
Objects.nonNull(tagLogSnapshotFile) ?
tagLogSnapshotFile.length() : 0,
snapshotEvent.getDatabaseName(),
snapshotEvent.toSealTypeString()));
- } catch (Exception e) {
+ } catch (final Exception e) {
clientAndStatus.setRight(false);
throw new PipeConnectionException(
String.format(
@@ -120,14 +120,14 @@ public class IoTDBSchemaRegionConnector extends
IoTDBDataNodeSyncConnector {
@Override
protected PipeTransferFilePieceReq getTransferSingleFilePieceReq(
- String fileName, long position, byte[] payLoad) {
+ final String fileName, final long position, final byte[] payLoad) {
throw new UnsupportedOperationException(
"The schema region connector does not support transferring single file
piece req.");
}
@Override
protected PipeTransferFilePieceReq getTransferMultiFilePieceReq(
- String fileName, long position, byte[] payLoad) throws IOException {
+ final String fileName, final long position, final byte[] payLoad) throws
IOException {
return PipeTransferSchemaSnapshotPieceReq.toTPipeTransferReq(fileName,
position, payLoad);
}
}
