(iotdb) branch master updated: [IOTDB-6322] Let show variables can be executed by anyone

[jackietien]

This is an automated email from the ASF dual-hosted git repository.

jackietien pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iotdb.git


The following commit(s) were added to refs/heads/master by this push:
     new ec15f3deda5 [IOTDB-6322] Let show variables can be executed by anyone
ec15f3deda5 is described below

commit ec15f3deda53c91b2012c03273352c0f3ebf2fc9
Author: Jackie Tien <jackietie...@gmail.com>
AuthorDate: Fri Apr 19 16:29:53 2024 +0800

    [IOTDB-6322] Let show variables can be executed by anyone
---
 .../org/apache/iotdb/db/it/auth/IoTDBSystemPermissionIT.java     | 6 ------
 .../plan/statement/metadata/ShowVariablesStatement.java          | 9 +--------
 2 files changed, 1 insertion(+), 14 deletions(-)

diff --git 
a/integration-test/src/test/java/org/apache/iotdb/db/it/auth/IoTDBSystemPermissionIT.java
 
b/integration-test/src/test/java/org/apache/iotdb/db/it/auth/IoTDBSystemPermissionIT.java
index 1c4e81ddaac..4b3cebd68f1 100644
--- 
a/integration-test/src/test/java/org/apache/iotdb/db/it/auth/IoTDBSystemPermissionIT.java
+++ 
b/integration-test/src/test/java/org/apache/iotdb/db/it/auth/IoTDBSystemPermissionIT.java
@@ -193,11 +193,6 @@ public class IoTDBSystemPermissionIT {
 
   @Test
   public void maintainOperationsTest() {
-    assertNonQueryTestFail(
-        "show variables",
-        "803: No permissions for this operation, please add privilege 
MAINTAIN",
-        "test",
-        "test123");
     assertNonQueryTestFail(
         "show queries",
         "803: No permissions for this operation, please add privilege 
MAINTAIN",
@@ -221,7 +216,6 @@ public class IoTDBSystemPermissionIT {
 
     grantUserSystemPrivileges("test", PrivilegeType.MAINTAIN);
 
-    executeNonQuery("show variables", "test", "test123");
     executeNonQuery("show queries", "test", "test123");
     assertNonQueryTestFail(
         "kill query 'test'",
diff --git 
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/metadata/ShowVariablesStatement.java
 
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/metadata/ShowVariablesStatement.java
index be5c1f255e4..f8863fa2f12 100644
--- 
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/metadata/ShowVariablesStatement.java
+++ 
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/metadata/ShowVariablesStatement.java
@@ -20,8 +20,6 @@
 package org.apache.iotdb.db.queryengine.plan.statement.metadata;
 
 import org.apache.iotdb.common.rpc.thrift.TSStatus;
-import org.apache.iotdb.commons.auth.entity.PrivilegeType;
-import org.apache.iotdb.db.auth.AuthorityChecker;
 import org.apache.iotdb.db.queryengine.plan.analyze.QueryType;
 import org.apache.iotdb.db.queryengine.plan.statement.IConfigStatement;
 import org.apache.iotdb.db.queryengine.plan.statement.StatementVisitor;
@@ -36,12 +34,7 @@ public class ShowVariablesStatement extends ShowStatement 
implements IConfigStat
 
   @Override
   public TSStatus checkPermissionBeforeProcess(String userName) {
-    if (AuthorityChecker.SUPER_USER.equals(userName)) {
-      return new TSStatus(TSStatusCode.SUCCESS_STATUS.getStatusCode());
-    }
-    return AuthorityChecker.getTSStatus(
-        AuthorityChecker.checkSystemPermission(userName, 
PrivilegeType.MAINTAIN.ordinal()),
-        PrivilegeType.MAINTAIN);
+    return new TSStatus(TSStatusCode.SUCCESS_STATUS.getStatusCode());
   }
 
   @Override