This is an automated email from the ASF dual-hosted git repository.

tanxinyu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iotdb.git


The following commit(s) were added to refs/heads/master by this push:
     new 95384d4a9eb Randomly choosing coordinator of add region (#12416)
95384d4a9eb is described below

commit 95384d4a9eb7ebc941f947afb7d415bf5e10548d
Author: Li Yu Heng <[email protected]>
AuthorDate: Thu Apr 25 20:01:30 2024 +0800

    Randomly choosing coordinator of add region (#12416)
    
    * partition cache
    
    * randomly choose coordinator
---
 .../java/org/apache/iotdb/confignode/manager/ProcedureManager.java     | 1 +
 .../apache/iotdb/confignode/procedure/env/RegionMaintainHandler.java   | 3 +--
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java
 
b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java
index 4dc7b46b6fa..ed4bf94df68 100644
--- 
a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java
+++ 
b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java
@@ -654,6 +654,7 @@ public class ProcedureManager {
             .getLocation();
     // select coordinator for adding peer
     RegionMaintainHandler handler = new RegionMaintainHandler(configManager);
+    // TODO: choose the DataNode which has lowest load
     final TDataNodeLocation coordinatorForAddPeer =
         handler
             .filterDataNodeWithOtherRegionReplica(
diff --git 
a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/env/RegionMaintainHandler.java
 
b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/env/RegionMaintainHandler.java
index caf6482a090..e946c4dbc78 100644
--- 
a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/env/RegionMaintainHandler.java
+++ 
b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/env/RegionMaintainHandler.java
@@ -739,8 +739,7 @@ public class RegionMaintainHandler {
         
configManager.getNodeManager().filterDataNodeThroughStatus(allowingStatus).stream()
             .map(TDataNodeConfiguration::getLocation)
             .collect(Collectors.toList());
-
-    // TODO return the node which has lowest load.
+    Collections.shuffle(aliveDataNodes);
     for (TDataNodeLocation aliveDataNode : aliveDataNodes) {
       if (regionLocations.contains(aliveDataNode) && 
!aliveDataNode.equals(filterLocation)) {
         return Optional.of(aliveDataNode);

Reply via email to