This is an automated email from the ASF dual-hosted git repository.
haonan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iotdb.git
The following commit(s) were added to refs/heads/master by this push:
new 7b993f4b82c Optimize the log printing when multiple error occur
(#12732)
7b993f4b82c is described below
commit 7b993f4b82cac4cfc090226cce0ccf8db0111e6c
Author: Haonan <[email protected]>
AuthorDate: Thu Jun 13 18:03:40 2024 +0800
Optimize the log printing when multiple error occur (#12732)
---
.../src/main/java/org/apache/iotdb/rpc/RpcUtils.java | 20 +++++++++++---------
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git
a/iotdb-client/service-rpc/src/main/java/org/apache/iotdb/rpc/RpcUtils.java
b/iotdb-client/service-rpc/src/main/java/org/apache/iotdb/rpc/RpcUtils.java
index 9b29f052f28..e48054abb19 100644
--- a/iotdb-client/service-rpc/src/main/java/org/apache/iotdb/rpc/RpcUtils.java
+++ b/iotdb-client/service-rpc/src/main/java/org/apache/iotdb/rpc/RpcUtils.java
@@ -146,18 +146,20 @@ public class RpcUtils {
public static TSStatus getStatus(List<TSStatus> statusList) {
TSStatus status = new
TSStatus(TSStatusCode.MULTIPLE_ERROR.getStatusCode());
status.setSubStatus(statusList);
- StringBuilder errMsg = new StringBuilder().append("Multiple error occur,
messages: ");
- Set<String> msgSet = new HashSet<>();
- for (TSStatus subStatus : statusList) {
- if (subStatus.getCode() != TSStatusCode.SUCCESS_STATUS.getStatusCode()
- && subStatus.getCode() !=
TSStatusCode.REDIRECTION_RECOMMEND.getStatusCode()) {
- if (!msgSet.contains(status.getMessage())) {
- errMsg.append(status.getMessage()).append("; ");
- msgSet.add(status.getMessage());
+ if (LOGGER.isDebugEnabled()) {
+ StringBuilder errMsg = new StringBuilder().append("Multiple error occur,
messages: ");
+ Set<TSStatus> msgSet = new HashSet<>();
+ for (TSStatus subStatus : statusList) {
+ if (subStatus.getCode() != TSStatusCode.SUCCESS_STATUS.getStatusCode()
+ && subStatus.getCode() !=
TSStatusCode.REDIRECTION_RECOMMEND.getStatusCode()) {
+ if (!msgSet.contains(status)) {
+ errMsg.append(status).append("; ");
+ msgSet.add(status);
+ }
}
}
+ LOGGER.debug(errMsg.toString(), new Exception(errMsg.toString()));
}
- LOGGER.warn(errMsg.toString());
return status;
}