This is an automated email from the ASF dual-hosted git repository. jackietien pushed a commit to branch ty/TableModelGrammar in repository https://gitbox.apache.org/repos/asf/iotdb.git
commit cd8fde7d56d3cd2cea32424783d27d55893bfaaa Author: Li Yu Heng <[email protected]> AuthorDate: Tue Jul 23 15:55:31 2024 +0800 Change some error log to warn during region migration (#12992) * error -> warn * warn -> info * check file exist before delete * done (cherry picked from commit 3f112b9ad961052a185dcb0c73b70eef8f8b8afe) --- .../org/apache/iotdb/consensus/iot/logdispatcher/LogDispatcher.java | 2 +- .../iotdb/db/storageengine/dataregion/snapshot/SnapshotTaker.java | 5 ++++- .../iotdb/db/storageengine/dataregion/wal/buffer/WALBuffer.java | 5 +++-- 3 files changed, 8 insertions(+), 4 deletions(-) diff --git a/iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/logdispatcher/LogDispatcher.java b/iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/logdispatcher/LogDispatcher.java index f5de226cc41..9ffb29e77f3 100644 --- a/iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/logdispatcher/LogDispatcher.java +++ b/iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/logdispatcher/LogDispatcher.java @@ -303,7 +303,7 @@ public class LogDispatcher { stopped = true; try { if (!threadSemaphore.tryAcquire(30, TimeUnit.SECONDS)) { - logger.error("{}: Dispatcher for {} didn't stop after 30s.", impl.getThisNode(), peer); + logger.info("{}: Dispatcher for {} didn't stop after 30s.", impl.getThisNode(), peer); } } catch (InterruptedException e) { Thread.currentThread().interrupt(); diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/snapshot/SnapshotTaker.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/snapshot/SnapshotTaker.java index 5712e989a77..7f046940afe 100644 --- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/snapshot/SnapshotTaker.java +++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/snapshot/SnapshotTaker.java @@ -147,7 +147,10 @@ public class SnapshotTaker { pathBuilder.append(File.separator).append(dataRegion.getDatabaseName()); pathBuilder.append(IoTDBConstant.FILE_NAME_SEPARATOR).append(dataRegion.getDataRegionId()); try { - FileUtils.recursivelyDeleteFolder(pathBuilder.toString()); + String path = pathBuilder.toString(); + if (new File(path).exists()) { + FileUtils.recursivelyDeleteFolder(path); + } } catch (IOException e) { allSuccess = false; LOGGER.warn( diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/buffer/WALBuffer.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/buffer/WALBuffer.java index b8d77d7ea6d..c5aa013d8a4 100644 --- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/buffer/WALBuffer.java +++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/buffer/WALBuffer.java @@ -197,8 +197,9 @@ public class WALBuffer extends AbstractWALBuffer { @Override public void write(WALEntry walEntry) { if (isClosed) { - logger.error( - "Fail to write WALEntry into wal node-{} because this node is closed.", identifier); + logger.warn( + "Fail to write WALEntry into wal node-{} because this node is closed. It's ok to see this log during data region deletion.", + identifier); walEntry.getWalFlushListener().fail(new WALNodeClosedException(identifier)); return; }
