This is an automated email from the ASF dual-hosted git repository.

rong pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iotdb.git


The following commit(s) were added to refs/heads/master by this push:
     new 9466829bb16 Pipe: Reduce the amount of log information printed after a 
batch fails (#14172)
9466829bb16 is described below

commit 9466829bb1603f2ef78cbd27719237f9b408d1b3
Author: Zhenyu Luo <[email protected]>
AuthorDate: Fri Nov 22 15:40:35 2024 +0800

    Pipe: Reduce the amount of log information printed after a batch fails 
(#14172)
    
    Co-authored-by: Steve Yurong Su <[email protected]>
---
 .../handler/PipeConsensusTabletBatchEventHandler.java          | 10 +++++-----
 .../async/handler/PipeTransferTabletBatchEventHandler.java     |  6 +++---
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git 
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/pipeconsensus/handler/PipeConsensusTabletBatchEventHandler.java
 
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/pipeconsensus/handler/PipeConsensusTabletBatchEventHandler.java
index 5c92e928630..a2c6406b4a1 100644
--- 
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/pipeconsensus/handler/PipeConsensusTabletBatchEventHandler.java
+++ 
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/pipeconsensus/handler/PipeConsensusTabletBatchEventHandler.java
@@ -117,15 +117,15 @@ public class PipeConsensusTabletBatchEventHandler
   @Override
   public void onError(final Exception exception) {
     LOGGER.warn(
-        "PipeConsensus: Failed to transfer TabletInsertionEvent batch {} 
(request commit ids={}).",
+        "PipeConsensus: Failed to transfer TabletInsertionEvent batch. Total 
failed events: {}, related pipe names: {}",
+        events.size(),
         events.stream()
             .map(
                 event ->
                     event instanceof EnrichedEvent
-                        ? ((EnrichedEvent) event).coreReportMessage()
-                        : event.toString())
-            .collect(Collectors.toList()),
-        requestCommitIds,
+                        ? ((EnrichedEvent) event).getPipeName()
+                        : "UNKNOWN")
+            .collect(Collectors.toSet()),
         exception);
 
     connector.addFailureEventsToRetryQueue(events);
diff --git 
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/thrift/async/handler/PipeTransferTabletBatchEventHandler.java
 
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/thrift/async/handler/PipeTransferTabletBatchEventHandler.java
index fb879c7b1dc..6ef424565e8 100644
--- 
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/thrift/async/handler/PipeTransferTabletBatchEventHandler.java
+++ 
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/thrift/async/handler/PipeTransferTabletBatchEventHandler.java
@@ -121,9 +121,9 @@ public class PipeTransferTabletBatchEventHandler implements 
AsyncMethodCallback<
   public void onError(final Exception exception) {
     try {
       LOGGER.warn(
-          "Failed to transfer TabletInsertionEvent batch {} (request commit 
ids={}).",
-          
events.stream().map(EnrichedEvent::coreReportMessage).collect(Collectors.toList()),
-          
events.stream().map(EnrichedEvent::getCommitId).collect(Collectors.toList()),
+          "Failed to transfer TabletInsertionEvent batch. Total failed events: 
{}, related pipe names: {}",
+          events.size(),
+          
events.stream().map(EnrichedEvent::getPipeName).collect(Collectors.toSet()),
           exception);
     } finally {
       connector.addFailureEventsToRetryQueue(events);

Reply via email to