This is an automated email from the ASF dual-hosted git repository.
jackietien pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iotdb.git
The following commit(s) were added to refs/heads/master by this push:
new 4f4dd798295 Optimized the config execution & query failure logs
4f4dd798295 is described below
commit 4f4dd798295bb5c82f01157abd6b675dcd96c374
Author: Caideyipi <[email protected]>
AuthorDate: Wed Dec 4 17:08:53 2024 +0800
Optimized the config execution & query failure logs
---
.../write/template/CreateSchemaTemplatePlan.java | 14 +-
.../persistence/schema/ClusterSchemaInfo.java | 4 +-
.../persistence/schema/TemplateTable.java | 4 +-
.../plan/execution/config/ConfigExecution.java | 53 ++-
.../config/executor/ClusterConfigTaskExecutor.java | 491 ++++++++-------------
.../apache/iotdb/db/utils/ErrorHandlingUtils.java | 2 +-
6 files changed, 250 insertions(+), 318 deletions(-)
diff --git
a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/consensus/request/write/template/CreateSchemaTemplatePlan.java
b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/consensus/request/write/template/CreateSchemaTemplatePlan.java
index d2fa61852cf..bd8b5a7400f 100644
---
a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/consensus/request/write/template/CreateSchemaTemplatePlan.java
+++
b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/consensus/request/write/template/CreateSchemaTemplatePlan.java
@@ -38,7 +38,7 @@ public class CreateSchemaTemplatePlan extends
ConfigPhysicalPlan {
super(ConfigPhysicalPlanType.CreateSchemaTemplate);
}
- public CreateSchemaTemplatePlan(byte[] templateData) {
+ public CreateSchemaTemplatePlan(final byte[] templateData) {
this();
this.templateData = templateData;
}
@@ -48,33 +48,33 @@ public class CreateSchemaTemplatePlan extends
ConfigPhysicalPlan {
}
public Template getTemplate() {
- Template template = new Template();
+ final Template template = new Template();
template.deserialize(ByteBuffer.wrap(templateData));
return template;
}
@Override
- protected void serializeImpl(DataOutputStream stream) throws IOException {
+ protected void serializeImpl(final DataOutputStream stream) throws
IOException {
stream.writeShort(getType().getPlanType());
stream.writeInt(templateData.length);
stream.write(templateData);
}
@Override
- protected void deserializeImpl(ByteBuffer buffer) throws IOException {
- int length = ReadWriteIOUtils.readInt(buffer);
+ protected void deserializeImpl(final ByteBuffer buffer) throws IOException {
+ final int length = ReadWriteIOUtils.readInt(buffer);
this.templateData = ReadWriteIOUtils.readBytes(buffer, length);
}
@Override
- public boolean equals(Object o) {
+ public boolean equals(final Object o) {
if (this == o) {
return true;
}
if (o == null || getClass() != o.getClass()) {
return false;
}
- CreateSchemaTemplatePlan that = (CreateSchemaTemplatePlan) o;
+ final CreateSchemaTemplatePlan that = (CreateSchemaTemplatePlan) o;
return Arrays.equals(that.templateData, templateData);
}
diff --git
a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/ClusterSchemaInfo.java
b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/ClusterSchemaInfo.java
index 9bc8035eb79..2f6c93977ff 100644
---
a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/ClusterSchemaInfo.java
+++
b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/ClusterSchemaInfo.java
@@ -734,9 +734,9 @@ public class ClusterSchemaInfo implements SnapshotProcessor
{
return matchedPathsInNextLevel;
}
- public TSStatus createSchemaTemplate(CreateSchemaTemplatePlan
createSchemaTemplatePlan) {
+ public TSStatus createSchemaTemplate(final CreateSchemaTemplatePlan
createSchemaTemplatePlan) {
try {
- Template template = createSchemaTemplatePlan.getTemplate();
+ final Template template = createSchemaTemplatePlan.getTemplate();
templateTable.createTemplate(template);
return new TSStatus(TSStatusCode.SUCCESS_STATUS.getStatusCode());
} catch (MetadataException e) {
diff --git
a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/TemplateTable.java
b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/TemplateTable.java
index 201e6eb4d2e..7557eacb6e5 100644
---
a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/TemplateTable.java
+++
b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/schema/TemplateTable.java
@@ -107,10 +107,10 @@ public class TemplateTable {
}
}
- public void createTemplate(Template template) throws MetadataException {
+ public void createTemplate(final Template template) throws MetadataException
{
templateReadWriteLock.writeLock().lock();
try {
- Template temp = this.templateMap.get(template.getName());
+ final Template temp = this.templateMap.get(template.getName());
if (temp != null) {
LOGGER.error(
"Failed to create template, because template name {} exists",
template.getName());
diff --git
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/config/ConfigExecution.java
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/config/ConfigExecution.java
index 6075c8c64ba..a698563c214 100644
---
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/config/ConfigExecution.java
+++
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/config/ConfigExecution.java
@@ -47,7 +47,12 @@ import javax.validation.constraints.NotNull;
import java.io.IOException;
import java.nio.ByteBuffer;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.Objects;
import java.util.Optional;
+import java.util.Set;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.ExecutorService;
@@ -56,6 +61,38 @@ public class ConfigExecution implements IQueryExecution {
private static final Logger LOGGER =
LoggerFactory.getLogger(ConfigExecution.class);
private static final TsBlockSerde serde = new TsBlockSerde();
+ private static final Set<Integer> userExceptionCodes =
+ Collections.unmodifiableSet(
+ new HashSet<>(
+ Arrays.asList(
+ TSStatusCode.DATABASE_NOT_EXIST.getStatusCode(),
+ TSStatusCode.DATABASE_ALREADY_EXISTS.getStatusCode(),
+ TSStatusCode.DATABASE_CONFLICT.getStatusCode(),
+ TSStatusCode.DATABASE_CONFIG_ERROR.getStatusCode(),
+ TSStatusCode.PATH_NOT_EXIST.getStatusCode(),
+
TSStatusCode.MEASUREMENT_ALREADY_EXISTS_IN_TEMPLATE.getStatusCode(),
+ TSStatusCode.SCHEMA_QUOTA_EXCEEDED.getStatusCode(),
+ TSStatusCode.TABLE_ALREADY_EXISTS.getStatusCode(),
+ TSStatusCode.TABLE_NOT_EXISTS.getStatusCode(),
+ TSStatusCode.COLUMN_ALREADY_EXISTS.getStatusCode(),
+ TSStatusCode.COLUMN_NOT_EXISTS.getStatusCode(),
+ TSStatusCode.COLUMN_CATEGORY_MISMATCH.getStatusCode(),
+ TSStatusCode.DATABASE_MODEL.getStatusCode(),
+ TSStatusCode.DATABASE_CONFLICT.getStatusCode(),
+ TSStatusCode.TEMPLATE_IS_IN_USE.getStatusCode(),
+ TSStatusCode.TEMPLATE_NOT_SET.getStatusCode(),
+ TSStatusCode.TEMPLATE_INCOMPATIBLE.getStatusCode(),
+ TSStatusCode.UNDEFINED_TEMPLATE.getStatusCode(),
+ TSStatusCode.TEMPLATE_NOT_ACTIVATED.getStatusCode(),
+ TSStatusCode.USER_ALREADY_EXIST.getStatusCode(),
+ TSStatusCode.USER_NOT_EXIST.getStatusCode(),
+ TSStatusCode.NO_PERMISSION.getStatusCode(),
+ TSStatusCode.NOT_HAS_PRIVILEGE.getStatusCode(),
+ TSStatusCode.ROLE_ALREADY_EXIST.getStatusCode(),
+ TSStatusCode.ROLE_NOT_EXIST.getStatusCode(),
+ TSStatusCode.USER_ALREADY_HAS_ROLE.getStatusCode(),
+ TSStatusCode.USER_NOT_HAS_ROLE.getStatusCode(),
+ TSStatusCode.NOT_HAS_PRIVILEGE_GRANTOPT.getStatusCode())));
private final MPPQueryContext context;
private final ExecutorService executor;
@@ -118,8 +155,20 @@ public class ConfigExecution implements IQueryExecution {
}
}
- private void fail(Throwable cause) {
- LOGGER.warn("Failures happened during running ConfigExecution.", cause);
+ private void fail(final Throwable cause) {
+ if (!(cause instanceof IoTDBException)
+ || !userExceptionCodes.contains(((IoTDBException)
cause).getErrorCode())) {
+ LOGGER.warn(
+ "Failures happened during running ConfigExecution when executing
{}.",
+ Objects.nonNull(task) ? task.getClass().getSimpleName() : null,
+ cause);
+ } else {
+ LOGGER.info(
+ "Failures happened during running ConfigExecution when executing {},
message: {}, status: {}",
+ Objects.nonNull(task) ? task.getClass().getSimpleName() : null,
+ cause.getMessage(),
+ ((IoTDBException) cause).getErrorCode());
+ }
stateMachine.transitionToFailed(cause);
ConfigTaskResult result;
if (cause instanceof IoTDBException) {
diff --git
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/config/executor/ClusterConfigTaskExecutor.java
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/config/executor/ClusterConfigTaskExecutor.java
index bf841a0c3ae..4073c1b1b84 100644
---
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/config/executor/ClusterConfigTaskExecutor.java
+++
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/execution/config/executor/ClusterConfigTaskExecutor.java
@@ -1300,7 +1300,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
}
@Override
- public SettableFuture<ConfigTaskResult> killQuery(KillQueryStatement
killQueryStatement) {
+ public SettableFuture<ConfigTaskResult> killQuery(final KillQueryStatement
killQueryStatement) {
int dataNodeId = -1;
String queryId = killQueryStatement.getQueryId();
if (!killQueryStatement.isKillAll()) {
@@ -1320,12 +1320,11 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
final TSStatus executionStatus = client.killQuery(queryId, dataNodeId);
if (TSStatusCode.SUCCESS_STATUS.getStatusCode() !=
executionStatus.getCode()) {
- LOGGER.warn("Failed to kill query [{}], because {}", queryId,
executionStatus.message);
future.setException(new IoTDBException(executionStatus.message,
executionStatus.code));
} else {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
}
- } catch (ClientManagerException | TException e) {
+ } catch (final ClientManagerException | TException e) {
future.setException(e);
}
return future;
@@ -1359,9 +1358,9 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
@Override
public SettableFuture<ConfigTaskResult> showClusterParameters() {
- SettableFuture<ConfigTaskResult> future = SettableFuture.create();
+ final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
TShowVariablesResp showVariablesResp = new TShowVariablesResp();
- try (ConfigNodeClient client =
+ try (final ConfigNodeClient client =
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
showVariablesResp = client.showVariables();
} catch (ClientManagerException | TException e) {
@@ -1376,7 +1375,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
@Override
public SettableFuture<ConfigTaskResult> showClusterId() {
- SettableFuture<ConfigTaskResult> future = SettableFuture.create();
+ final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
ShowClusterIdTask.buildTSBlock(
IoTDBDescriptor.getInstance().getConfig().getClusterId(), future);
return future;
@@ -1384,35 +1383,36 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
@Override
public SettableFuture<ConfigTaskResult> showVersion() {
- SettableFuture<ConfigTaskResult> future = SettableFuture.create();
+ final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
ShowVersionTask.buildTsBlock(future);
return future;
}
@Override
- public SettableFuture<ConfigTaskResult> showCurrentSqlDialect(String
sqlDialect) {
- SettableFuture<ConfigTaskResult> future = SettableFuture.create();
+ public SettableFuture<ConfigTaskResult> showCurrentSqlDialect(final String
sqlDialect) {
+ final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
ShowCurrentSqlDialectTask.buildTsBlock(sqlDialect, future);
return future;
}
@Override
- public SettableFuture<ConfigTaskResult> showCurrentDatabase(@Nullable String
currentDatabase) {
+ public SettableFuture<ConfigTaskResult> showCurrentDatabase(
+ @Nullable final String currentDatabase) {
SettableFuture<ConfigTaskResult> future = SettableFuture.create();
ShowCurrentDatabaseTask.buildTsBlock(currentDatabase, future);
return future;
}
@Override
- public SettableFuture<ConfigTaskResult> showCurrentUser(String currentUser) {
- SettableFuture<ConfigTaskResult> future = SettableFuture.create();
+ public SettableFuture<ConfigTaskResult> showCurrentUser(final String
currentUser) {
+ final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
ShowCurrentUserTask.buildTsBlock(currentUser, future);
return future;
}
@Override
public SettableFuture<ConfigTaskResult> showCurrentTimestamp() {
- SettableFuture<ConfigTaskResult> future = SettableFuture.create();
+ final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
ShowCurrentTimestampTask.buildTsBlock(future);
return future;
}
@@ -1545,7 +1545,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
@Override
public SettableFuture<ConfigTaskResult> showAINodes() {
- SettableFuture<ConfigTaskResult> future = SettableFuture.create();
+ final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
TShowAINodesResp resp = new TShowAINodesResp();
try (ConfigNodeClient client =
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
@@ -1554,7 +1554,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
future.setException(new IoTDBException(resp.getStatus().message,
resp.getStatus().code));
return future;
}
- } catch (ClientManagerException | TException e) {
+ } catch (final ClientManagerException | TException e) {
future.setException(e);
}
ShowAINodesTask.buildTsBlock(resp, future);
@@ -1572,10 +1572,6 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
ClusterTemplateManager.getInstance().createSchemaTemplate(createSchemaTemplateStatement);
// Get response or throw exception
if (TSStatusCode.SUCCESS_STATUS.getStatusCode() != tsStatus.getCode()) {
- LOGGER.warn(
- "Failed to execute create device template {} in config node,
status is {}.",
- createSchemaTemplateStatement.getName(),
- tsStatus);
future.setException(new IoTDBException(tsStatus.getMessage(),
tsStatus.getCode()));
} else {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
@@ -1685,11 +1681,6 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
} while (TSStatusCode.OVERLAP_WITH_EXISTING_TASK.getStatusCode() ==
tsStatus.getCode());
if (TSStatusCode.SUCCESS_STATUS.getStatusCode() != tsStatus.getCode()) {
- LOGGER.warn(
- "Failed to execute deactivate device template {} from {} in config
node, status is {}.",
- deactivateTemplateStatement.getTemplateName(),
- deactivateTemplateStatement.getPathPatternList(),
- tsStatus);
future.setException(new IoTDBException(tsStatus.getMessage(),
tsStatus.getCode()));
} else {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
@@ -1711,10 +1702,6 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
configNodeClient.dropSchemaTemplate(dropSchemaTemplateStatement.getTemplateName());
// Get response or throw exception
if (TSStatusCode.SUCCESS_STATUS.getStatusCode() != tsStatus.getCode()) {
- LOGGER.warn(
- "Failed to execute drop device template {} in config node, status
is {}.",
- dropSchemaTemplateStatement.getTemplateName(),
- tsStatus);
future.setException(new IoTDBException(tsStatus.message,
tsStatus.code));
} else {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
@@ -1786,10 +1773,6 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
} while (TSStatusCode.OVERLAP_WITH_EXISTING_TASK.getStatusCode() ==
tsStatus.getCode());
if (TSStatusCode.SUCCESS_STATUS.getStatusCode() != tsStatus.getCode()) {
- LOGGER.warn(
- "Failed to alter device template {} in config node, status is {}.",
-
alterSchemaTemplateStatement.getTemplateAlterInfo().getTemplateName(),
- tsStatus);
future.setException(new IoTDBException(tsStatus.getMessage(),
tsStatus.getCode()));
} else {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
@@ -1841,11 +1824,6 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
} while (TSStatusCode.OVERLAP_WITH_EXISTING_TASK.getStatusCode() ==
tsStatus.getCode());
if (TSStatusCode.SUCCESS_STATUS.getStatusCode() != tsStatus.getCode()) {
- LOGGER.warn(
- "Failed to execute unset device template {} from {} in config
node, status is {}.",
- unsetSchemaTemplateStatement.getTemplateName(),
- unsetSchemaTemplateStatement.getPath(),
- tsStatus);
future.setException(new IoTDBException(tsStatus.getMessage(),
tsStatus.getCode()));
} else {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
@@ -1857,30 +1835,29 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
}
@Override
- public SettableFuture<ConfigTaskResult> createPipe(CreatePipeStatement
createPipeStatement) {
- SettableFuture<ConfigTaskResult> future = SettableFuture.create();
+ public SettableFuture<ConfigTaskResult> createPipe(
+ final CreatePipeStatement createPipeStatement) {
+ final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
// Verify that Pipe is disabled if TSFile encryption is enabled
if (TSFileDescriptor.getInstance().getConfig().getEncryptFlag()) {
- String exceptionMessage =
- String.format(
- "Failed to create Pipe %s because TSFile is configured with
encryption, which prohibits the use of Pipe",
- createPipeStatement.getPipeName());
- LOGGER.warn(exceptionMessage);
future.setException(
- new IoTDBException(exceptionMessage,
TSStatusCode.PIPE_ERROR.getStatusCode()));
+ new IoTDBException(
+ String.format(
+ "Failed to create Pipe %s because TSFile is configured with
encryption, which prohibits the use of Pipe",
+ createPipeStatement.getPipeName()),
+ TSStatusCode.PIPE_ERROR.getStatusCode()));
return future;
}
// Validate pipe name
if
(createPipeStatement.getPipeName().startsWith(PipeStaticMeta.SYSTEM_PIPE_PREFIX))
{
- String exceptionMessage =
- String.format(
- "Failed to create pipe %s, pipe name starting with \"%s\" are
not allowed to be created.",
- createPipeStatement.getPipeName(),
PipeStaticMeta.SYSTEM_PIPE_PREFIX);
- LOGGER.warn(exceptionMessage);
future.setException(
- new IoTDBException(exceptionMessage,
TSStatusCode.PIPE_ERROR.getStatusCode()));
+ new IoTDBException(
+ String.format(
+ "Failed to create pipe %s, pipe name starting with \"%s\"
are not allowed to be created.",
+ createPipeStatement.getPipeName(),
PipeStaticMeta.SYSTEM_PIPE_PREFIX),
+ TSStatusCode.PIPE_ERROR.getStatusCode()));
return future;
}
@@ -1893,27 +1870,22 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
createPipeStatement.getProcessorAttributes(),
createPipeStatement.getConnectorAttributes());
} catch (final Exception e) {
- LOGGER.info("Failed to validate create pipe statement, because {}",
e.getMessage(), e);
future.setException(
new IoTDBException(e.getMessage(),
TSStatusCode.PIPE_ERROR.getStatusCode()));
return future;
}
- try (ConfigNodeClient configNodeClient =
+ try (final ConfigNodeClient configNodeClient =
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
- TCreatePipeReq req =
+ final TCreatePipeReq req =
new TCreatePipeReq()
.setPipeName(createPipeStatement.getPipeName())
.setIfNotExistsCondition(createPipeStatement.hasIfNotExistsCondition())
.setExtractorAttributes(createPipeStatement.getExtractorAttributes())
.setProcessorAttributes(createPipeStatement.getProcessorAttributes())
.setConnectorAttributes(createPipeStatement.getConnectorAttributes());
- TSStatus tsStatus = configNodeClient.createPipe(req);
+ final TSStatus tsStatus = configNodeClient.createPipe(req);
if (TSStatusCode.SUCCESS_STATUS.getStatusCode() != tsStatus.getCode()) {
- LOGGER.warn(
- "Failed to create pipe {} in config node, status is {}.",
- createPipeStatement.getPipeName(),
- tsStatus);
future.setException(new IoTDBException(tsStatus.message,
tsStatus.code));
} else {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
@@ -1925,18 +1897,17 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
}
@Override
- public SettableFuture<ConfigTaskResult> alterPipe(AlterPipeStatement
alterPipeStatement) {
+ public SettableFuture<ConfigTaskResult> alterPipe(final AlterPipeStatement
alterPipeStatement) {
final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
// Validate pipe name
if
(alterPipeStatement.getPipeName().startsWith(PipeStaticMeta.SYSTEM_PIPE_PREFIX))
{
- String exceptionMessage =
- String.format(
- "Failed to alter pipe %s, pipe name starting with \"%s\" are not
allowed to be altered.",
- alterPipeStatement.getPipeName(),
PipeStaticMeta.SYSTEM_PIPE_PREFIX);
- LOGGER.warn(exceptionMessage);
future.setException(
- new IoTDBException(exceptionMessage,
TSStatusCode.PIPE_ERROR.getStatusCode()));
+ new IoTDBException(
+ String.format(
+ "Failed to alter pipe %s, pipe name starting with \"%s\" are
not allowed to be altered.",
+ alterPipeStatement.getPipeName(),
PipeStaticMeta.SYSTEM_PIPE_PREFIX),
+ TSStatusCode.PIPE_ERROR.getStatusCode()));
return future;
}
@@ -1946,13 +1917,12 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
ConfigNodeClientManager.getInstance().borrowClient(ConfigNodeInfo.CONFIG_REGION_ID))
{
final TGetAllPipeInfoResp getAllPipeInfoResp =
configNodeClient.getAllPipeInfo();
if (getAllPipeInfoResp.getStatus().getCode() !=
TSStatusCode.SUCCESS_STATUS.getStatusCode()) {
- String exceptionMessage =
- String.format(
- "Failed to get pipe info from config node, status is %s.",
- getAllPipeInfoResp.getStatus());
- LOGGER.warn(exceptionMessage);
future.setException(
- new IoTDBException(exceptionMessage,
TSStatusCode.PIPE_ERROR.getStatusCode()));
+ new IoTDBException(
+ String.format(
+ "Failed to get pipe info from config node, status is %s.",
+ getAllPipeInfoResp.getStatus()),
+ TSStatusCode.PIPE_ERROR.getStatusCode()));
return future;
}
@@ -1968,23 +1938,21 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
.findFirst()
.orElse(null);
if (pipeMetaFromCoordinator == null) {
- final String exceptionMessage =
- String.format(
- "Failed to alter pipe %s, pipe not found in system.",
- alterPipeStatement.getPipeName());
- LOGGER.warn(exceptionMessage);
future.setException(
- new IoTDBException(exceptionMessage,
TSStatusCode.PIPE_ERROR.getStatusCode()));
+ new IoTDBException(
+ String.format(
+ "Failed to alter pipe %s, pipe not found in system.",
+ alterPipeStatement.getPipeName()),
+ TSStatusCode.PIPE_ERROR.getStatusCode()));
return future;
}
} catch (final Exception e) {
- final String exceptionMessage =
- String.format(
- "Failed to alter pipe %s, because %s",
- alterPipeStatement.getPipeName(), e.getMessage());
- LOGGER.warn(exceptionMessage, e);
future.setException(
- new IoTDBException(exceptionMessage,
TSStatusCode.PIPE_ERROR.getStatusCode()));
+ new IoTDBException(
+ String.format(
+ "Failed to alter pipe %s, because %s",
+ alterPipeStatement.getPipeName(), e.getMessage()),
+ TSStatusCode.PIPE_ERROR.getStatusCode()));
return future;
}
@@ -2038,7 +2006,6 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
}
}
} catch (final Exception e) {
- LOGGER.info("Failed to validate alter pipe statement, because {}",
e.getMessage(), e);
future.setException(
new IoTDBException(e.getMessage(),
TSStatusCode.PIPE_ERROR.getStatusCode()));
return future;
@@ -2058,62 +2025,57 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
req.setIfExistsCondition(alterPipeStatement.hasIfExistsCondition());
final TSStatus tsStatus = configNodeClient.alterPipe(req);
if (TSStatusCode.SUCCESS_STATUS.getStatusCode() != tsStatus.getCode()) {
- LOGGER.warn("Failed to alter pipe {} in config node, status is {}.",
pipeName, tsStatus);
future.setException(new IoTDBException(tsStatus.message,
tsStatus.code));
} else {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
}
- } catch (Exception e) {
+ } catch (final Exception e) {
future.setException(e);
}
return future;
}
@Override
- public SettableFuture<ConfigTaskResult> startPipe(StartPipeStatement
startPipeStatement) {
+ public SettableFuture<ConfigTaskResult> startPipe(final StartPipeStatement
startPipeStatement) {
final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
// Validate pipe name
if
(startPipeStatement.getPipeName().startsWith(PipeStaticMeta.SYSTEM_PIPE_PREFIX))
{
- String exceptionMessage =
- String.format(
- "Failed to start pipe %s, pipe name starting with \"%s\" are not
allowed to be started.",
- startPipeStatement.getPipeName(),
PipeStaticMeta.SYSTEM_PIPE_PREFIX);
- LOGGER.warn(exceptionMessage);
future.setException(
- new IoTDBException(exceptionMessage,
TSStatusCode.PIPE_ERROR.getStatusCode()));
+ new IoTDBException(
+ String.format(
+ "Failed to start pipe %s, pipe name starting with \"%s\" are
not allowed to be started.",
+ startPipeStatement.getPipeName(),
PipeStaticMeta.SYSTEM_PIPE_PREFIX),
+ TSStatusCode.PIPE_ERROR.getStatusCode()));
return future;
}
- try (ConfigNodeClient configNodeClient =
+ try (final ConfigNodeClient configNodeClient =
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
- TSStatus tsStatus =
configNodeClient.startPipe(startPipeStatement.getPipeName());
+ final TSStatus tsStatus =
configNodeClient.startPipe(startPipeStatement.getPipeName());
if (TSStatusCode.SUCCESS_STATUS.getStatusCode() != tsStatus.getCode()) {
- LOGGER.warn(
- "Failed to start pipe {}, status is {}.",
startPipeStatement.getPipeName(), tsStatus);
future.setException(new IoTDBException(tsStatus.message,
tsStatus.code));
} else {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
}
- } catch (Exception e) {
+ } catch (final Exception e) {
future.setException(e);
}
return future;
}
@Override
- public SettableFuture<ConfigTaskResult> dropPipe(DropPipeStatement
dropPipeStatement) {
+ public SettableFuture<ConfigTaskResult> dropPipe(final DropPipeStatement
dropPipeStatement) {
final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
// Validate pipe name
if
(dropPipeStatement.getPipeName().startsWith(PipeStaticMeta.SYSTEM_PIPE_PREFIX))
{
- String exceptionMessage =
- String.format(
- "Failed to drop pipe %s, pipe name starting with \"%s\" are not
allowed to be dropped.",
- dropPipeStatement.getPipeName(),
PipeStaticMeta.SYSTEM_PIPE_PREFIX);
- LOGGER.warn(exceptionMessage);
future.setException(
- new IoTDBException(exceptionMessage,
TSStatusCode.PIPE_ERROR.getStatusCode()));
+ new IoTDBException(
+ String.format(
+ "Failed to drop pipe %s, pipe name starting with \"%s\" are
not allowed to be dropped.",
+ dropPipeStatement.getPipeName(),
PipeStaticMeta.SYSTEM_PIPE_PREFIX),
+ TSStatusCode.PIPE_ERROR.getStatusCode()));
return future;
}
@@ -2125,56 +2087,51 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
.setPipeName(dropPipeStatement.getPipeName())
.setIfExistsCondition(dropPipeStatement.hasIfExistsCondition()));
if (TSStatusCode.SUCCESS_STATUS.getStatusCode() != tsStatus.getCode()) {
- LOGGER.warn(
- "Failed to drop pipe {}, status is {}.",
dropPipeStatement.getPipeName(), tsStatus);
future.setException(new IoTDBException(tsStatus.message,
tsStatus.code));
} else {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
}
- } catch (Exception e) {
+ } catch (final Exception e) {
future.setException(e);
}
return future;
}
@Override
- public SettableFuture<ConfigTaskResult> stopPipe(StopPipeStatement
stopPipeStatement) {
+ public SettableFuture<ConfigTaskResult> stopPipe(final StopPipeStatement
stopPipeStatement) {
final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
// Validate pipe name
if
(stopPipeStatement.getPipeName().startsWith(PipeStaticMeta.SYSTEM_PIPE_PREFIX))
{
- String exceptionMessage =
- String.format(
- "Failed to stop pipe %s, pipe name starting with \"%s\" are not
allowed to be stopped.",
- stopPipeStatement.getPipeName(),
PipeStaticMeta.SYSTEM_PIPE_PREFIX);
- LOGGER.warn(exceptionMessage);
future.setException(
- new IoTDBException(exceptionMessage,
TSStatusCode.PIPE_ERROR.getStatusCode()));
+ new IoTDBException(
+ String.format(
+ "Failed to stop pipe %s, pipe name starting with \"%s\" are
not allowed to be stopped.",
+ stopPipeStatement.getPipeName(),
PipeStaticMeta.SYSTEM_PIPE_PREFIX),
+ TSStatusCode.PIPE_ERROR.getStatusCode()));
return future;
}
- try (ConfigNodeClient configNodeClient =
+ try (final ConfigNodeClient configNodeClient =
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
final TSStatus tsStatus =
configNodeClient.stopPipe(stopPipeStatement.getPipeName());
if (TSStatusCode.SUCCESS_STATUS.getStatusCode() != tsStatus.getCode()) {
- LOGGER.warn(
- "Failed to stop pipe {}, status is {}.",
stopPipeStatement.getPipeName(), tsStatus);
future.setException(new IoTDBException(tsStatus.message,
tsStatus.code));
} else {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
}
- } catch (Exception e) {
+ } catch (final Exception e) {
future.setException(e);
}
return future;
}
@Override
- public SettableFuture<ConfigTaskResult> showPipes(ShowPipesStatement
showPipesStatement) {
+ public SettableFuture<ConfigTaskResult> showPipes(final ShowPipesStatement
showPipesStatement) {
final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
- try (ConfigNodeClient configNodeClient =
+ try (final ConfigNodeClient configNodeClient =
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
- TShowPipeReq tShowPipeReq = new TShowPipeReq();
+ final TShowPipeReq tShowPipeReq = new TShowPipeReq();
if (showPipesStatement.getPipeName() != null) {
tShowPipeReq.setPipeName(showPipesStatement.getPipeName());
}
@@ -2184,7 +2141,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
final List<TShowPipeInfo> tShowPipeInfoList =
configNodeClient.showPipe(tShowPipeReq).getPipeInfoList();
ShowPipeTask.buildTSBlock(tShowPipeInfoList, future);
- } catch (Exception e) {
+ } catch (final Exception e) {
future.setException(e);
}
return future;
@@ -2192,7 +2149,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
@Override
public SettableFuture<ConfigTaskResult> showSubscriptions(
- ShowSubscriptionsStatement showSubscriptionsStatement) {
+ final ShowSubscriptionsStatement showSubscriptionsStatement) {
final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
try (final ConfigNodeClient configNodeClient =
@@ -2218,14 +2175,15 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
? showSubscriptionResp.getSubscriptionInfoList()
: Collections.emptyList(),
future);
- } catch (Exception e) {
+ } catch (final Exception e) {
future.setException(e);
}
return future;
}
@Override
- public SettableFuture<ConfigTaskResult> createTopic(CreateTopicStatement
createTopicStatement) {
+ public SettableFuture<ConfigTaskResult> createTopic(
+ final CreateTopicStatement createTopicStatement) {
final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
final String topicName = createTopicStatement.getTopicName();
@@ -2261,8 +2219,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
.validateExtractor(temporaryTopicMeta.generateExtractorAttributes());
PipeDataNodeAgent.plugin()
.validateProcessor(temporaryTopicMeta.generateProcessorAttributes());
- } catch (Exception e) {
- LOGGER.info("Failed to validate create topic statement, because {}",
e.getMessage(), e);
+ } catch (final Exception e) {
future.setException(
new IoTDBException(e.getMessage(),
TSStatusCode.CREATE_TOPIC_ERROR.getStatusCode()));
return future;
@@ -2277,7 +2234,6 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
.setTopicAttributes(topicAttributes);
final TSStatus tsStatus = configNodeClient.createTopic(req);
if (TSStatusCode.SUCCESS_STATUS.getStatusCode() != tsStatus.getCode()) {
- LOGGER.warn("Failed to create topic {} in config node, status is {}.",
topicName, tsStatus);
future.setException(new IoTDBException(tsStatus.message,
tsStatus.code));
} else {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
@@ -2289,7 +2245,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
}
@Override
- public SettableFuture<ConfigTaskResult> dropTopic(DropTopicStatement
dropTopicStatement) {
+ public SettableFuture<ConfigTaskResult> dropTopic(final DropTopicStatement
dropTopicStatement) {
final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
try (ConfigNodeClient configNodeClient =
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
@@ -2299,8 +2255,6 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
.setIfExistsCondition(dropTopicStatement.hasIfExistsCondition())
.setTopicName(dropTopicStatement.getTopicName()));
if (TSStatusCode.SUCCESS_STATUS.getStatusCode() != tsStatus.getCode()) {
- LOGGER.warn(
- "Failed to drop topic {}, status is {}.",
dropTopicStatement.getTopicName(), tsStatus);
future.setException(new IoTDBException(tsStatus.message,
tsStatus.code));
} else {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
@@ -2312,7 +2266,8 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
}
@Override
- public SettableFuture<ConfigTaskResult> showTopics(ShowTopicsStatement
showTopicsStatement) {
+ public SettableFuture<ConfigTaskResult> showTopics(
+ final ShowTopicsStatement showTopicsStatement) {
final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
try (final ConfigNodeClient configNodeClient =
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
@@ -2334,7 +2289,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
? showTopicResp.getTopicInfoList()
: Collections.emptyList(),
future);
- } catch (Exception e) {
+ } catch (final Exception e) {
future.setException(e);
}
return future;
@@ -2342,7 +2297,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
@Override
public SettableFuture<ConfigTaskResult> deleteTimeSeries(
- String queryId, DeleteTimeSeriesStatement deleteTimeSeriesStatement) {
+ final String queryId, final DeleteTimeSeriesStatement
deleteTimeSeriesStatement) {
final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
final TDeleteTimeSeriesReq req =
new TDeleteTimeSeriesReq(
@@ -2367,10 +2322,6 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
} while (TSStatusCode.OVERLAP_WITH_EXISTING_TASK.getStatusCode() ==
tsStatus.getCode());
if (TSStatusCode.SUCCESS_STATUS.getStatusCode() != tsStatus.getCode()) {
- LOGGER.warn(
- "Failed to execute delete timeseries {} in config node, status is
{}.",
- deleteTimeSeriesStatement.getPathPatternList(),
- tsStatus);
if (tsStatus.getCode() == TSStatusCode.MULTIPLE_ERROR.getStatusCode())
{
future.setException(
new BatchProcessException(tsStatus.subStatus.toArray(new
TSStatus[0])));
@@ -2380,7 +2331,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
} else {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
}
- } catch (ClientManagerException | TException e) {
+ } catch (final ClientManagerException | TException e) {
future.setException(e);
}
return future;
@@ -2388,19 +2339,19 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
@Override
public SettableFuture<ConfigTaskResult> deleteLogicalView(
- String queryId, DeleteLogicalViewStatement deleteLogicalViewStatement) {
+ final String queryId, final DeleteLogicalViewStatement
deleteLogicalViewStatement) {
final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
final TDeleteLogicalViewReq req =
new TDeleteLogicalViewReq(
queryId,
serializePatternListToByteBuffer(deleteLogicalViewStatement.getPathPatternList()));
- try (ConfigNodeClient client =
+ try (final ConfigNodeClient client =
CLUSTER_DELETION_CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID))
{
TSStatus tsStatus;
do {
try {
tsStatus = client.deleteLogicalView(req);
- } catch (TTransportException e) {
+ } catch (final TTransportException e) {
if (e.getType() == TTransportException.TIMED_OUT
|| e.getCause() instanceof SocketTimeoutException) {
// time out mainly caused by slow execution, wait until
@@ -2413,15 +2364,11 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
} while (TSStatusCode.OVERLAP_WITH_EXISTING_TASK.getStatusCode() ==
tsStatus.getCode());
if (TSStatusCode.SUCCESS_STATUS.getStatusCode() != tsStatus.getCode()) {
- LOGGER.warn(
- "Failed to execute delete view {}, status is {}.",
- deleteLogicalViewStatement.getPathPatternList(),
- tsStatus);
future.setException(new IoTDBException(tsStatus.getMessage(),
tsStatus.getCode()));
} else {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
}
- } catch (ClientManagerException | TException e) {
+ } catch (final ClientManagerException | TException e) {
future.setException(e);
}
return future;
@@ -2429,7 +2376,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
@Override
public SettableFuture<ConfigTaskResult> renameLogicalView(
- String queryId, RenameLogicalViewStatement renameLogicalViewStatement) {
+ final String queryId, final RenameLogicalViewStatement
renameLogicalViewStatement) {
final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
// check path
@@ -2488,7 +2435,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
do {
try {
tsStatus = client.deleteLogicalView(req);
- } catch (TTransportException e) {
+ } catch (final TTransportException e) {
if (e.getType() == TTransportException.TIMED_OUT
|| e.getCause() instanceof SocketTimeoutException) {
// time out mainly caused by slow execution, wait until
@@ -2501,12 +2448,11 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
} while (TSStatusCode.OVERLAP_WITH_EXISTING_TASK.getStatusCode() ==
tsStatus.getCode());
if (TSStatusCode.SUCCESS_STATUS.getStatusCode() != tsStatus.getCode()) {
- LOGGER.warn("Failed to execute delete view {}, status is {}.",
oldName, tsStatus);
future.setException(new IoTDBException(tsStatus.getMessage(),
tsStatus.getCode()));
} else {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
}
- } catch (ClientManagerException | TException e) {
+ } catch (final ClientManagerException | TException e) {
future.setException(e);
}
return future;
@@ -2514,7 +2460,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
@Override
public SettableFuture<ConfigTaskResult> alterLogicalView(
- AlterLogicalViewStatement alterLogicalViewStatement, MPPQueryContext
context) {
+ final AlterLogicalViewStatement alterLogicalViewStatement, final
MPPQueryContext context) {
final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
final CreateLogicalViewStatement createLogicalViewStatement = new
CreateLogicalViewStatement();
createLogicalViewStatement.setTargetPaths(alterLogicalViewStatement.getTargetPaths());
@@ -2535,7 +2481,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
new TransformToViewExpressionVisitor();
final List<Expression> expressionList =
alterLogicalViewStatement.getSourceExpressionList();
final List<ViewExpression> viewExpressionList = new ArrayList<>();
- for (Expression expression : expressionList) {
+ for (final Expression expression : expressionList) {
viewExpressionList.add(transformToViewExpressionVisitor.process(expression,
null));
}
@@ -2548,7 +2494,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
viewPathList.get(i).serialize(stream);
ViewExpression.serialize(viewExpressionList.get(i), stream);
}
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new RuntimeException(e);
}
@@ -2561,7 +2507,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
do {
try {
tsStatus = client.alterLogicalView(req);
- } catch (TTransportException e) {
+ } catch (final TTransportException e) {
if (e.getType() == TTransportException.TIMED_OUT
|| e.getCause() instanceof SocketTimeoutException) {
// time out mainly caused by slow execution, wait until
@@ -2574,10 +2520,6 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
} while (TSStatusCode.OVERLAP_WITH_EXISTING_TASK.getStatusCode() ==
tsStatus.getCode());
if (TSStatusCode.SUCCESS_STATUS.getStatusCode() != tsStatus.getCode()) {
- LOGGER.warn(
- "Failed to execute alter view {}, status is {}.",
- alterLogicalViewStatement.getTargetPathList(),
- tsStatus);
if (tsStatus.getCode() == TSStatusCode.MULTIPLE_ERROR.getStatusCode())
{
future.setException(
new BatchProcessException(tsStatus.subStatus.toArray(new
TSStatus[0])));
@@ -2588,25 +2530,25 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
}
return future;
- } catch (ClientManagerException | TException e) {
+ } catch (final ClientManagerException | TException e) {
future.setException(e);
return future;
}
}
@Override
- public TSStatus alterLogicalViewByPipe(AlterLogicalViewNode
alterLogicalViewNode) {
+ public TSStatus alterLogicalViewByPipe(final AlterLogicalViewNode
alterLogicalViewNode) {
final Map<PartialPath, ViewExpression> viewPathToSourceMap =
alterLogicalViewNode.getViewPathToSourceMap();
final ByteArrayOutputStream stream = new ByteArrayOutputStream();
try {
ReadWriteIOUtils.write(viewPathToSourceMap.size(), stream);
- for (Map.Entry<PartialPath, ViewExpression> entry :
viewPathToSourceMap.entrySet()) {
+ for (final Map.Entry<PartialPath, ViewExpression> entry :
viewPathToSourceMap.entrySet()) {
entry.getKey().serialize(stream);
ViewExpression.serialize(entry.getValue(), stream);
}
- } catch (IOException e) {
+ } catch (final IOException e) {
throw new RuntimeException(e);
}
@@ -2616,12 +2558,12 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
ByteBuffer.wrap(stream.toByteArray()))
.setIsGeneratedByPipe(true);
TSStatus tsStatus;
- try (ConfigNodeClient client =
+ try (final ConfigNodeClient client =
CLUSTER_DELETION_CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID))
{
do {
try {
tsStatus = client.alterLogicalView(req);
- } catch (TTransportException e) {
+ } catch (final TTransportException e) {
if (e.getType() == TTransportException.TIMED_OUT
|| e.getCause() instanceof SocketTimeoutException) {
// time out mainly caused by slow execution, wait until
@@ -2639,7 +2581,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
viewPathToSourceMap,
tsStatus);
}
- } catch (ClientManagerException | TException e) {
+ } catch (final ClientManagerException | TException e) {
tsStatus = new
TSStatus(TSStatusCode.INTERNAL_SERVER_ERROR.getStatusCode());
tsStatus.setMessage(e.toString());
}
@@ -2647,15 +2589,16 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
}
@Override
- public SettableFuture<ConfigTaskResult> getRegionId(GetRegionIdStatement
getRegionIdStatement) {
+ public SettableFuture<ConfigTaskResult> getRegionId(
+ final GetRegionIdStatement getRegionIdStatement) {
final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
TGetRegionIdResp resp = new TGetRegionIdResp();
- try (ConfigNodeClient configNodeClient =
+ try (final ConfigNodeClient configNodeClient =
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
final TGetRegionIdReq tGetRegionIdReq =
new TGetRegionIdReq(getRegionIdStatement.getPartitionType());
if (getRegionIdStatement.getDevice() != null) {
- ByteArrayOutputStream baos = new ByteArrayOutputStream();
+ final ByteArrayOutputStream baos = new ByteArrayOutputStream();
getRegionIdStatement.getDevice().serialize(baos);
tGetRegionIdReq.setDevice(baos.toByteArray());
} else {
@@ -2670,7 +2613,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
future.setException(new IoTDBException(resp.getStatus().message,
resp.getStatus().code));
return future;
}
- } catch (Exception e) {
+ } catch (final Exception e) {
future.setException(e);
}
GetRegionIdTask.buildTsBlock(resp, future);
@@ -2679,12 +2622,12 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
@Override
public SettableFuture<ConfigTaskResult> getSeriesSlotList(
- GetSeriesSlotListStatement getSeriesSlotListStatement) {
+ final GetSeriesSlotListStatement getSeriesSlotListStatement) {
final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
TGetSeriesSlotListResp resp = new TGetSeriesSlotListResp();
- try (ConfigNodeClient configNodeClient =
+ try (final ConfigNodeClient configNodeClient =
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
- TGetSeriesSlotListReq tGetSeriesSlotListReq =
+ final TGetSeriesSlotListReq tGetSeriesSlotListReq =
new TGetSeriesSlotListReq(
getSeriesSlotListStatement.getDatabase(),
getSeriesSlotListStatement.getPartitionType());
@@ -2693,7 +2636,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
future.setException(new IoTDBException(resp.getStatus().message,
resp.getStatus().code));
return future;
}
- } catch (Exception e) {
+ } catch (final Exception e) {
future.setException(e);
}
GetSeriesSlotListTask.buildTsBlock(resp, future);
@@ -2702,10 +2645,10 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
@Override
public SettableFuture<ConfigTaskResult> getTimeSlotList(
- GetTimeSlotListStatement getTimeSlotListStatement) {
+ final GetTimeSlotListStatement getTimeSlotListStatement) {
final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
TGetTimeSlotListResp resp = new TGetTimeSlotListResp();
- try (ConfigNodeClient configNodeClient =
+ try (final ConfigNodeClient configNodeClient =
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
final TGetTimeSlotListReq tGetTimeSlotListReq = new
TGetTimeSlotListReq();
if (getTimeSlotListStatement.getDatabase() != null) {
@@ -2728,7 +2671,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
future.setException(new IoTDBException(resp.getStatus().message,
resp.getStatus().code));
return future;
}
- } catch (Exception e) {
+ } catch (final Exception e) {
future.setException(e);
}
GetTimeSlotListTask.buildTSBlock(resp, future);
@@ -2737,16 +2680,16 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
@Override
public SettableFuture<ConfigTaskResult> countTimeSlotList(
- CountTimeSlotListStatement countTimeSlotListStatement) {
+ final CountTimeSlotListStatement countTimeSlotListStatement) {
final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
TCountTimeSlotListResp resp = new TCountTimeSlotListResp();
- try (ConfigNodeClient configNodeClient =
+ try (final ConfigNodeClient configNodeClient =
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
final TCountTimeSlotListReq tCountTimeSlotListReq = new
TCountTimeSlotListReq();
if (countTimeSlotListStatement.getDatabase() != null) {
tCountTimeSlotListReq.setDatabase(countTimeSlotListStatement.getDatabase());
} else if (countTimeSlotListStatement.getDevice() != null) {
- ByteArrayOutputStream baos = new ByteArrayOutputStream();
+ final ByteArrayOutputStream baos = new ByteArrayOutputStream();
countTimeSlotListStatement.getDevice().serialize(baos);
tCountTimeSlotListReq.setDevice(baos.toByteArray());
} else if (countTimeSlotListStatement.getRegionId() != -1) {
@@ -2763,7 +2706,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
future.setException(new IoTDBException(resp.getStatus().message,
resp.getStatus().code));
return future;
}
- } catch (Exception e) {
+ } catch (final Exception e) {
future.setException(e);
}
CountTimeSlotListTask.buildTSBlock(resp, future);
@@ -2772,7 +2715,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
@Override
public SettableFuture<ConfigTaskResult> migrateRegion(
- MigrateRegionStatement migrateRegionStatement) {
+ final MigrateRegionStatement migrateRegionStatement) {
final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
try (ConfigNodeClient configNodeClient =
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
@@ -2796,7 +2739,8 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
@Override
public SettableFuture<ConfigTaskResult> createContinuousQuery(
- CreateContinuousQueryStatement createContinuousQueryStatement,
MPPQueryContext context) {
+ final CreateContinuousQueryStatement createContinuousQueryStatement,
+ final MPPQueryContext context) {
createContinuousQueryStatement.semanticCheck();
final String queryBody = createContinuousQueryStatement.getQueryBody();
@@ -2804,7 +2748,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
Analyzer.analyze(createContinuousQueryStatement.getQueryBodyStatement(),
context);
final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
- try (ConfigNodeClient client =
+ try (final ConfigNodeClient client =
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
final TCreateCQReq tCreateCQReq =
new TCreateCQReq(
@@ -2820,34 +2764,28 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
context.getSession() == null ? null :
context.getSession().getUserName());
final TSStatus executionStatus = client.createCQ(tCreateCQReq);
if (TSStatusCode.SUCCESS_STATUS.getStatusCode() !=
executionStatus.getCode()) {
- LOGGER.warn(
- "[{}] Failed to create continuous query {}. TSStatus is {}",
- executionStatus,
- createContinuousQueryStatement.getCqId(),
- executionStatus.message);
future.setException(new IoTDBException(executionStatus.message,
executionStatus.code));
} else {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
}
- } catch (ClientManagerException | TException e) {
+ } catch (final ClientManagerException | TException e) {
future.setException(e);
}
return future;
}
@Override
- public SettableFuture<ConfigTaskResult> dropContinuousQuery(String cqId) {
+ public SettableFuture<ConfigTaskResult> dropContinuousQuery(final String
cqId) {
final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
- try (ConfigNodeClient client =
+ try (final ConfigNodeClient client =
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
final TSStatus executionStatus = client.dropCQ(new TDropCQReq(cqId));
if (TSStatusCode.SUCCESS_STATUS.getStatusCode() !=
executionStatus.getCode()) {
- LOGGER.warn("[{}] Failed to drop continuous query {}.",
executionStatus, cqId);
future.setException(new IoTDBException(executionStatus.message,
executionStatus.code));
} else {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
}
- } catch (ClientManagerException | TException e) {
+ } catch (final ClientManagerException | TException e) {
future.setException(e);
}
return future;
@@ -2856,7 +2794,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
@Override
public SettableFuture<ConfigTaskResult> showContinuousQueries() {
final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
- try (ConfigNodeClient client =
+ try (final ConfigNodeClient client =
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
final TShowCQResp showCQResp = client.showCQ();
if (showCQResp.getStatus().getCode() !=
TSStatusCode.SUCCESS_STATUS.getStatusCode()) {
@@ -2866,7 +2804,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
}
// convert cqList and buildTsBlock
ShowContinuousQueriesTask.buildTsBlock(showCQResp.getCqList(), future);
- } catch (ClientManagerException | TException e) {
+ } catch (final ClientManagerException | TException e) {
future.setException(e);
}
@@ -2875,57 +2813,51 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
@Override
public SettableFuture<ConfigTaskResult> createModel(
- CreateModelStatement createModelStatement, MPPQueryContext context) {
- SettableFuture<ConfigTaskResult> future = SettableFuture.create();
- try (ConfigNodeClient client =
+ final CreateModelStatement createModelStatement, final MPPQueryContext
context) {
+ final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
+ try (final ConfigNodeClient client =
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
- TCreateModelReq req =
+ final TCreateModelReq req =
new TCreateModelReq(createModelStatement.getModelName(),
createModelStatement.getUri());
final TSStatus status = client.createModel(req);
if (TSStatusCode.SUCCESS_STATUS.getStatusCode() != status.getCode()) {
- LOGGER.warn(
- "[{}] Failed to create model {}. TSStatus is {}",
- status,
- createModelStatement.getModelName(),
- status.message);
future.setException(new IoTDBException(status.message, status.code));
} else {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
}
- } catch (ClientManagerException | TException e) {
+ } catch (final ClientManagerException | TException e) {
future.setException(e);
}
return future;
}
@Override
- public SettableFuture<ConfigTaskResult> dropModel(String modelName) {
- SettableFuture<ConfigTaskResult> future = SettableFuture.create();
- try (ConfigNodeClient client =
+ public SettableFuture<ConfigTaskResult> dropModel(final String modelName) {
+ final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
+ try (final ConfigNodeClient client =
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
final TSStatus executionStatus = client.dropModel(new
TDropModelReq(modelName));
if (TSStatusCode.SUCCESS_STATUS.getStatusCode() !=
executionStatus.getCode()) {
- LOGGER.warn("[{}] Failed to drop model {}.", executionStatus,
modelName);
future.setException(new IoTDBException(executionStatus.message,
executionStatus.code));
} else {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
}
- } catch (ClientManagerException | TException e) {
+ } catch (final ClientManagerException | TException e) {
future.setException(e);
}
return future;
}
@Override
- public SettableFuture<ConfigTaskResult> showModels(String modelName) {
- SettableFuture<ConfigTaskResult> future = SettableFuture.create();
- try (ConfigNodeClient client =
+ public SettableFuture<ConfigTaskResult> showModels(final String modelName) {
+ final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
+ try (final ConfigNodeClient client =
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
- TShowModelReq req = new TShowModelReq();
+ final TShowModelReq req = new TShowModelReq();
if (modelName != null) {
req.setModelId(modelName);
}
- TShowModelResp showModelResp = client.showModel(req);
+ final TShowModelResp showModelResp = client.showModel(req);
if (showModelResp.getStatus().getCode() !=
TSStatusCode.SUCCESS_STATUS.getStatusCode()) {
future.setException(
new IoTDBException(showModelResp.getStatus().message,
showModelResp.getStatus().code));
@@ -2933,7 +2865,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
}
// convert model info list and buildTsBlock
ShowModelsTask.buildTsBlock(showModelResp.getModelInfoList(), future);
- } catch (ClientManagerException | TException e) {
+ } catch (final ClientManagerException | TException e) {
future.setException(e);
}
return future;
@@ -2941,7 +2873,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
@Override
public SettableFuture<ConfigTaskResult> setSpaceQuota(
- SetSpaceQuotaStatement setSpaceQuotaStatement) {
+ final SetSpaceQuotaStatement setSpaceQuotaStatement) {
final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
TSStatus tsStatus = new TSStatus();
final TSetSpaceQuotaReq req = new TSetSpaceQuotaReq();
@@ -2951,11 +2883,11 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
spaceQuota.setTimeserieNum(setSpaceQuotaStatement.getTimeSeriesNum());
spaceQuota.setDiskSize(setSpaceQuotaStatement.getDiskSize());
req.setSpaceLimit(spaceQuota);
- try (ConfigNodeClient client =
+ try (final ConfigNodeClient client =
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
// Send request to some API server
tsStatus = client.setSpaceQuota(req);
- } catch (Exception e) {
+ } catch (final Exception e) {
future.setException(e);
}
if (tsStatus.getCode() == TSStatusCode.SUCCESS_STATUS.getStatusCode()) {
@@ -2968,10 +2900,10 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
@Override
public SettableFuture<ConfigTaskResult> showSpaceQuota(
- ShowSpaceQuotaStatement showSpaceQuotaStatement) {
+ final ShowSpaceQuotaStatement showSpaceQuotaStatement) {
final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
- try (ConfigNodeClient configNodeClient =
+ try (final ConfigNodeClient configNodeClient =
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
final List<String> databases = new ArrayList<>();
if (showSpaceQuotaStatement.getDatabases() != null) {
@@ -2983,7 +2915,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
final TSpaceQuotaResp showSpaceQuotaResp =
configNodeClient.showSpaceQuota(databases);
// build TSBlock
ShowSpaceQuotaTask.buildTsBlock(showSpaceQuotaResp, future);
- } catch (Exception e) {
+ } catch (final Exception e) {
future.setException(e);
}
return future;
@@ -2991,21 +2923,21 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
@Override
public SettableFuture<ConfigTaskResult> setThrottleQuota(
- SetThrottleQuotaStatement setThrottleQuotaStatement) {
- SettableFuture<ConfigTaskResult> future = SettableFuture.create();
+ final SetThrottleQuotaStatement setThrottleQuotaStatement) {
+ final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
TSStatus tsStatus = new TSStatus();
- TSetThrottleQuotaReq req = new TSetThrottleQuotaReq();
+ final TSetThrottleQuotaReq req = new TSetThrottleQuotaReq();
req.setUserName(setThrottleQuotaStatement.getUserName());
- TThrottleQuota throttleQuota = new TThrottleQuota();
+ final TThrottleQuota throttleQuota = new TThrottleQuota();
throttleQuota.setThrottleLimit(setThrottleQuotaStatement.getThrottleLimit());
throttleQuota.setMemLimit(setThrottleQuotaStatement.getMemLimit());
throttleQuota.setCpuLimit(setThrottleQuotaStatement.getCpuLimit());
req.setThrottleQuota(throttleQuota);
- try (ConfigNodeClient client =
+ try (final ConfigNodeClient client =
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
// Send request to some API server
tsStatus = client.setThrottleQuota(req);
- } catch (Exception e) {
+ } catch (final Exception e) {
future.setException(e);
}
if (tsStatus.getCode() == TSStatusCode.SUCCESS_STATUS.getStatusCode()) {
@@ -3018,18 +2950,18 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
@Override
public SettableFuture<ConfigTaskResult> showThrottleQuota(
- ShowThrottleQuotaStatement showThrottleQuotaStatement) {
- SettableFuture<ConfigTaskResult> future = SettableFuture.create();
+ final ShowThrottleQuotaStatement showThrottleQuotaStatement) {
+ final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
- try (ConfigNodeClient configNodeClient =
+ try (final ConfigNodeClient configNodeClient =
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
// Send request to some API server
- TShowThrottleReq req = new TShowThrottleReq();
+ final TShowThrottleReq req = new TShowThrottleReq();
req.setUserName(showThrottleQuotaStatement.getUserName());
- TThrottleQuotaResp throttleQuotaResp =
configNodeClient.showThrottleQuota(req);
+ final TThrottleQuotaResp throttleQuotaResp =
configNodeClient.showThrottleQuota(req);
// build TSBlock
ShowThrottleQuotaTask.buildTSBlock(throttleQuotaResp, future);
- } catch (Exception e) {
+ } catch (final Exception e) {
future.setException(e);
}
return future;
@@ -3042,7 +2974,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
// Send request to some API server
throttleQuotaResp = configNodeClient.getThrottleQuota();
- } catch (Exception e) {
+ } catch (final Exception e) {
LOGGER.error(e.getMessage());
}
return throttleQuotaResp;
@@ -3051,18 +2983,19 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
@Override
public TSpaceQuotaResp getSpaceQuota() {
TSpaceQuotaResp spaceQuotaResp = new TSpaceQuotaResp();
- try (ConfigNodeClient configNodeClient =
+ try (final ConfigNodeClient configNodeClient =
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
// Send request to some API server
spaceQuotaResp = configNodeClient.getSpaceQuota();
- } catch (Exception e) {
+ } catch (final Exception e) {
LOGGER.error(e.getMessage());
}
return spaceQuotaResp;
}
@Override
- public TPipeTransferResp handleTransferConfigPlan(String clientId,
TPipeTransferReq req) {
+ public TPipeTransferResp handleTransferConfigPlan(
+ final String clientId, final TPipeTransferReq req) {
final TPipeConfigTransferReq configTransferReq =
new TPipeConfigTransferReq(
req.version,
@@ -3109,10 +3042,10 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
}
@Override
- public SettableFuture<ConfigTaskResult> showCluster(ShowCluster showCluster)
{
+ public SettableFuture<ConfigTaskResult> showCluster(final ShowCluster
showCluster) {
// As the implementation is identical, we'll simply translate to the
// corresponding tree-model variant and execute that.
- ShowClusterStatement treeStatement = new ShowClusterStatement();
+ final ShowClusterStatement treeStatement = new ShowClusterStatement();
treeStatement.setDetails(showCluster.getDetails().orElse(false));
return showCluster(treeStatement);
}
@@ -3133,7 +3066,9 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
if (!resp.getDatabaseInfoMap()
.get(PathUtils.qualifyDatabaseName(useDB.getDatabaseId().getValue()))
.isIsTableModel()) {
- throw new DatabaseModelException(useDB.getDatabaseId().getValue(),
false);
+ throw new IoTDBException(
+ new DatabaseModelException(useDB.getDatabaseId().getValue(),
false).getMessage(),
+ TSStatusCode.DATABASE_MODEL.getStatusCode());
}
clientSession.setDatabaseName(useDB.getDatabaseId().getValue());
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
@@ -3143,26 +3078,26 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
String.format("Unknown database %s",
useDB.getDatabaseId().getValue()),
TSStatusCode.DATABASE_NOT_EXIST.getStatusCode()));
}
- } catch (final IOException | ClientManagerException | TException |
DatabaseModelException e) {
+ } catch (final IOException | ClientManagerException | TException |
IoTDBException e) {
future.setException(e);
}
return future;
}
- private String transformDBName(String dbName) {
+ private String transformDBName(final String dbName) {
return ROOT + PATH_SEPARATOR_CHAR + dbName;
}
@Override
- public SettableFuture<ConfigTaskResult> dropDatabase(DropDB dropDB) {
- SettableFuture<ConfigTaskResult> future = SettableFuture.create();
- TDeleteDatabasesReq req =
+ public SettableFuture<ConfigTaskResult> dropDatabase(final DropDB dropDB) {
+ final SettableFuture<ConfigTaskResult> future = SettableFuture.create();
+ final TDeleteDatabasesReq req =
new TDeleteDatabasesReq(
Collections.singletonList(transformDBName(dropDB.getDbName().getValue())))
.setIsTableModel(true);
- try (ConfigNodeClient client =
+ try (final ConfigNodeClient client =
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
- TSStatus tsStatus = client.deleteDatabases(req);
+ final TSStatus tsStatus = client.deleteDatabases(req);
if (TSStatusCode.SUCCESS_STATUS.getStatusCode() == tsStatus.getCode()) {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
} else if (TSStatusCode.PATH_NOT_EXIST.getStatusCode() ==
tsStatus.getCode()) {
@@ -3184,7 +3119,7 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
tsStatus);
future.setException(new IoTDBException(tsStatus.message,
tsStatus.getCode()));
}
- } catch (ClientManagerException | TException e) {
+ } catch (final ClientManagerException | TException e) {
future.setException(e);
}
return future;
@@ -3207,8 +3142,6 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
if (ifNotExists) {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
} else {
- LOGGER.info(
- "Failed to CREATE DATABASE {}, because it already exists",
databaseSchema.getName());
future.setException(
new IoTDBException(
String.format(
@@ -3216,10 +3149,6 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
TSStatusCode.DATABASE_ALREADY_EXISTS.getStatusCode()));
}
} else {
- LOGGER.warn(
- "Failed to execute create database {} in config node, status is
{}.",
- databaseSchema.getName(),
- tsStatus);
future.setException(new IoTDBException(tsStatus.message,
tsStatus.code));
}
} catch (final ClientManagerException | TException e) {
@@ -3259,11 +3188,6 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
&& ifNotExists)) {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
} else {
- LOGGER.warn(
- "Failed to create table {}.{} in config node, status is {}.",
- database,
- table.getTableName(),
- tsStatus);
future.setException(
new IoTDBException(getTableErrorMessage(tsStatus, database),
tsStatus.getCode()));
}
@@ -3282,10 +3206,6 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
final TDescTableResp resp = configNodeClient.describeTable(database,
tableName, isDetails);
if (TSStatusCode.SUCCESS_STATUS.getStatusCode() !=
resp.getStatus().getCode()) {
- LOGGER.warn(
- "Failed to describe tables in database {} in config node, status
is {}.",
- database,
- resp.getStatus());
future.setException(
new IoTDBException(
getTableErrorMessage(resp.getStatus(), database),
resp.getStatus().code));
@@ -3312,10 +3232,6 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
CONFIG_NODE_CLIENT_MANAGER.borrowClient(ConfigNodeInfo.CONFIG_REGION_ID)) {
final TShowTableResp resp = configNodeClient.showTables(database,
isDetails);
if (TSStatusCode.SUCCESS_STATUS.getStatusCode() !=
resp.getStatus().getCode()) {
- LOGGER.warn(
- "Failed to show tables in database {} in config node, status is
{}.",
- database,
- resp.getStatus());
future.setException(
new IoTDBException(
getTableErrorMessage(resp.getStatus(), database),
resp.getStatus().code));
@@ -3380,12 +3296,6 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
&& tableIfExists)) {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
} else {
- LOGGER.warn(
- "Failed to rename table to {} from table {}.{}, status is {}.",
- targetName,
- database,
- sourceName,
- tsStatus);
future.setException(
new IoTDBException(getTableErrorMessage(tsStatus, database),
tsStatus.getCode()));
}
@@ -3422,8 +3332,6 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
&& columnIfExists)) {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
} else {
- LOGGER.warn(
- "Failed to add column to table {}.{}, status is {}.", database,
tableName, tsStatus);
future.setException(
new IoTDBException(getTableErrorMessage(tsStatus, database),
tsStatus.getCode()));
}
@@ -3469,13 +3377,6 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
&& columnIfExists)) {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
} else {
- LOGGER.warn(
- "Failed to rename column from {} to {} for table {}.{}, status is
{}.",
- oldName,
- newName,
- database,
- tableName,
- tsStatus);
future.setException(
new IoTDBException(getTableErrorMessage(tsStatus, database),
tsStatus.getCode()));
}
@@ -3519,12 +3420,6 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
&& columnIfExists)) {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
} else {
- LOGGER.warn(
- "Failed to drop column {} for table {}.{}, status is {}.",
- columnName,
- database,
- tableName,
- tsStatus);
future.setException(
new IoTDBException(getTableErrorMessage(tsStatus, database),
tsStatus.getCode()));
}
@@ -3565,12 +3460,6 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
|| (TSStatusCode.TABLE_NOT_EXISTS.getStatusCode() ==
tsStatus.getCode() && ifExists)) {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
} else {
- LOGGER.warn(
- "Failed to set properties {} to table {}.{}, status is {}.",
- properties,
- database,
- tableName,
- tsStatus);
future.setException(
new IoTDBException(getTableErrorMessage(tsStatus, database),
tsStatus.getCode()));
}
@@ -3600,7 +3489,6 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
|| (TSStatusCode.TABLE_NOT_EXISTS.getStatusCode() ==
tsStatus.getCode() && ifExists)) {
future.set(new ConfigTaskResult(TSStatusCode.SUCCESS_STATUS));
} else {
- LOGGER.warn("Failed to drop table {}.{}, status is {}.", database,
tableName, tsStatus);
future.setException(
new IoTDBException(getTableErrorMessage(tsStatus, database),
tsStatus.getCode()));
}
@@ -3669,11 +3557,6 @@ public class ClusterConfigTaskExecutor implements
IConfigTaskExecutor {
if (TSStatusCode.SUCCESS_STATUS.getStatusCode() ==
resp.getStatus().getCode()) {
DeleteDeviceTask.buildTSBlock(resp.getDeletedNum(), future);
} else {
- LOGGER.warn(
- "Failed to delete devices from table {}.{}, status is {}.",
- deleteDevice.getDatabase(),
- deleteDevice.getTableName(),
- resp.getStatus());
future.setException(
new IoTDBException(
getTableErrorMessage(resp.getStatus(),
deleteDevice.getDatabase()),
diff --git
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/ErrorHandlingUtils.java
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/ErrorHandlingUtils.java
index 76fdbb04010..247a0a3fe82 100644
---
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/ErrorHandlingUtils.java
+++
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/ErrorHandlingUtils.java
@@ -107,7 +107,7 @@ public class ErrorHandlingUtils {
|| status.getCode() ==
TSStatusCode.NUMERIC_VALUE_OUT_OF_RANGE.getStatusCode()
|| status.getCode() ==
TSStatusCode.DIVISION_BY_ZERO.getStatusCode()
|| status.getCode() ==
TSStatusCode.DATE_OUT_OF_RANGE.getStatusCode()) {
- LOGGER.warn(message);
+ LOGGER.info(message);
} else {
LOGGER.warn(message, e);
}
