This is an automated email from the ASF dual-hosted git repository.

jackietien pushed a commit to branch TreeToTableView
in repository https://gitbox.apache.org/repos/asf/iotdb.git


The following commit(s) were added to refs/heads/TreeToTableView by this push:
     new 5dc8995ba82 remove useless todo
5dc8995ba82 is described below

commit 5dc8995ba82ac8483a7463fdf6fdb55a746bc3ed
Author: JackieTien97 <[email protected]>
AuthorDate: Thu Jan 2 17:56:42 2025 +0800

    remove useless todo
---
 .github/workflows/cluster-it-1c1d.yml              |  1 -
 .../relational/metadata/TableMetadataImpl.java     | 15 --------------
 .../metadata/fetcher/TableDeviceSchemaFetcher.java | 23 ----------------------
 3 files changed, 39 deletions(-)

diff --git a/.github/workflows/cluster-it-1c1d.yml 
b/.github/workflows/cluster-it-1c1d.yml
index 96e6977f6d9..7bd2fcf6674 100644
--- a/.github/workflows/cluster-it-1c1d.yml
+++ b/.github/workflows/cluster-it-1c1d.yml
@@ -15,7 +15,6 @@ on:
       - master
       - 'rel/1.*'
       - 'rc/1.*'
-      - 'TreeToTableView'
     paths-ignore:
       - 'docs/**'
       - 'site/**'
diff --git 
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/metadata/TableMetadataImpl.java
 
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/metadata/TableMetadataImpl.java
index 5a803d9ee91..e544c212a28 100644
--- 
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/metadata/TableMetadataImpl.java
+++ 
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/metadata/TableMetadataImpl.java
@@ -23,7 +23,6 @@ import org.apache.iotdb.commons.partition.DataPartition;
 import org.apache.iotdb.commons.partition.DataPartitionQueryParam;
 import org.apache.iotdb.commons.partition.SchemaPartition;
 import org.apache.iotdb.commons.schema.table.TsTable;
-import org.apache.iotdb.commons.schema.table.column.TsTableColumnCategory;
 import 
org.apache.iotdb.commons.udf.builtin.relational.TableBuiltinAggregationFunction;
 import 
org.apache.iotdb.commons.udf.builtin.relational.TableBuiltinScalarFunction;
 import org.apache.iotdb.commons.udf.utils.TableUDFUtils;
@@ -62,7 +61,6 @@ import org.apache.tsfile.read.common.type.StringType;
 import org.apache.tsfile.read.common.type.Type;
 import org.apache.tsfile.read.common.type.TypeFactory;
 
-import java.util.ArrayList;
 import java.util.Collections;
 import java.util.List;
 import java.util.Locale;
@@ -97,19 +95,6 @@ public class TableMetadataImpl implements Metadata {
   @Override
   public Optional<TableSchema> getTableSchema(
       final SessionInfo session, final QualifiedObjectName name) {
-
-    // TODO remove me
-    if ("tree_view".equals(name.getDatabaseName())) {
-      List<ColumnSchema> columns = new ArrayList<>();
-      columns.add(new ColumnSchema("time", TIMESTAMP, false, 
TsTableColumnCategory.TIME));
-      columns.add(new ColumnSchema("tag_1", STRING, false, 
TsTableColumnCategory.TAG));
-      columns.add(new ColumnSchema("tag_2", STRING, false, 
TsTableColumnCategory.TAG));
-      columns.add(new ColumnSchema("s_1", DOUBLE, false, 
TsTableColumnCategory.FIELD));
-      columns.add(new ColumnSchema("s_2", DOUBLE, false, 
TsTableColumnCategory.FIELD));
-
-      return Optional.of(new TreeDeviceViewSchema(name.getObjectName(), 
columns));
-    }
-
     final TsTable table = tableCache.getTable(name.getDatabaseName(), 
name.getObjectName());
     return Objects.isNull(table)
         ? Optional.empty()
diff --git 
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/metadata/fetcher/TableDeviceSchemaFetcher.java
 
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/metadata/fetcher/TableDeviceSchemaFetcher.java
index f80ce39d663..294a4d78a7b 100644
--- 
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/metadata/fetcher/TableDeviceSchemaFetcher.java
+++ 
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/metadata/fetcher/TableDeviceSchemaFetcher.java
@@ -54,7 +54,6 @@ import org.apache.tsfile.utils.Pair;
 
 import java.util.ArrayList;
 import java.util.Collection;
-import java.util.Collections;
 import java.util.HashMap;
 import java.util.LinkedHashSet;
 import java.util.List;
@@ -169,28 +168,6 @@ public class TableDeviceSchemaFetcher {
       final List<Expression> expressionList,
       final List<String> attributeColumns,
       final MPPQueryContext queryContext) {
-
-    // TODO remove me
-    if ("tree_view".equals(database)) {
-      List<DeviceEntry> deviceEntries = new ArrayList<>(4);
-      deviceEntries.add(
-          new AlignedDeviceEntry(
-              IDeviceID.Factory.DEFAULT_FACTORY.create("root.tree.a_1.b_1"),
-              Collections.emptyList()));
-      deviceEntries.add(
-          new AlignedDeviceEntry(
-              IDeviceID.Factory.DEFAULT_FACTORY.create("root.tree.a_1.b_2"),
-              Collections.emptyList()));
-      deviceEntries.add(
-          new AlignedDeviceEntry(
-              IDeviceID.Factory.DEFAULT_FACTORY.create("root.tree.a_2"), 
Collections.emptyList()));
-      deviceEntries.add(
-          new AlignedDeviceEntry(
-              IDeviceID.Factory.DEFAULT_FACTORY.create("root.tree.a_2.b_2"),
-              Collections.emptyList()));
-      return deviceEntries;
-    }
-
     final List<DeviceEntry> deviceEntryList = new ArrayList<>();
     final ShowDevice statement = new ShowDevice(database, table);
     final TsTable tableInstance = 
DataNodeTableCache.getInstance().getTable(database, table);

Reply via email to