(iotdb) branch dev/1.3 updated: Pipe: Fixed the validation logic of OpcDaConnector & Optimized the error message when the system is not Windows (#15339) (#15382)

[rong]

This is an automated email from the ASF dual-hosted git repository.

rong pushed a commit to branch dev/1.3
in repository https://gitbox.apache.org/repos/asf/iotdb.git


The following commit(s) were added to refs/heads/dev/1.3 by this push:
     new ca848e9d283 Pipe: Fixed the validation logic of OpcDaConnector & 
Optimized the error message when the system is not Windows (#15339) (#15382)
ca848e9d283 is described below

commit ca848e9d28302746b0cd555d97d9b2b16fd27554
Author: Caideyipi <87789683+caidey...@users.noreply.github.com>
AuthorDate: Mon Apr 21 20:33:49 2025 +0800

    Pipe: Fixed the validation logic of OpcDaConnector & Optimized the error 
message when the system is not Windows (#15339) (#15382)
---
 .../iotdb/db/pipe/connector/protocol/opcda/OpcDaConnector.java    | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git 
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/opcda/OpcDaConnector.java
 
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/opcda/OpcDaConnector.java
index 8bd54d9c0a8..397f786c266 100644
--- 
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/opcda/OpcDaConnector.java
+++ 
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/connector/protocol/opcda/OpcDaConnector.java
@@ -26,6 +26,7 @@ import 
org.apache.iotdb.pipe.api.customizer.parameter.PipeParameterValidator;
 import org.apache.iotdb.pipe.api.customizer.parameter.PipeParameters;
 import org.apache.iotdb.pipe.api.event.Event;
 import org.apache.iotdb.pipe.api.event.dml.insertion.TabletInsertionEvent;
+import org.apache.iotdb.pipe.api.exception.PipeParameterNotValidException;
 
 import org.apache.tsfile.utils.Pair;
 import org.slf4j.Logger;
@@ -56,8 +57,7 @@ public class OpcDaConnector implements PipeConnector {
   public void validate(final PipeParameterValidator validator) throws 
Exception {
     // TODO: upgrade this logic after "1 in 2" logic is supported
     validator.validate(
-        args ->
-            (((boolean) args[1] || (boolean) args[2] || (boolean) args[3] || 
(boolean) args[4])),
+        args -> (boolean) args[0] || (boolean) args[1] || (boolean) args[2] || 
(boolean) args[3],
         String.format(
             "One of '%s', '%s', '%s' and '%s' must be specified",
             SINK_OPC_DA_CLSID_KEY,
@@ -68,6 +68,10 @@ public class OpcDaConnector implements PipeConnector {
         validator.getParameters().hasAttribute(CONNECTOR_OPC_DA_CLSID_KEY),
         validator.getParameters().hasAttribute(SINK_OPC_DA_PROGID_KEY),
         validator.getParameters().hasAttribute(CONNECTOR_OPC_DA_PROGID_KEY));
+
+    if (!System.getProperty("os.name").toLowerCase().startsWith("windows")) {
+      throw new PipeParameterNotValidException("opc-da-sink must run on 
windows system.");
+    }
   }
 
   @Override