This is an automated email from the ASF dual-hosted git repository. jackietien pushed a commit to branch ChangeSetUpWay in repository https://gitbox.apache.org/repos/asf/iotdb.git
commit d595d62c4577308778a628c5226a32415865837b Author: JackieTien97 <[email protected]> AuthorDate: Wed May 28 09:56:20 2025 +0800 Make it easier for users to extend ClientRPCServiceImpl to export more rpc services --- .../src/main/java/org/apache/iotdb/db/service/DataNode.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/DataNode.java b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/DataNode.java index b15c3590beb..9531e645a11 100644 --- a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/DataNode.java +++ b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/DataNode.java @@ -178,7 +178,6 @@ public class DataNode extends ServerCommandLine implements DataNodeMBean { DataNodeHolder.INSTANCE = this; } - // TODO: This needs removal of statics ... public static void reinitializeStatics() { registerManager = new RegisterManager(); DataNodeSystemPropertiesHandler.getInstance() @@ -791,7 +790,7 @@ public class DataNode extends ServerCommandLine implements DataNodeMBean { // Start client RPCService to indicate that the current DataNode provide external services IoTDBDescriptor.getInstance() .getConfig() - .setRpcImplClassName(ClientRPCServiceImpl.class.getName()); + .setRpcImplClassName(getClientRPCServiceImplClassName()); if (config.isEnableRpcService()) { registerManager.register(ExternalRPCService.getInstance()); } @@ -799,6 +798,11 @@ public class DataNode extends ServerCommandLine implements DataNodeMBean { initProtocols(); } + // make it easier for users to extend ClientRPCServiceImpl to export more rpc services + protected String getClientRPCServiceImplClassName() { + return ClientRPCServiceImpl.class.getName(); + } + private void setUpMetricService() throws StartupException { MetricConfigDescriptor.getInstance().getMetricConfig().setNodeId(config.getDataNodeId()); registerManager.register(MetricService.getInstance());
