This is an automated email from the ASF dual-hosted git repository.
justinchen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iotdb.git
The following commit(s) were added to refs/heads/master by this push:
new a527b929822 Set the parameter names from default_storage_group_level
to default_database_level (#16626)
a527b929822 is described below
commit a527b929822a01d9c86a362c279f33fb5991e6e0
Author: Caideyipi <[email protected]>
AuthorDate: Thu Oct 23 19:47:40 2025 +0800
Set the parameter names from default_storage_group_level to
default_database_level (#16626)
---
.../it/env/cluster/config/MppCommonConfig.java | 2 +-
.../apache/iotdb/db/it/IoTDBSetConfigurationIT.java | 10 +++++-----
.../java/org/apache/iotdb/db/conf/IoTDBConfig.java | 21 ++++++++++-----------
.../org/apache/iotdb/db/conf/IoTDBDescriptor.java | 18 ++++++++++++------
.../analyze/cache/partition/PartitionCache.java | 2 +-
.../plan/relational/sql/ast/LoadTsFile.java | 2 +-
.../plan/statement/crud/LoadTsFileStatement.java | 4 ++--
.../load/config/LoadTsFileConfigurator.java | 2 +-
.../resources/conf/iotdb-system.properties.template | 2 +-
9 files changed, 34 insertions(+), 29 deletions(-)
diff --git
a/integration-test/src/main/java/org/apache/iotdb/it/env/cluster/config/MppCommonConfig.java
b/integration-test/src/main/java/org/apache/iotdb/it/env/cluster/config/MppCommonConfig.java
index f9120ddb131..1df43c16206 100644
---
a/integration-test/src/main/java/org/apache/iotdb/it/env/cluster/config/MppCommonConfig.java
+++
b/integration-test/src/main/java/org/apache/iotdb/it/env/cluster/config/MppCommonConfig.java
@@ -581,7 +581,7 @@ public class MppCommonConfig extends MppBaseConfig
implements CommonConfig {
@Override
public CommonConfig setDefaultStorageGroupLevel(int
defaultStorageGroupLevel) {
- setProperty("default_storage_group_level",
String.valueOf(defaultStorageGroupLevel));
+ setProperty("default_database_level",
String.valueOf(defaultStorageGroupLevel));
return this;
}
diff --git
a/integration-test/src/test/java/org/apache/iotdb/db/it/IoTDBSetConfigurationIT.java
b/integration-test/src/test/java/org/apache/iotdb/db/it/IoTDBSetConfigurationIT.java
index f5d3d12c981..aceec6d2075 100644
---
a/integration-test/src/test/java/org/apache/iotdb/db/it/IoTDBSetConfigurationIT.java
+++
b/integration-test/src/test/java/org/apache/iotdb/db/it/IoTDBSetConfigurationIT.java
@@ -153,7 +153,7 @@ public class IoTDBSetConfigurationIT {
try (Connection connection = EnvFactory.getEnv().getConnection();
Statement statement = connection.createStatement()) {
// legal value
- statement.execute("set configuration
\"default_storage_group_level\"=\"3\"");
+ statement.execute("set configuration \"default_database_level\"=\"3\"");
statement.execute("INSERT INTO root.a.b.c.d1(timestamp, s1) VALUES (1,
1)");
ResultSet databases = statement.executeQuery("show databases root.a.**");
databases.next();
@@ -171,19 +171,19 @@ public class IoTDBSetConfigurationIT {
// illegal value
try {
- statement.execute("set configuration
\"default_storage_group_level\"=\"-1\"");
+ statement.execute("set configuration
\"default_database_level\"=\"-1\"");
} catch (SQLException e) {
- assertTrue(e.getMessage().contains("Illegal defaultStorageGroupLevel:
-1, should >= 1"));
+ assertTrue(e.getMessage().contains("Illegal defaultDatabaseLevel: -1,
should >= 1"));
}
// Failed updates will not change the files.
// Failed updates will not change the files.
assertFalse(
checkConfigFileContains(
- EnvFactory.getEnv().getDataNodeWrapper(0),
"default_storage_group_level=-1"));
+ EnvFactory.getEnv().getDataNodeWrapper(0),
"default_database_level=-1"));
assertTrue(
checkConfigFileContains(
- EnvFactory.getEnv().getDataNodeWrapper(0),
"default_storage_group_level=3"));
+ EnvFactory.getEnv().getDataNodeWrapper(0),
"default_database_level=3"));
}
// can start with an illegal value
diff --git
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java
index 64d0dc6d214..7db1b0f0225 100644
---
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java
+++
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java
@@ -632,7 +632,7 @@ public class IoTDBConfig {
private TSDataType nanStringInferType = TSDataType.DOUBLE;
/** Database level when creating schema automatically is enabled */
- private int defaultStorageGroupLevel = 1;
+ private int defaultDatabaseLevel = 1;
/** BOOLEAN encoding when creating schema automatically is enabled */
private TSEncoding defaultBooleanEncoding = TSEncoding.RLE;
@@ -2273,24 +2273,23 @@ public class IoTDBConfig {
this.nanStringInferType = nanStringInferType;
}
- public int getDefaultStorageGroupLevel() {
- return defaultStorageGroupLevel;
+ public int getDefaultDatabaseLevel() {
+ return defaultDatabaseLevel;
}
- void setDefaultStorageGroupLevel(int defaultStorageGroupLevel, boolean
startUp) {
- if (defaultStorageGroupLevel < 1) {
+ void setDefaultDatabaseLevel(int defaultDatabaseLevel, boolean startUp) {
+ if (defaultDatabaseLevel < 1) {
if (startUp) {
logger.warn(
- "Illegal defaultStorageGroupLevel: {}, should >= 1, use default
value 1",
- defaultStorageGroupLevel);
- defaultStorageGroupLevel = 1;
+ "Illegal defaultDatabaseLevel: {}, should >= 1, use default value
1",
+ defaultDatabaseLevel);
+ defaultDatabaseLevel = 1;
} else {
throw new IllegalArgumentException(
- String.format(
- "Illegal defaultStorageGroupLevel: %d, should >= 1",
defaultStorageGroupLevel));
+ String.format("Illegal defaultDatabaseLevel: %d, should >= 1",
defaultDatabaseLevel));
}
}
- this.defaultStorageGroupLevel = defaultStorageGroupLevel;
+ this.defaultDatabaseLevel = defaultDatabaseLevel;
}
public TSEncoding getDefaultBooleanEncoding() {
diff --git
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBDescriptor.java
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBDescriptor.java
index d04d24f722c..59b59e130c5 100644
---
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBDescriptor.java
+++
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBDescriptor.java
@@ -1729,12 +1729,18 @@ public class IoTDBDescriptor {
properties.getProperty(
"nan_string_infer_type",
ConfigurationFileUtils.getConfigurationDefaultValue("nan_string_infer_type"))));
- conf.setDefaultStorageGroupLevel(
- Integer.parseInt(
- properties.getProperty(
- "default_storage_group_level",
- ConfigurationFileUtils.getConfigurationDefaultValue(
- "default_storage_group_level"))),
+ conf.setDefaultDatabaseLevel(
+ Integer.parseInt(
+
Optional.ofNullable(properties.getProperty("default_database_level"))
+ .orElse(
+ properties.getProperty(
+ "default_storage_group_level",
+ Optional.ofNullable(
+
ConfigurationFileUtils.getConfigurationDefaultValue(
+ "default_database_level"))
+ .orElse(
+
ConfigurationFileUtils.getConfigurationDefaultValue(
+ "default_storage_group_level"))))),
startUp);
conf.setDefaultBooleanEncoding(
properties.getProperty(
diff --git
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/cache/partition/PartitionCache.java
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/cache/partition/PartitionCache.java
index 3c5f6e623ee..df379b47896 100644
---
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/cache/partition/PartitionCache.java
+++
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/cache/partition/PartitionCache.java
@@ -303,7 +303,7 @@ public class PartitionCache {
} else {
final PartialPath databaseNameNeedCreated =
MetaUtils.getDatabasePathByLevel(
- new PartialPath(deviceID),
config.getDefaultStorageGroupLevel());
+ new PartialPath(deviceID),
config.getDefaultDatabaseLevel());
databaseNamesNeedCreated.add(databaseNameNeedCreated.getFullPath());
}
}
diff --git
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/LoadTsFile.java
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/LoadTsFile.java
index 5bbb8939f91..93fc8c7b583 100644
---
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/LoadTsFile.java
+++
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/LoadTsFile.java
@@ -61,7 +61,7 @@ public class LoadTsFile extends Statement {
super(location);
this.filePath = requireNonNull(filePath, "filePath is null");
- this.databaseLevel =
IoTDBDescriptor.getInstance().getConfig().getDefaultStorageGroupLevel();
+ this.databaseLevel =
IoTDBDescriptor.getInstance().getConfig().getDefaultDatabaseLevel();
this.deleteAfterLoad = false;
this.convertOnTypeMismatch = true;
this.tabletConversionThresholdBytes =
diff --git
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/LoadTsFileStatement.java
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/LoadTsFileStatement.java
index 4c27796680b..dbc4cb7b64d 100644
---
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/LoadTsFileStatement.java
+++
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/crud/LoadTsFileStatement.java
@@ -72,7 +72,7 @@ public class LoadTsFileStatement extends Statement {
public LoadTsFileStatement(String filePath) throws FileNotFoundException {
this.file = new File(filePath);
- this.databaseLevel =
IoTDBDescriptor.getInstance().getConfig().getDefaultStorageGroupLevel();
+ this.databaseLevel =
IoTDBDescriptor.getInstance().getConfig().getDefaultDatabaseLevel();
this.verifySchema = true;
this.deleteAfterLoad = false;
this.convertOnTypeMismatch = true;
@@ -106,7 +106,7 @@ public class LoadTsFileStatement extends Statement {
protected LoadTsFileStatement() {
this.file = null;
- this.databaseLevel =
IoTDBDescriptor.getInstance().getConfig().getDefaultStorageGroupLevel();
+ this.databaseLevel =
IoTDBDescriptor.getInstance().getConfig().getDefaultDatabaseLevel();
this.verifySchema = true;
this.deleteAfterLoad = false;
this.convertOnTypeMismatch = true;
diff --git
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/config/LoadTsFileConfigurator.java
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/config/LoadTsFileConfigurator.java
index 31f1432fd93..da94de532d1 100644
---
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/config/LoadTsFileConfigurator.java
+++
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/config/LoadTsFileConfigurator.java
@@ -75,7 +75,7 @@ public class LoadTsFileConfigurator {
public static final String DATABASE_LEVEL_KEY = "database-level";
private static final int DATABASE_LEVEL_DEFAULT_VALUE =
- IoTDBDescriptor.getInstance().getConfig().getDefaultStorageGroupLevel();
+ IoTDBDescriptor.getInstance().getConfig().getDefaultDatabaseLevel();
private static final int DATABASE_LEVEL_MIN_VALUE = 1;
public static void validateDatabaseLevelParam(final String databaseLevel) {
diff --git
a/iotdb-core/node-commons/src/assembly/resources/conf/iotdb-system.properties.template
b/iotdb-core/node-commons/src/assembly/resources/conf/iotdb-system.properties.template
index 207c0507093..6c0d71addf3 100644
---
a/iotdb-core/node-commons/src/assembly/resources/conf/iotdb-system.properties.template
+++
b/iotdb-core/node-commons/src/assembly/resources/conf/iotdb-system.properties.template
@@ -930,7 +930,7 @@ enable_auto_create_schema=true
# Default: 1
# When illegal: report an error and change nothing during hot-reload; use the
default value in
# start-up
-default_storage_group_level=1
+default_database_level=1
# ALL data types: BOOLEAN, INT32, INT64, FLOAT, DOUBLE, TEXT
