This is an automated email from the ASF dual-hosted git repository. pengjunzhi pushed a commit to branch procedure-fix in repository https://gitbox.apache.org/repos/asf/iotdb.git
commit dc82f25d220fe043d07315d063f66fbe7aa81096 Author: Peng Junzhi <[email protected]> AuthorDate: Fri Nov 14 10:37:48 2025 +0800 fix comment --- .../confignode/procedure/CompletedProcedureRecycler.java | 4 ++-- .../org/apache/iotdb/confignode/procedure/Procedure.java | 2 +- .../iotdb/confignode/procedure/ProcedureExecutor.java | 16 ++++++++-------- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/CompletedProcedureRecycler.java b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/CompletedProcedureRecycler.java index 72e32a5c4c8..179563cc3b3 100644 --- a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/CompletedProcedureRecycler.java +++ b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/CompletedProcedureRecycler.java @@ -76,7 +76,7 @@ public class CompletedProcedureRecycler<Env> extends InternalProcedure<Env> { LOG.error("Error deleting completed procedures {}.", proc, e); // Do not remove from the completed map. Even this procedure may be restored // unexpectedly in another new CN leader, we do not need to do anything else since - // procedures are idempotency. + // procedures are idempotent. continue; } finally { batchCount = 0; @@ -91,7 +91,7 @@ public class CompletedProcedureRecycler<Env> extends InternalProcedure<Env> { store.delete(batchIds, 0, batchCount); } catch (Exception e) { // Even this procedure may be restored unexpectedly in another new CN leader, we do not need - // to do anything else since procedures are idempotency. + // to do anything else since procedures are idempotent. LOG.error("Error deleting completed procedures {}.", batchIds, e); } } diff --git a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/Procedure.java b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/Procedure.java index 83c0776397a..89e6e37e431 100644 --- a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/Procedure.java +++ b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/Procedure.java @@ -307,7 +307,7 @@ public abstract class Procedure<Env> implements Comparable<Procedure<Env>> { } catch (Exception e) { // Do not need to do anything else. New leader which restore this procedure from a wrong // state will reexecute it and converge to the correct state since procedures are - // idempotency. + // idempotent. LOG.warn("pid={} Failed to persist lock state to store.", this.procId, e); } } diff --git a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/ProcedureExecutor.java b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/ProcedureExecutor.java index 8a1afc77581..fdefdd40c7d 100644 --- a/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/ProcedureExecutor.java +++ b/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/ProcedureExecutor.java @@ -479,7 +479,7 @@ public class ProcedureExecutor<Env> { } if (parent != null && parent.tryRunnable()) { // If success, means all its children have completed, move parent to front of the queue. - // Must endless retry here, since this step is not idempotency and can not be reexecute + // Must endless retry here, since this step is not idempotent and can not be reexecute // correctly in new CN leader. RetryUtils.executeWithEndlessBackoffRetry( () -> store.update(parent), "count down children procedure"); @@ -515,7 +515,7 @@ public class ProcedureExecutor<Env> { try { store.update(subprocs); } catch (Exception e) { - // Do nothing since this step is idempotency. New CN leader can converge to the correct + // Do nothing since this step is idempotent. New CN leader can converge to the correct // state when restore this procedure. LOG.warn("Failed to update subprocs on execution", e); } @@ -531,7 +531,7 @@ public class ProcedureExecutor<Env> { procedures.remove(childProcId); } } catch (Exception e) { - // Do nothing since this step is idempotency. New CN leader can converge to the correct + // Do nothing since this step is idempotent. New CN leader can converge to the correct // state when restore this procedure. LOG.warn("Failed to delete subprocedures on execution", e); } @@ -546,7 +546,7 @@ public class ProcedureExecutor<Env> { try { store.update(proc); } catch (Exception e) { - // Do nothing since this step is idempotency. New CN leader can converge to the correct + // Do nothing since this step is idempotent. New CN leader can converge to the correct // state when restore this procedure. LOG.warn("Failed to update procedure on execution", e); } @@ -606,7 +606,7 @@ public class ProcedureExecutor<Env> { if (exception == null) { exception = procedureStack.getException(); rootProcedure.setFailure(exception); - // Endless retry since this step is not idempotency. + // Endless retry since this step is not idempotent. RetryUtils.executeWithEndlessBackoffRetry( () -> store.update(rootProcedure), "root procedure rollback"); } @@ -689,7 +689,7 @@ public class ProcedureExecutor<Env> { // do not remove this procedure when exception occurred procedures.remove(procedure.getProcId()); } catch (Exception e) { - // Do nothing since this step is idempotency. New CN leader can converge to the correct + // Do nothing since this step is idempotent. New CN leader can converge to the correct // state when restore this procedure. LOG.warn("Failed to delete procedure on rollback", e); } @@ -702,7 +702,7 @@ public class ProcedureExecutor<Env> { store.update(procedure); } } catch (Exception e) { - // Do nothing since this step is idempotency. New CN leader can converge to the correct + // Do nothing since this step is idempotent. New CN leader can converge to the correct // state when restore this procedure. LOG.warn("Failed to delete procedure on rollback", e); } @@ -711,7 +711,7 @@ public class ProcedureExecutor<Env> { try { store.update(procedure); } catch (Exception e) { - // Do nothing since this step is idempotency. New CN leader can converge to the correct + // Do nothing since this step is idempotent. New CN leader can converge to the correct // state when restore this procedure. LOG.warn("Failed to update procedure on rollback", e); }
