(iotdb) branch add_base32_path updated: Fix review

[haonan]

This is an automated email from the ASF dual-hosted git repository.

haonan pushed a commit to branch add_base32_path
in repository https://gitbox.apache.org/repos/asf/iotdb.git


The following commit(s) were added to refs/heads/add_base32_path by this push:
     new f6e68bdee3b Fix review
f6e68bdee3b is described below

commit f6e68bdee3b56adef37c1cc5145c83a6f096ea06
Author: HTHou <hao...@apache.org>
AuthorDate: Mon Dec 15 14:25:05 2025 +0800

    Fix review
---
 .../plan/planner/plan/node/write/RelationalInsertRowsNode.java   | 9 ++++-----
 .../plan/planner/plan/node/write/RelationalInsertTabletNode.java | 9 ++++-----
 .../iotdb/db/queryengine/plan/function/RecordObjectTypeTest.java | 2 +-
 3 files changed, 9 insertions(+), 11 deletions(-)

diff --git 
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/RelationalInsertRowsNode.java
 
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/RelationalInsertRowsNode.java
index 920b696abe6..6eeb3d7322f 100644
--- 
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/RelationalInsertRowsNode.java
+++ 
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/RelationalInsertRowsNode.java
@@ -43,6 +43,8 @@ import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
 
+import static org.apache.iotdb.db.utils.ObjectTypeUtils.generateObjectBinary;
+
 public class RelationalInsertRowsNode extends InsertRowsNode {
   // deviceId cache for Table-view insertion
   private IDeviceID[] deviceIDs;
@@ -223,11 +225,8 @@ public class RelationalInsertRowsNode extends 
InsertRowsNode {
         objectNode.setDataRegionReplicaSet(dataRegionReplicaSet);
         writePlanNodeList.add(objectNode);
         if (isEoF) {
-          ByteBuffer valueBytes =
-              ByteBuffer.allocate(relativePath.getSerializeSizeToObjectValue() 
+ Long.BYTES);
-          valueBytes.putLong(offset + content.length);
-          relativePath.serializeToObjectValue(valueBytes);
-          ((Binary) values[j]).setValues(valueBytes.array());
+          ((Binary) values[j])
+              .setValues(generateObjectBinary(offset + content.length, 
relativePath).getValues());
           insertRowNode.setValues(values);
         } else {
           values[j] = null;
diff --git 
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/RelationalInsertTabletNode.java
 
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/RelationalInsertTabletNode.java
index 1f6a8011686..3255c11f1e9 100644
--- 
a/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/RelationalInsertTabletNode.java
+++ 
b/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/write/RelationalInsertTabletNode.java
@@ -55,6 +55,8 @@ import java.util.List;
 import java.util.Map;
 import java.util.Map.Entry;
 
+import static org.apache.iotdb.db.utils.ObjectTypeUtils.generateObjectBinary;
+
 public class RelationalInsertTabletNode extends InsertTabletNode {
 
   // deviceId cache for Table-view insertion
@@ -478,11 +480,8 @@ public class RelationalInsertTabletNode extends 
InsertTabletNode {
       objectNode.setDataRegionReplicaSet(entry.getKey());
       result.add(objectNode);
       if (isEoF) {
-        ByteBuffer valueBytes =
-            ByteBuffer.allocate(relativePath.getSerializeSizeToObjectValue() + 
Long.BYTES);
-        valueBytes.putLong(offset + content.length);
-        relativePath.serializeToObjectValue(valueBytes);
-        ((Binary[]) columns[column])[j] = new Binary(valueBytes.array());
+        ((Binary[]) columns[column])[j] =
+            generateObjectBinary(offset + content.length, relativePath);
       } else {
         ((Binary[]) columns[column])[j] = null;
         if (bitMaps == null) {
diff --git 
a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/queryengine/plan/function/RecordObjectTypeTest.java
 
b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/queryengine/plan/function/RecordObjectTypeTest.java
index bc5ee088a07..98f2428e8d5 100644
--- 
a/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/queryengine/plan/function/RecordObjectTypeTest.java
+++ 
b/iotdb-core/datanode/src/test/java/org/apache/iotdb/db/queryengine/plan/function/RecordObjectTypeTest.java
@@ -78,7 +78,7 @@ public class RecordObjectTypeTest {
         Files.delete(file.toPath());
       }
     }
-    config.setRestrictObjectLimit(true);
+    config.setRestrictObjectLimit(false);
   }
 
   @Test