ISIS-1603: uses tabindex=-"-1" to prevent tabbing into footer and bookmarks


Project: http://git-wip-us.apache.org/repos/asf/isis/repo
Commit: http://git-wip-us.apache.org/repos/asf/isis/commit/4966f591
Tree: http://git-wip-us.apache.org/repos/asf/isis/tree/4966f591
Diff: http://git-wip-us.apache.org/repos/asf/isis/diff/4966f591

Branch: refs/heads/master
Commit: 4966f591cff1eeb620ccc71f732f4b3d31813ed8
Parents: 9b41e11
Author: Dan Haywood <[email protected]>
Authored: Tue May 2 07:22:15 2017 +0200
Committer: Dan Haywood <[email protected]>
Committed: Tue May 2 07:22:15 2017 +0200

----------------------------------------------------------------------
 .../ui/components/bookmarkedpages/BookmarkedPagesPanel.html   | 6 +++---
 .../isis/viewer/wicket/ui/components/footer/FooterPanel.html  | 6 ++++--
 .../ui/components/widgets/breadcrumbs/BreadcrumbPanel.html    | 2 +-
 .../ui/components/widgets/themepicker/ThemeChooser.html       | 7 +++++--
 4 files changed, 13 insertions(+), 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/isis/blob/4966f591/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/bookmarkedpages/BookmarkedPagesPanel.html
----------------------------------------------------------------------
diff --git 
a/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/bookmarkedpages/BookmarkedPagesPanel.html
 
b/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/bookmarkedpages/BookmarkedPagesPanel.html
index 8df8ad7..98a5be6 100644
--- 
a/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/bookmarkedpages/BookmarkedPagesPanel.html
+++ 
b/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/bookmarkedpages/BookmarkedPagesPanel.html
@@ -44,14 +44,14 @@
                                             <ul wicket:id="bookmarkList" 
class="bookmarkedPagesList list-group">
                                                 <li 
wicket:id="bookmarkedPageItem" class="bookmarkedPageItem list-group-item">
                                                     <div>
-                                                        <a href="#" 
wicket:id="bookmarkedPageLink">
+                                                        <a href="#" 
tabindex="-1" wicket:id="bookmarkedPageLink">
                                                             <div 
class="bookmarkedPageImageAndTitle" style="display: inline-block">
                                                                 <img 
wicket:id="bookmarkedPageImage" class="bookmarkedPageImage"/>
                                                                 <span 
wicket:id="bookmarkedPageTitle" class="bookmarkedPageTitle">[link title]</span>
                                                             </div>
                                                         </a>
 
-                                                        <a href="#" 
wicket:id="clearBookmarkLink" class="clearBookmarkPlaceHolder pull-right">
+                                                        <a href="#" 
tabindex="-1" wicket:id="clearBookmarkLink" class="clearBookmarkPlaceHolder 
pull-right">
                                                             <span class="fa 
fa-fw fa-ban text-danger"></span>
                                                         </a>
                                                     </div>
@@ -62,7 +62,7 @@
 
                                     <div class="panel-footer" 
wicket:enclosure="clearBookmarks">
                                         <span>&nbsp;</span>
-                                        <a href="#" wicket:id="clearBookmarks" 
class="clearBookmarksA btn-link pull-right" title="Clear Bookmarks">
+                                        <a href="#" tabindex="-1" 
wicket:id="clearBookmarks" class="clearBookmarksA btn-link pull-right" 
title="Clear Bookmarks">
                                             <span class="text-danger">Clear 
all</span>
                                         </a>
                                     </div>

http://git-wip-us.apache.org/repos/asf/isis/blob/4966f591/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/footer/FooterPanel.html
----------------------------------------------------------------------
diff --git 
a/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/footer/FooterPanel.html
 
b/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/footer/FooterPanel.html
index f23a025..c06f5b5 100644
--- 
a/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/footer/FooterPanel.html
+++ 
b/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/footer/FooterPanel.html
@@ -43,9 +43,11 @@
                     </ul>
                     <ul class="nav navbar-nav navbar-right">
                         <p class="navbar-text powered-by">Powered by:</p>
-                        <li><a href="http://isis.apache.org"; 
target="_blank">Apache Isis &#8482;</a></li>
                         <li>
-                            <a wicket:id="aboutLink" id="aboutLink" 
class="navbar-right">
+                            <a href="http://isis.apache.org"; tabindex="-1" 
target="_blank">Apache Isis &#8482;</a>
+                        </li>
+                        <li>
+                            <a wicket:id="aboutLink" tabindex="-1" 
id="aboutLink" class="navbar-right">
                                 <span wicket:id="aboutMessage">About</span>
                                 <i wicket:id="devModeWarning" class="fa fa-lg 
fa-warning text-danger" title="Running in Prototype (Development) mode!"/>
                             </a>

http://git-wip-us.apache.org/repos/asf/isis/blob/4966f591/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/breadcrumbs/BreadcrumbPanel.html
----------------------------------------------------------------------
diff --git 
a/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/breadcrumbs/BreadcrumbPanel.html
 
b/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/breadcrumbs/BreadcrumbPanel.html
index 83824a1..16ed04b 100644
--- 
a/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/breadcrumbs/BreadcrumbPanel.html
+++ 
b/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/breadcrumbs/BreadcrumbPanel.html
@@ -21,7 +21,7 @@
     <body>
         <wicket:panel>
             <span class="breadcrumbPanel">
-                <select wicket:id="breadcrumbs" class="autoComplete 
form-control select2-remote" style="width: 100%"></select>
+                <select tabindex="-1" wicket:id="breadcrumbs" 
class="autoComplete form-control select2-remote" style="width: 100%"></select>
 <!--
                 <input wicket:id="breadcrumbs" type="hidden" 
class="autoComplete select2-remote" style="width: 100%; padding: 0" />
 -->

http://git-wip-us.apache.org/repos/asf/isis/blob/4966f591/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/themepicker/ThemeChooser.html
----------------------------------------------------------------------
diff --git 
a/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/themepicker/ThemeChooser.html
 
b/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/themepicker/ThemeChooser.html
index 564851d..5434a8a 100644
--- 
a/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/themepicker/ThemeChooser.html
+++ 
b/core/viewer-wicket-ui/src/main/java/org/apache/isis/viewer/wicket/ui/components/widgets/themepicker/ThemeChooser.html
@@ -21,9 +21,12 @@
 <html xmlns:wicket="http://wicket.apache.org";>
     <body>
         <wicket:panel>
-            <a href="#" class="dropdown-toggle" data-toggle="dropdown">Change 
theme <span class="caret"></span></a>
+            <a href="#" tabindex="-1" class="dropdown-toggle" 
data-toggle="dropdown">Change theme <span class="caret"></span></a>
             <ul class="dropdown-menu" role="menu">
-                <li wicket:id="themes"><a wicket:id="themeLink"></a></li>
+                <li wicket:id="themes">
+                    <a tabindex="-1" wicket:id="themeLink">
+
+                    </a></li>
             </ul>
         </wicket:panel>
     </body>

Reply via email to