This is an automated email from the ASF dual-hosted git repository. danhaywood pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/isis.git.
from 3a9dd8a ISIS-2188: cosmetic change for FixtureResult layout new 949a3bb ISIS-2148: fixes site.yml, accidentally committed with incorrect antora ui bundle new cdd4077 ISIS-2158: fixes sign-in page, which showed bad img link if no image was configured new e8d374d ISIS-2195: adds further short-circuit when loading actions new f2feee1 ISIS-2196: removes facet factories that look for static methods new 11daa74 ISIS-2196: now ignores static methods during introspection new a35521c ISIS-2196: removes duplication by introducing MethodUtil.isPublic(...) new a3cbd17 ISIS-2199: reinstates code that had been commented out. The 7 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Summary of changes: .../isis/viewer/wicket/ui/WebAppConfiguration.java | 2 +- .../apache/isis/metamodel/commons/MethodUtil.java | 59 ++++++------ .../isis/metamodel/facetapi/MethodRemover.java | 14 +-- .../apache/isis/metamodel/facets/Annotations.java | 6 +- .../apache/isis/metamodel/facets/FacetFactory.java | 17 ++-- .../isis/metamodel/facets/MethodFinderUtils.java | 98 ++++++-------------- .../MethodPrefixBasedFacetFactoryAbstract.java | 103 ++++++++++----------- .../metamodel/facets/MethodRemoverConstants.java | 5 +- .../ActionDefaultsFacetViaMethodFactory.java | 3 +- .../ActionValidationFacetViaMethodFactory.java | 11 +-- .../CollectionAccessorFacetViaAccessorFactory.java | 2 - .../clear/CollectionClearFacetFactory.java | 3 +- ...tionAddToRemoveFromAndValidateFacetFactory.java | 9 +- .../metamodel/facets/jaxb/JaxbFacetFactory.java | 6 +- .../forsession/DisableForSessionFacet.java | 40 -------- .../forsession/DisableForSessionFacetAbstract.java | 44 --------- .../forsession/DisableForSessionFacetNone.java | 42 --------- .../DisableForSessionFacetViaMethod.java | 83 ----------------- .../DisableForSessionFacetViaMethodFactory.java | 82 ---------------- .../DisableForContextFacetViaMethodFactory.java | 5 +- .../hidden/forsession/HideForSessionFacet.java | 37 -------- .../forsession/HideForSessionFacetAbstract.java | 50 ---------- .../hidden/forsession/HideForSessionFacetNone.java | 45 --------- .../forsession/HideForSessionFacetViaMethod.java | 84 ----------------- .../HideForSessionFacetViaMethodFactory.java | 79 ---------------- .../HideForContextFacetViaMethodFactory.java | 5 +- .../callbacks/CreatedCallbackFacetFactory.java | 3 +- .../object/callbacks/LoadCallbackFacetFactory.java | 5 +- .../callbacks/PersistCallbackFacetFactory.java | 5 +- .../PersistCallbackViaSaveMethodFacetFactory.java | 5 +- .../callbacks/RemoveCallbackFacetFactory.java | 5 +- .../RemoveCallbackViaDeleteMethodFacetFactory.java | 5 +- .../callbacks/UpdateCallbackFacetFactory.java | 5 +- .../choices/enums/EnumValueSemanticsProvider.java | 4 +- .../method/CssClassFacetMethodFactory.java | 3 +- .../DisabledObjectFacetViaMethodFactory.java | 3 +- .../method/HiddenObjectFacetViaMethodFactory.java | 3 +- .../object/icon/method/IconFacetMethodFactory.java | 3 +- ...oveDatanucleusPersistableTypesFacetFactory.java | 3 +- .../RemoveStaticGettersAndSettersFacetFactory.java | 43 --------- .../javalang/IteratorFilteringFacetFactory.java | 3 +- .../ignore/javalang/RemoveMethodsFacetFactory.java | 5 +- .../jdo/RemoveJdoEnhancementTypesFacetFactory.java | 3 +- .../facets/object/layout/LayoutFacetFactory.java | 3 +- .../annotation/TitleAnnotationFacetFactory.java | 5 +- .../title/methods/TitleFacetViaMethodsFactory.java | 5 +- .../method/ValidateObjectFacetMethodFactory.java | 3 +- ...ParameterAutoCompleteFacetViaMethodFactory.java | 6 +- .../method/ActionChoicesFacetViaMethodFactory.java | 5 +- ...ctionParameterChoicesFacetViaMethodFactory.java | 3 +- ...tionParameterDefaultsFacetViaMethodFactory.java | 6 +- ...tionParameterDisabledFacetViaMethodFactory.java | 8 +- ...ActionParameterHiddenFacetViaMethodFactory.java | 8 +- ...onParameterValidationFacetViaMethodFactory.java | 8 +- .../PropertyAccessorFacetViaAccessorFactory.java | 3 +- .../PropertyAutoCompleteFacetMethodFactory.java | 3 +- .../PropertyChoicesFacetViaMethodFactory.java | 3 +- .../PropertyDefaultFacetViaMethodFactory.java | 3 +- .../update/PropertyModifyFacetFactory.java | 3 +- .../update/PropertySetAndClearFacetFactory.java | 5 +- .../PropertyValidateFacetViaMethodFactory.java | 3 +- .../isis/metamodel/methodutils/MethodScope.java | 57 ------------ .../dflt/ProgrammingModelFacetsJava8.java | 14 +-- .../metamodel/specloader/SpecificationLoader.java | 14 ++- .../specloader/SpecificationLoaderDefault.java | 15 +++ .../specloader/specimpl/FacetedMethodsBuilder.java | 61 ++++-------- .../metamodel/facets/MethodRemoverForTesting.java | 20 +--- .../actions/ActionMethodsFacetFactoryTest.java | 95 +------------------ .../CollectionFieldMethodsFacetFactoryTest.java | 86 +---------------- .../PropertyMethodsFacetFactoryTest.java | 102 +------------------- .../runtime/system/ObjectMemberAbstractTest.java | 60 ++---------- .../isis/runtime/system/MethodFinderUtilsTest.java | 88 ------------------ .../ui/components/widgets/navbar/BrandLogo.java | 1 + .../wicket/ui/pages/login/IsisSignInPanel.java | 1 + .../SupportingMethodValidatorRefinerFactory.java | 4 +- site.yml | 4 +- 76 files changed, 258 insertions(+), 1487 deletions(-) delete mode 100644 core/metamodel/src/main/java/org/apache/isis/metamodel/facets/members/disabled/forsession/DisableForSessionFacet.java delete mode 100644 core/metamodel/src/main/java/org/apache/isis/metamodel/facets/members/disabled/forsession/DisableForSessionFacetAbstract.java delete mode 100644 core/metamodel/src/main/java/org/apache/isis/metamodel/facets/members/disabled/forsession/DisableForSessionFacetNone.java delete mode 100644 core/metamodel/src/main/java/org/apache/isis/metamodel/facets/members/disabled/forsession/DisableForSessionFacetViaMethod.java delete mode 100644 core/metamodel/src/main/java/org/apache/isis/metamodel/facets/members/disabled/forsession/DisableForSessionFacetViaMethodFactory.java delete mode 100644 core/metamodel/src/main/java/org/apache/isis/metamodel/facets/members/hidden/forsession/HideForSessionFacet.java delete mode 100644 core/metamodel/src/main/java/org/apache/isis/metamodel/facets/members/hidden/forsession/HideForSessionFacetAbstract.java delete mode 100644 core/metamodel/src/main/java/org/apache/isis/metamodel/facets/members/hidden/forsession/HideForSessionFacetNone.java delete mode 100644 core/metamodel/src/main/java/org/apache/isis/metamodel/facets/members/hidden/forsession/HideForSessionFacetViaMethod.java delete mode 100644 core/metamodel/src/main/java/org/apache/isis/metamodel/facets/members/hidden/forsession/HideForSessionFacetViaMethodFactory.java delete mode 100644 core/metamodel/src/main/java/org/apache/isis/metamodel/facets/object/ignore/isis/RemoveStaticGettersAndSettersFacetFactory.java delete mode 100644 core/metamodel/src/main/java/org/apache/isis/metamodel/methodutils/MethodScope.java delete mode 100644 core/runtime/src/test/java/org/apache/isis/runtime/system/MethodFinderUtilsTest.java