This is an automated email from the ASF dual-hosted git repository. danhaywood pushed a commit to branch release-2.0.0-M7-RC1 in repository https://gitbox.apache.org/repos/asf/isis.git
commit 3cc1e215b85971a33a72c027a7d41224d6c1baf3 Author: Dan Haywood <[email protected]> AuthorDate: Sat Feb 12 15:37:49 2022 +0000 ISIS-2859: removes defunct docs re: toolchain plugin --- .../modules/ROOT/pages/building-apache-isis.adoc | 58 +++++++++++----------- 1 file changed, 30 insertions(+), 28 deletions(-) diff --git a/antora/components/conguide/modules/ROOT/pages/building-apache-isis.adoc b/antora/components/conguide/modules/ROOT/pages/building-apache-isis.adoc index a1fec6f..c2fd2e4 100644 --- a/antora/components/conguide/modules/ROOT/pages/building-apache-isis.adoc +++ b/antora/components/conguide/modules/ROOT/pages/building-apache-isis.adoc @@ -140,34 +140,36 @@ Note that the JRE is _not_ sufficient. If you intend to contribute back patches to Apache Isis, note that while you can develop using Java 11 or above within your IDE, be sure not to use any APIs more recent than Java 11. ==== -=== Configure Maven toolchains plugin - -If you are a committer that will be performing releases of Apache Isis, then you _must_ configure the -link:http://maven.apache.org/plugins/maven-toolchains-plugin/[toolchains] plugin so that releases can be built using Java 11. - -This is done by placing the `toolchains.xml` file in `~/.m2` directory. -Use the following file as a template, adjusting paths for your platform: - -[source,xml] ----- -<?xml version="1.0" encoding="UTF8"?> -<toolchains> - <toolchain> - <type>jdk</type> - <provides> - <version>1.8</version> <!--.--> - <vendor>openjdk</vendor> - </provides> - <configuration> - <jdkHome>C:\Program Files\OpenJDK\openjdk-8u262-b10</jdkHome> <!--.--> - </configuration> - </toolchain> -</toolchains> ----- -<.> The Apache Isis build is configured to search for the (`1.8, openjdk`) JDK toolchain. -<.> adjust as necessary - -The Apache Isis parent `pom.xml` activates this plugin whenever the `apache-release` profile is enabled. +// no longer required, I believe. +// +//=== Configure Maven toolchains plugin +// +//If you are a committer that will be performing releases of Apache Isis, then you _must_ configure the +//link:http://maven.apache.org/plugins/maven-toolchains-plugin/[toolchains] plugin so that releases can be built using Java 11. +// +//This is done by placing the `toolchains.xml` file in `~/.m2` directory. +//Use the following file as a template, adjusting paths for your platform: +// +//[source,xml] +//---- +//<?xml version="1.0" encoding="UTF8"?> +//<toolchains> +// <toolchain> +// <type>jdk</type> +// <provides> +// <version>1.8</version> <!--.--> +// <vendor>openjdk</vendor> +// </provides> +// <configuration> +// <jdkHome>C:\Program Files\OpenJDK\openjdk-8u262-b10</jdkHome> <!--.--> +// </configuration> +// </toolchain> +//</toolchains> +//---- +//<.> The Apache Isis build is configured to search for the (`1.8, openjdk`) JDK toolchain. +//<.> adjust as necessary +// +//The Apache Isis parent `pom.xml` activates this plugin whenever the `apache-release` profile is enabled. == Installing Maven
