[isis] branch master updated: ISIS-3049: remove superfluous DateTimeFormatterBuilder options

[ahuber]

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git


The following commit(s) were added to refs/heads/master by this push:
     new 9ffa9b74ee ISIS-3049: remove superfluous DateTimeFormatterBuilder 
options
9ffa9b74ee is described below

commit 9ffa9b74eebd215ce54c735cc7fdf50f164a67cb
Author: Andi Huber <ahu...@apache.org>
AuthorDate: Wed Jul 13 14:15:48 2022 +0200

    ISIS-3049: remove superfluous DateTimeFormatterBuilder options
---
 .../isis/applib/value/semantics/ValueSemanticsAbstract.java   |  2 --
 .../java/org/apache/isis/commons/internal/base/_Strings.java  | 11 +++++++----
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git 
a/api/applib/src/main/java/org/apache/isis/applib/value/semantics/ValueSemanticsAbstract.java
 
b/api/applib/src/main/java/org/apache/isis/applib/value/semantics/ValueSemanticsAbstract.java
index 61346307bc..5b4c6b68e8 100644
--- 
a/api/applib/src/main/java/org/apache/isis/applib/value/semantics/ValueSemanticsAbstract.java
+++ 
b/api/applib/src/main/java/org/apache/isis/applib/value/semantics/ValueSemanticsAbstract.java
@@ -308,8 +308,6 @@ implements
                 .appendPattern(editingPattern
                         .getEditingFormatAsPattern(
                                 temporalCharacteristic, offsetCharacteristic, 
timePrecision, direction))
-                .parseLenient()
-                .parseCaseInsensitive()
                 .toFormatter(getUserLocale(context).getTimeFormatLocale());
     }
 
diff --git 
a/commons/src/main/java/org/apache/isis/commons/internal/base/_Strings.java 
b/commons/src/main/java/org/apache/isis/commons/internal/base/_Strings.java
index e23022ce3f..c73952e5fb 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/base/_Strings.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/base/_Strings.java
@@ -438,14 +438,17 @@ public final class _Strings {
         }
         final int maxIndex = str.length()-1; // >= 0
 
-        final int i1 = endIndex<0
-                ? str.length() + endIndex
-                : endIndex;
-
         final int i0 = beginIndex>0
                 ? Math.min(beginIndex, maxIndex)
                 : 0;
 
+        final int i1 = Math.min(
+                maxIndex+1,
+                endIndex<0
+                    ? str.length() + endIndex
+                    : endIndex
+                );
+
         return i0<i1
                 ? str.substring(i0, i1)
                 : "";