This is an automated email from the ASF dual-hosted git repository.
ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git
The following commit(s) were added to refs/heads/master by this push:
new ce1e1b2634 ISIS-3049: minor: just comments
ce1e1b2634 is described below
commit ce1e1b26341e21e341b2bbe448656c1bc385d554
Author: Andi Huber <[email protected]>
AuthorDate: Wed Jul 13 20:27:53 2022 +0200
ISIS-3049: minor: just comments
---
.../apache/isis/applib/value/semantics/TemporalValueSemantics.java | 1 +
.../main/java/org/apache/isis/commons/internal/base/_Strings.java | 5 +++--
.../java/org/apache/isis/testdomain/value/ValueSemanticsTest.java | 5 +----
3 files changed, 5 insertions(+), 6 deletions(-)
diff --git
a/api/applib/src/main/java/org/apache/isis/applib/value/semantics/TemporalValueSemantics.java
b/api/applib/src/main/java/org/apache/isis/applib/value/semantics/TemporalValueSemantics.java
index dec2c29529..98f9da39b9 100644
---
a/api/applib/src/main/java/org/apache/isis/applib/value/semantics/TemporalValueSemantics.java
+++
b/api/applib/src/main/java/org/apache/isis/applib/value/semantics/TemporalValueSemantics.java
@@ -179,6 +179,7 @@ extends
* @apiNote Yet only tested with {@literal XXX}, as there needs to be
a format correspondence with
* <i>momentJs</i> supported formats for the <i>tempus-dominus</i>
date/time-picker to work
* (as used by the <i>Wicket Viewer</i>).
+ * {@link
org.apache.isis.viewer.wicket.ui.components.scalars.datepicker._TimeFormatUtil}
does the format conversion.
*/
@NotNull @NotEmpty
private String zonePatternForOutput = "XXX";
diff --git
a/commons/src/main/java/org/apache/isis/commons/internal/base/_Strings.java
b/commons/src/main/java/org/apache/isis/commons/internal/base/_Strings.java
index c73952e5fb..eb8ef7fa7b 100644
--- a/commons/src/main/java/org/apache/isis/commons/internal/base/_Strings.java
+++ b/commons/src/main/java/org/apache/isis/commons/internal/base/_Strings.java
@@ -426,11 +426,12 @@ public final class _Strings {
}
/**
- * Returns a string that is a substring of this string.
+ * Returns a string that is a substring of given {@code str}.
* The substring begins at the specified beginIndex and extends to the
character at index endIndex - 1.
* Thus the length of the substring is endIndex-beginIndex.
* <p>
- * Supports negative endIndex, as well as index overflow.
+ * Supports negative {@code endIndex}, as well as index overflow.
+ * If the endIndex is negative, it is understood as being relative to the
end of the given {@code str}.
*/
public static String substring(final @Nullable String str, final int
beginIndex, final int endIndex) {
if(isEmpty(str)) {
diff --git
a/regressiontests/stable-value/src/test/java/org/apache/isis/testdomain/value/ValueSemanticsTest.java
b/regressiontests/stable-value/src/test/java/org/apache/isis/testdomain/value/ValueSemanticsTest.java
index 648490e3c1..9dd971fdd4 100644
---
a/regressiontests/stable-value/src/test/java/org/apache/isis/testdomain/value/ValueSemanticsTest.java
+++
b/regressiontests/stable-value/src/test/java/org/apache/isis/testdomain/value/ValueSemanticsTest.java
@@ -253,15 +253,12 @@ class ValueSemanticsTest {
|| valueType.equals(OffsetTime.class)
|| valueType.equals(ZonedDateTime.class)) {
- System.err.printf("DEBUG: stringified: %s%n",
stringified);
-
if(!stringified.contains("+")) {
+ //TODO debug yeah thats because time-zone
might be zero on CI run .. 'Z', but why?
System.err.printf("DEBUG: invalid
stringified: %s%n", stringified);
return;
}
- /* fails on CI !? ... */
-
val with4digitZone =
_Strings.substring(stringified, 0, -6) + "+0200";
val with2digitZone =
_Strings.substring(stringified, 0, -6) + "+02";
