[isis] branch master updated: ISIS-3103: minor: just comments

[ahuber]

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git


The following commit(s) were added to refs/heads/master by this push:
     new cfa7b47d66 ISIS-3103: minor: just comments
cfa7b47d66 is described below

commit cfa7b47d66857b24d8470a71a62c3423a95ddb84
Author: Andi Huber <ahu...@apache.org>
AuthorDate: Tue Aug 2 07:29:11 2022 +0200

    ISIS-3103: minor: just comments
---
 .../org/apache/isis/applib/services/bookmark/IdStringifier.java   | 2 +-
 .../services/bookmark/idstringifiers/PredefinedSerializables.java | 8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git 
a/api/applib/src/main/java/org/apache/isis/applib/services/bookmark/IdStringifier.java
 
b/api/applib/src/main/java/org/apache/isis/applib/services/bookmark/IdStringifier.java
index e097d01695..6223e0accf 100644
--- 
a/api/applib/src/main/java/org/apache/isis/applib/services/bookmark/IdStringifier.java
+++ 
b/api/applib/src/main/java/org/apache/isis/applib/services/bookmark/IdStringifier.java
@@ -26,7 +26,7 @@ import lombok.NonNull;
 import lombok.val;
 
 /**
- * SPI to converts the identifier (primary key) of an entity, of a given type 
(eg Integer) into a string, and
+ * SPI to convert the identifier (primary key) of an entity, of a given type 
(eg Integer) into a string, and
  * to convert back again into the key object used to actually look up the 
target entity instance; supported by both JDO
  * and JPA persistence mechanisms.
  *
diff --git 
a/api/applib/src/main/java/org/apache/isis/applib/services/bookmark/idstringifiers/PredefinedSerializables.java
 
b/api/applib/src/main/java/org/apache/isis/applib/services/bookmark/idstringifiers/PredefinedSerializables.java
index 41c40f96bf..b42663a975 100644
--- 
a/api/applib/src/main/java/org/apache/isis/applib/services/bookmark/idstringifiers/PredefinedSerializables.java
+++ 
b/api/applib/src/main/java/org/apache/isis/applib/services/bookmark/idstringifiers/PredefinedSerializables.java
@@ -31,6 +31,14 @@ import lombok.experimental.UtilityClass;
 @UtilityClass
 public class PredefinedSerializables {
 
+    /**
+     * Whether given {@code cls} can be serialized ad-hoc,
+     * which usually is true for simple value types,
+     * but not per-se for domain object's (entities and viewmodels)
+     * even if {@link Serializable}.
+     * For the latter a more sophisticated - {@link Bookmark}
+     * based - mechanism is required instead.
+     */
     public boolean isPredefinedSerializable(final Class<?> cls) {
         if(!Serializable.class.isAssignableFrom(cls)) {
             return false;