[isis] branch master updated: ISIS-3116: demo: fixes missing 'name' column when rendering List

[ahuber]

This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git


The following commit(s) were added to refs/heads/master by this push:
     new 0b6b69d07d ISIS-3116: demo: fixes missing 'name' column when rendering 
List<? extends NumberConstantEntity>
0b6b69d07d is described below

commit 0b6b69d07d1382b6d31d23350ce4e85c06760d53
Author: Andi Huber <ahu...@apache.org>
AuthorDate: Wed Aug 10 09:38:22 2022 +0200

    ISIS-3116: demo: fixes missing 'name' column when rendering List<?
    extends NumberConstantEntity>
---
 .../main/java/org/apache/isis/core/config/IsisConfiguration.java    | 6 ++----
 .../objects/other/embedded/persistence/NumberConstantEntity.java    | 5 +++++
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git 
a/core/config/src/main/java/org/apache/isis/core/config/IsisConfiguration.java 
b/core/config/src/main/java/org/apache/isis/core/config/IsisConfiguration.java
index 3052f42b97..f9248d9209 100644
--- 
a/core/config/src/main/java/org/apache/isis/core/config/IsisConfiguration.java
+++ 
b/core/config/src/main/java/org/apache/isis/core/config/IsisConfiguration.java
@@ -68,8 +68,6 @@ import org.apache.isis.applib.services.userui.UserMenu;
 import 
org.apache.isis.applib.value.semantics.TemporalValueSemantics.TemporalEditingPattern;
 import org.apache.isis.commons.internal.base._NullSafe;
 import org.apache.isis.commons.internal.context._Context;
-import org.apache.isis.core.config.IsisConfiguration.Core;
-import org.apache.isis.core.config.IsisConfiguration.Viewer;
 import org.apache.isis.core.config.metamodel.facets.DefaultViewConfiguration;
 import 
org.apache.isis.core.config.metamodel.facets.EditingObjectsConfiguration;
 import 
org.apache.isis.core.config.metamodel.facets.PublishingPolicies.ActionPublishingPolicy;
@@ -1943,11 +1941,11 @@ public class IsisConfiguration {
              */
             private int maxTitleLengthInTables = 12;
 
-            private static boolean isValidTitleLenght(final int len) {
+            private static boolean isMaxTitleLenghtValid(final int len) {
                 return len>=0;
             }
             private int asTitleLenght(final int len) {
-                return isValidTitleLenght(len)
+                return isMaxTitleLenghtValid(len)
                         ? len
                         : getMaxTitleLengthInTables();
             }
diff --git 
a/examples/demo/domain/src/main/java/demoapp/dom/domain/objects/other/embedded/persistence/NumberConstantEntity.java
 
b/examples/demo/domain/src/main/java/demoapp/dom/domain/objects/other/embedded/persistence/NumberConstantEntity.java
index 0a48f4f898..366f1e8825 100644
--- 
a/examples/demo/domain/src/main/java/demoapp/dom/domain/objects/other/embedded/persistence/NumberConstantEntity.java
+++ 
b/examples/demo/domain/src/main/java/demoapp/dom/domain/objects/other/embedded/persistence/NumberConstantEntity.java
@@ -21,6 +21,7 @@ package demoapp.dom.domain.objects.other.embedded.persistence;
 import javax.inject.Named;
 
 import org.apache.isis.applib.annotation.DomainObject;
+import org.apache.isis.applib.annotation.Property;
 
 import demoapp.dom._infra.asciidocdesc.HasAsciiDocDescription;
 import demoapp.dom._infra.values.ValueHolder;
@@ -33,4 +34,8 @@ implements
     HasAsciiDocDescription,
     ValueHolder<ComplexNumber> {
 
+    // enables the 'name' column when rendering List<? extends 
NumberConstantEntity>
+    @Property
+    public abstract String getName();
+
 }