This is an automated email from the ASF dual-hosted git repository. ahuber pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/isis.git
commit acf914a6ed40e907685e10cc6dac4d5432da6401 Merge: 1011449029 6e42534572 Author: Andi Huber <[email protected]> AuthorDate: Sat Sep 3 06:27:18 2022 +0200 Merge pull request #1078 from apache/3200_broken-value-choices ISIS-3200: broken Value Choices .../isis/applib/services/bookmark/Bookmark.java | 17 +- .../applib/services/bookmark/BookmarkHolder.java | 2 +- .../applib/services/repository/EntityState.java | 11 +- ...os_MementoDefault.java => _MementoDefault.java} | 8 +- .../isis/commons/internal/memento/_Mementos.java | 4 +- .../images/managed-object-diagram.drawio.svg | 2 +- .../_testing/ObjectMementoService_forTesting.java | 7 +- .../facets/object/callbacks/CallbackFacet.java | 1 - .../facets/object/entity/EntityFacet.java | 36 ++ .../facets/object/value/ValueFacetAbstract.java | 10 +- .../facets/object/value/ValueSerializer.java | 9 +- .../object/value/ValueSerializerDefault.java | 32 +- .../object/viewmodel/ViewModelFacetAbstract.java | 4 +- .../isis/core/metamodel/object/ManagedObject.java | 14 +- .../isis/core/metamodel/object/ManagedObjects.java | 12 +- .../core/metamodel/object/MmAssertionUtil.java | 14 + .../object/_ManagedObjectEntityHybrid.java | 103 +++- .../metamodel/object/_ManagedObjectService.java | 4 +- .../core/metamodel/object/_ManagedObjectValue.java | 9 +- .../metamodel/object/_ManagedObjectViewmodel.java | 2 +- .../metamodel/objectmanager/ObjectManager.java | 27 +- .../objectmanager/identify/ObjectBookmarker.java | 25 +- .../identify/ObjectBookmarker_builtinHandlers.java | 79 ++- .../load/ObjectLoader_builtinHandlers.java | 16 +- .../objectmanager/memento/ObjectMemento.java | 26 + .../memento/ObjectMementoCollection.java | 2 +- .../memento/ObjectMementoForEmpty.java | 2 +- .../memento/ObjectMementoService.java | 11 +- .../objectlifecycle/ObjectLifecyclePublisher.java | 6 +- .../HasObjectSpecification.java} | 44 +- .../core/metamodel/util/snapshot/XmlSnapshot.java | 26 +- .../value/JavaTimeValueSemanticsProviderTest.java | 11 +- .../ValueSemanticsProviderAbstractTestCase.java | 41 +- .../isis/core/runtime/IsisModuleCoreRuntime.java | 4 +- ...ervice.java => IdStringifierLookupService.java} | 42 +- .../bookmarks/BookmarkServiceDefault.java | 10 +- .../command/CommandDtoFactoryDefault.java | 4 +- .../interaction/InteractionDtoFactoryDefault.java | 11 +- .../memento/ObjectMementoServiceDefault.java | 75 +-- .../runtimeservices/memento/_ObjectMemento.java | 608 --------------------- .../memento/_ObjectMementoForScalar.java | 171 ++++++ .../core/runtimeservices/memento/_Recreatable.java | 74 +++ .../memento/_RecreatableLookup.java | 59 ++ .../memento/_RecreatableSerializable.java | 54 ++ .../runtimeservices/memento/_RecreatableValue.java | 59 ++ .../publish/LifecycleCallbackNotifier.java | 35 +- .../publish/ObjectLifecyclePublisherDefault.java | 5 +- .../DelegatingInvocationHandlerDefault.java | 9 +- .../handlers/DomainObjectInvocationHandler.java | 7 + .../integtest/CommandLog_IntegTestAbstract.java | 1 - .../integtest/ExecutionLog_IntegTestAbstract.java | 6 +- .../changetracking/JdoLifecycleListener.java | 14 +- .../entities/DnEntityStateProvider.java | 8 +- .../metamodel/facets/entity/JdoEntityFacet.java | 46 +- .../jpa/applib/integration/IsisEntityListener.java | 19 +- .../jpa/integration/entity/JpaEntityFacet.java | 32 +- .../integration/entity/JpaEntityFacetFactory.java | 2 +- .../testdomain/rest/DomainObjectResourceTest.java | 4 +- .../applib/IsisIntegrationTestAbstract.java | 12 +- .../JsonValueEncoderServiceDefault.java | 4 +- .../wicket/model/models/ManagedObjectModel.java | 7 +- .../models/interaction/BookmarkedObjectWkt.java | 6 +- .../wicket/model/util/PageParameterUtils.java | 20 +- .../select2/providers/ChoiceProviderAbstract.java | 11 +- .../ChoiceProviderAbstractForScalarModel.java | 16 - .../integration/ConverterForObjectAdapter.java | 23 +- .../ConverterForObjectAdapterMemento.java | 40 +- .../viewer/wicketapp/IsisWicketApplication.java | 2 +- 68 files changed, 1003 insertions(+), 1114 deletions(-)
