This is an automated email from the ASF dual-hosted git repository.

ahuber pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/isis.git


The following commit(s) were added to refs/heads/master by this push:
     new 7c89aca078 ISIS-3274: fixes MarkupComponentFactory to be Serializable
7c89aca078 is described below

commit 7c89aca078d5acfb99d7a703c2b8b6ec17471c63
Author: Andi Huber <[email protected]>
AuthorDate: Wed Nov 9 08:24:38 2022 +0100

    ISIS-3274: fixes MarkupComponentFactory to be Serializable
---
 .../wicket/ui/components/scalars/markup/MarkupComponentFactory.java  | 4 +++-
 .../wicket/ui/components/scalars/markup/ScalarMarkupPanel.java       | 5 ++---
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git 
a/viewers/wicket/ui/src/main/java/org/apache/causeway/viewer/wicket/ui/components/scalars/markup/MarkupComponentFactory.java
 
b/viewers/wicket/ui/src/main/java/org/apache/causeway/viewer/wicket/ui/components/scalars/markup/MarkupComponentFactory.java
index c61b5cca13..f41912e0f8 100644
--- 
a/viewers/wicket/ui/src/main/java/org/apache/causeway/viewer/wicket/ui/components/scalars/markup/MarkupComponentFactory.java
+++ 
b/viewers/wicket/ui/src/main/java/org/apache/causeway/viewer/wicket/ui/components/scalars/markup/MarkupComponentFactory.java
@@ -18,10 +18,12 @@
  */
 package org.apache.causeway.viewer.wicket.ui.components.scalars.markup;
 
+import java.io.Serializable;
+
 import org.apache.wicket.model.IModel;
 
 @FunctionalInterface
-public interface MarkupComponentFactory<T extends IModel<?>> {
+public interface MarkupComponentFactory<T extends IModel<?>> extends 
Serializable {
 
     MarkupComponent newMarkupComponent(String id, T model);
 
diff --git 
a/viewers/wicket/ui/src/main/java/org/apache/causeway/viewer/wicket/ui/components/scalars/markup/ScalarMarkupPanel.java
 
b/viewers/wicket/ui/src/main/java/org/apache/causeway/viewer/wicket/ui/components/scalars/markup/ScalarMarkupPanel.java
index d593413558..da2043fd55 100644
--- 
a/viewers/wicket/ui/src/main/java/org/apache/causeway/viewer/wicket/ui/components/scalars/markup/ScalarMarkupPanel.java
+++ 
b/viewers/wicket/ui/src/main/java/org/apache/causeway/viewer/wicket/ui/components/scalars/markup/ScalarMarkupPanel.java
@@ -23,7 +23,6 @@ import java.util.EnumSet;
 import org.apache.wicket.Component;
 
 import org.apache.causeway.viewer.wicket.model.models.ScalarModel;
-import 
org.apache.causeway.viewer.wicket.ui.components.scalars.ScalarPanelAbstract.FormatModifier;
 import 
org.apache.causeway.viewer.wicket.ui.components.scalars.ScalarPanelTextFieldWithValueSemantics;
 
 /**
@@ -33,14 +32,13 @@ public class ScalarMarkupPanel<T>
 extends ScalarPanelTextFieldWithValueSemantics<T> {
 
     private static final long serialVersionUID = 1L;
-    private final transient MarkupComponentFactory<ScalarModel> 
markupComponentFactory;
+    private final MarkupComponentFactory<ScalarModel> markupComponentFactory; 
// serializable!
 
     public ScalarMarkupPanel(
             final String id,
             final ScalarModel scalarModel,
             final Class<T> valueType,
             final MarkupComponentFactory<ScalarModel> markupComponentFactory) {
-
         super(id, scalarModel, valueType);
         this.markupComponentFactory = markupComponentFactory;
     }
@@ -59,4 +57,5 @@ extends ScalarPanelTextFieldWithValueSemantics<T> {
     protected final MarkupComponent createMarkupComponent(final String id) {
         return markupComponentFactory.newMarkupComponent(id, scalarModel());
     }
+
 }

Reply via email to