Correct invalid comparison Found via error-prone.
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/7767acbe Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/7767acbe Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/7767acbe Branch: refs/heads/master Commit: 7767acbec91585366888a603d3c6037a9dfe8dc6 Parents: cff5460 Author: Andrew Gaul <[email protected]> Authored: Fri Mar 17 16:36:15 2017 -0700 Committer: Andrew Gaul <[email protected]> Committed: Fri Mar 17 16:42:38 2017 -0700 ---------------------------------------------------------------------- .../main/java/org/jclouds/openstack/trove/v1/domain/Flavor.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/jclouds/blob/7767acbe/apis/openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/domain/Flavor.java ---------------------------------------------------------------------- diff --git a/apis/openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/domain/Flavor.java b/apis/openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/domain/Flavor.java index 4bf9830..b81867b 100644 --- a/apis/openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/domain/Flavor.java +++ b/apis/openstack-trove/src/main/java/org/jclouds/openstack/trove/v1/domain/Flavor.java @@ -103,7 +103,7 @@ public class Flavor implements Comparable<Flavor>{ return 1; if (this == that) return 0; - return this.getId() > that.getId() ? +1 : this.getId() < this.getId() ? -1 : 0; + return this.getId() > that.getId() ? +1 : this.getId() < that.getId() ? -1 : 0; } public static Builder builder() {
