Simplify list handling.
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/25cb06c9 Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/25cb06c9 Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/25cb06c9 Branch: refs/heads/master Commit: 25cb06c9fe453496a84c4679d5c9a5bcf4f7d40c Parents: 834b3d5 Author: Timur Alperovich <[email protected]> Authored: Thu Aug 20 17:14:00 2015 -0700 Committer: Timur Alperovich <[email protected]> Committed: Thu Aug 20 17:55:55 2015 -0700 ---------------------------------------------------------------------- .../blobstore/GoogleCloudStorageBlobStore.java | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/jclouds/blob/25cb06c9/providers/google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/GoogleCloudStorageBlobStore.java ---------------------------------------------------------------------- diff --git a/providers/google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/GoogleCloudStorageBlobStore.java b/providers/google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/GoogleCloudStorageBlobStore.java index 7fd3643..924fad3 100644 --- a/providers/google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/GoogleCloudStorageBlobStore.java +++ b/providers/google-cloud-storage/src/main/java/org/jclouds/googlecloudstorage/blobstore/GoogleCloudStorageBlobStore.java @@ -187,21 +187,15 @@ public final class GoogleCloudStorageBlobStore extends BaseBlobStore { /** Returns list of of all the objects */ @Override public PageSet<? extends StorageMetadata> list(String container) { - ListPageWithPrefixes<GoogleCloudStorageObject> gcsList = api.getObjectApi().listObjects(container); - PageSet<? extends StorageMetadata> list = objectListToStorageMetadata.apply(gcsList); - return list; + return list(container, ListContainerOptions.NONE); } @Override public PageSet<? extends StorageMetadata> list(String container, ListContainerOptions options) { - if (options != null && options != ListContainerOptions.NONE) { - ListObjectOptions listOptions = listContainerOptionsToListObjectOptions.apply(options); - ListPageWithPrefixes<GoogleCloudStorageObject> gcsList = api.getObjectApi().listObjects(container, listOptions); - PageSet<? extends StorageMetadata> list = objectListToStorageMetadata.apply(gcsList); - return options.isDetailed() ? fetchBlobMetadataProvider.get().setContainerName(container).apply(list) : list; - } else { - return list(container); - } + ListObjectOptions listOptions = listContainerOptionsToListObjectOptions.apply(options); + ListPageWithPrefixes<GoogleCloudStorageObject> gcsList = api.getObjectApi().listObjects(container, listOptions); + PageSet<? extends StorageMetadata> list = objectListToStorageMetadata.apply(gcsList); + return options.isDetailed() ? fetchBlobMetadataProvider.get().setContainerName(container).apply(list) : list; } /**
