Repository: jclouds Updated Branches: refs/heads/master e08acc6ed -> df43b3648
Avoid injecting on final fields This can cause thread visibility issues. Found via error-prone. Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/df43b364 Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/df43b364 Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/df43b364 Branch: refs/heads/master Commit: df43b364873518f1233b0b4c7c16b3bd6553ae27 Parents: e08acc6 Author: Andrew Gaul <[email protected]> Authored: Mon Aug 28 21:07:30 2017 -0700 Committer: Andrew Gaul <[email protected]> Committed: Mon Aug 28 21:08:59 2017 -0700 ---------------------------------------------------------------------- .../org/jclouds/openstack/keystone/v2_0/handlers/RetryOnRenew.java | 2 +- .../org/jclouds/compute/reference/ComputeServiceConstants.java | 2 +- project/pom.xml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/jclouds/blob/df43b364/apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/handlers/RetryOnRenew.java ---------------------------------------------------------------------- diff --git a/apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/handlers/RetryOnRenew.java b/apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/handlers/RetryOnRenew.java index 6364465..5cedc80 100644 --- a/apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/handlers/RetryOnRenew.java +++ b/apis/openstack-keystone/src/main/java/org/jclouds/openstack/keystone/v2_0/handlers/RetryOnRenew.java @@ -51,7 +51,7 @@ public class RetryOnRenew implements HttpRetryHandler { @VisibleForTesting @Inject(optional = true) @Named(Constants.PROPERTY_MAX_RETRIES) - static final int NUM_RETRIES = 5; + static int NUM_RETRIES = 5; private final LoadingCache<Credentials, Access> authenticationResponseCache; http://git-wip-us.apache.org/repos/asf/jclouds/blob/df43b364/compute/src/main/java/org/jclouds/compute/reference/ComputeServiceConstants.java ---------------------------------------------------------------------- diff --git a/compute/src/main/java/org/jclouds/compute/reference/ComputeServiceConstants.java b/compute/src/main/java/org/jclouds/compute/reference/ComputeServiceConstants.java index 7414624..036ebd0 100644 --- a/compute/src/main/java/org/jclouds/compute/reference/ComputeServiceConstants.java +++ b/compute/src/main/java/org/jclouds/compute/reference/ComputeServiceConstants.java @@ -49,7 +49,7 @@ public final class ComputeServiceConstants { @Singleton public static class NamingConvention { @Inject(optional = true) - public final Supplier<String> randomSuffix = new Supplier<String>() { + public Supplier<String> randomSuffix = new Supplier<String>() { final SecureRandom random = new SecureRandom(); @Override http://git-wip-us.apache.org/repos/asf/jclouds/blob/df43b364/project/pom.xml ---------------------------------------------------------------------- diff --git a/project/pom.xml b/project/pom.xml index beaadef..34a4bb7 100644 --- a/project/pom.xml +++ b/project/pom.xml @@ -808,7 +808,7 @@ <compilerArg>-Xep:AssertFalse:ERROR</compilerArg> <compilerArg>-Xep:AssistedInjectAndInjectOnConstructors:ERROR</compilerArg> <compilerArg>-Xep:CollectionIncompatibleType:ERROR</compilerArg> - <compilerArg>-Xep:GuiceInjectOnFinalField:OFF</compilerArg> <!-- noisy --> + <compilerArg>-Xep:GuiceInjectOnFinalField:ERROR</compilerArg> <compilerArg>-Xep:MissingFail:ERROR</compilerArg> <compilerArg>-Xep:NullablePrimitive:ERROR</compilerArg> <compilerArg>-Xep:OverridesGuiceInjectableMethod:OFF</compilerArg> <!-- internal error with 2.0.5 -->
