This is an automated email from the ASF dual-hosted git repository.
nacx pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/jclouds.git
The following commit(s) were added to refs/heads/master by this push:
new 316b74d Fix infinite socket timeout when using
ApacheHCHttpCommandExecutorServiceModule (#51)
316b74d is described below
commit 316b74db943d9868ac667df08f9b2df7742ac4c3
Author: Xavier BOURGOUIN <[email protected]>
AuthorDate: Wed Oct 23 11:44:58 2019 +0200
Fix infinite socket timeout when using
ApacheHCHttpCommandExecutorServiceModule (#51)
Because the Java type BasicHttpParams wasn't matching the one returned
by provider "newBasicHttpParams" (which is returning a HttpParams type), it
was configuring the Apache HTTP client with default settings (including
connection and socket timeout), ignoring the ones of JClouds which were must
safer in this regard (JCloudsones are currently 60sec for both, while Apache HC
ones are -1, so infinite). It also prevented to override those default/infinite
timeout settings with JClouds ones.
---
.../http/apachehc/config/ApacheHCHttpCommandExecutorServiceModule.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
a/drivers/apachehc/src/main/java/org/jclouds/http/apachehc/config/ApacheHCHttpCommandExecutorServiceModule.java
b/drivers/apachehc/src/main/java/org/jclouds/http/apachehc/config/ApacheHCHttpCommandExecutorServiceModule.java
index 00f23f4..0227074 100644
---
a/drivers/apachehc/src/main/java/org/jclouds/http/apachehc/config/ApacheHCHttpCommandExecutorServiceModule.java
+++
b/drivers/apachehc/src/main/java/org/jclouds/http/apachehc/config/ApacheHCHttpCommandExecutorServiceModule.java
@@ -143,7 +143,7 @@ public class ApacheHCHttpCommandExecutorServiceModule
extends AbstractModule {
@Provides
@Singleton
- final HttpClient newDefaultHttpClient(ProxyConfig config, BasicHttpParams
params, ClientConnectionManager cm) {
+ final HttpClient newDefaultHttpClient(ProxyConfig config, HttpParams
params, ClientConnectionManager cm) {
DefaultHttpClient client = new DefaultHttpClient(cm, params);
if (config.useSystem()) {
ProxySelectorRoutePlanner routePlanner = new
ProxySelectorRoutePlanner(client.getConnectionManager()
