JENA-879: No need for junit tests interface JenaOSGITest under PAX

Project: http://git-wip-us.apache.org/repos/asf/jena/repo
Commit: http://git-wip-us.apache.org/repos/asf/jena/commit/4d80d1f4
Tree: http://git-wip-us.apache.org/repos/asf/jena/tree/4d80d1f4
Diff: http://git-wip-us.apache.org/repos/asf/jena/diff/4d80d1f4

Branch: refs/heads/master
Commit: 4d80d1f4ecdb396340138cbfd703ee11b8701920
Parents: ee787d2
Author: Stian Soiland-Reyes <[email protected]>
Authored: Mon Feb 2 23:45:45 2015 +0000
Committer: Stian Soiland-Reyes <[email protected]>
Committed: Mon Feb 9 10:00:36 2015 +0000

----------------------------------------------------------------------
 .../org/apache/jena/osgi/test/JenaOSGITest.java | 47 --------------------
 .../apache/jena/osgi/test/JenaOSGITestImpl.java |  6 +--
 2 files changed, 1 insertion(+), 52 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/jena/blob/4d80d1f4/apache-jena-osgi/jena-osgi-test/src/main/java/org/apache/jena/osgi/test/JenaOSGITest.java
----------------------------------------------------------------------
diff --git 
a/apache-jena-osgi/jena-osgi-test/src/main/java/org/apache/jena/osgi/test/JenaOSGITest.java
 
b/apache-jena-osgi/jena-osgi-test/src/main/java/org/apache/jena/osgi/test/JenaOSGITest.java
deleted file mode 100644
index 79ffc72..0000000
--- 
a/apache-jena-osgi/jena-osgi-test/src/main/java/org/apache/jena/osgi/test/JenaOSGITest.java
+++ /dev/null
@@ -1,47 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements.  See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership.  The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License.  You may obtain a copy of the License at
- *
- *     http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.jena.osgi.test;
-
-import org.junit.Test;
-
-/** 
- * OSGi service interface for test using osgi-testrunner-junit4 
- * <p>
- * Junit annotations like @Test must be made here.
- * The implementation is in JenaOSGITestImpl, which is registered
- * with OSGi by JenaOSGIActiviator.
- * 
- * @author stain
- *
- */
-public interface JenaOSGITest {
-
-       @Test
-       public void testJenaIRI() throws Exception;
-
-       @Test
-       public void testJenaCore() throws Exception;
-       
-       @Test
-       public void testJenaArq() throws Exception;
-       
-       @Test
-       public void testJenaTdb() throws Exception;
-       
-}

http://git-wip-us.apache.org/repos/asf/jena/blob/4d80d1f4/apache-jena-osgi/jena-osgi-test/src/main/java/org/apache/jena/osgi/test/JenaOSGITestImpl.java
----------------------------------------------------------------------
diff --git 
a/apache-jena-osgi/jena-osgi-test/src/main/java/org/apache/jena/osgi/test/JenaOSGITestImpl.java
 
b/apache-jena-osgi/jena-osgi-test/src/main/java/org/apache/jena/osgi/test/JenaOSGITestImpl.java
index 3674d53..cbdb324 100644
--- 
a/apache-jena-osgi/jena-osgi-test/src/main/java/org/apache/jena/osgi/test/JenaOSGITestImpl.java
+++ 
b/apache-jena-osgi/jena-osgi-test/src/main/java/org/apache/jena/osgi/test/JenaOSGITestImpl.java
@@ -60,7 +60,7 @@ import com.hp.hpl.jena.tdb.TDBFactory;
  * -- otherwise it won't be picked up when testing inside OSGi
  *  
  */
-public class JenaOSGITestImpl implements JenaOSGITest {
+public class JenaOSGITestImpl {
 
        private static final String EXAMPLE_COM_GRAPH = 
"http://example.com/graph";;
        private Resource alice;
@@ -68,7 +68,6 @@ public class JenaOSGITestImpl implements JenaOSGITest {
        private Resource bob;
 
        @Test
-       @Override
        public void testJenaCore() throws Exception {
                Model model = makeModel();
 
@@ -108,7 +107,6 @@ public class JenaOSGITestImpl implements JenaOSGITest {
        }
 
        @Test
-       @Override
        public void testJenaArq() throws Exception {
                Dataset dataset = DatasetFactory.createMem();
                dataset.addNamedModel(EXAMPLE_COM_GRAPH, makeModel());
@@ -145,7 +143,6 @@ public class JenaOSGITestImpl implements JenaOSGITest {
        }
 
        @Test
-       @Override
        public void testJenaIRI() throws Exception {
                IRIFactory iriFactory = IRIFactory.jenaImplementation();
                IRI iri = iriFactory.create("http://example.com/";);
@@ -153,7 +150,6 @@ public class JenaOSGITestImpl implements JenaOSGITest {
        }
 
        @Test
-       @Override
        public void testJenaTdb() throws Exception {
                Path tdbDir = Files.createTempDirectory("jena-tdb-test");
                Dataset dataset = TDBFactory.createDataset(tdbDir.toString());

Reply via email to