Repository: jena Updated Branches: refs/heads/master a3c9fb0ad -> ab8f32ab1
Remove repeated comments Project: http://git-wip-us.apache.org/repos/asf/jena/repo Commit: http://git-wip-us.apache.org/repos/asf/jena/commit/c3953a7c Tree: http://git-wip-us.apache.org/repos/asf/jena/tree/c3953a7c Diff: http://git-wip-us.apache.org/repos/asf/jena/diff/c3953a7c Branch: refs/heads/master Commit: c3953a7c7ea227f97dab683904c422121d6b91fe Parents: a3c9fb0 Author: Andy Seaborne <[email protected]> Authored: Wed Sep 9 19:51:04 2015 +0100 Committer: Andy Seaborne <[email protected]> Committed: Wed Sep 9 19:51:04 2015 +0100 ---------------------------------------------------------------------- .../org/apache/jena/sparql/engine/join/JoinKey.java | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/jena/blob/c3953a7c/jena-arq/src/main/java/org/apache/jena/sparql/engine/join/JoinKey.java ---------------------------------------------------------------------- diff --git a/jena-arq/src/main/java/org/apache/jena/sparql/engine/join/JoinKey.java b/jena-arq/src/main/java/org/apache/jena/sparql/engine/join/JoinKey.java index 0fd47b6..ea24927 100644 --- a/jena-arq/src/main/java/org/apache/jena/sparql/engine/join/JoinKey.java +++ b/jena-arq/src/main/java/org/apache/jena/sparql/engine/join/JoinKey.java @@ -28,13 +28,12 @@ import org.apache.jena.sparql.core.Var ; /** JoinKey for hash joins */ public final class JoinKey implements Iterable<Var> { + /** Key of no variables */ private static final JoinKey emptyKey = new JoinKey(DS.listOfNone()) ; - // Common way to make a JoinKey /** Make a JoinKey from the intersection of two sets **/ public static JoinKey create(Collection<Var> vars1, Collection<Var> vars2) { - // JoinKeys are generally small so short loops are best. - // vars2 may be smallest e.g. from triple and running accumulator (vars1) + // JoinKeys and choices for keys are generally small so short loops are best. List<Var> intersection = DS.list() ; for ( Var v : vars1 ) { if ( vars2.contains(v) ) @@ -45,16 +44,9 @@ public final class JoinKey implements Iterable<Var> /** Make a JoinKey of single variable from the intersection of two sets **/ public static JoinKey createVarKey(Collection<Var> vars1, Collection<Var> vars2) { - // JoinKeys are generally small so short loops are best. - // vars2 may be smallest e.g. from triple and running accumulator (vars1) - List<Var> intersection = DS.list() ; for ( Var v : vars1 ) { if ( vars2.contains(v) ) - // First and single key. return create(v) ; - // Compound keys needs validation : what if they are partial - // i.e. some rows only have part of the join key? - //intersection.add(v) ; } return emptyKey ; }
