Remove interface methods now in implemented geneally
Project: http://git-wip-us.apache.org/repos/asf/jena/repo Commit: http://git-wip-us.apache.org/repos/asf/jena/commit/1d48cea2 Tree: http://git-wip-us.apache.org/repos/asf/jena/tree/1d48cea2 Diff: http://git-wip-us.apache.org/repos/asf/jena/diff/1d48cea2 Branch: refs/heads/master Commit: 1d48cea20ffb417bf8fb87c872127779dd4b7611 Parents: c4e5c54 Author: Andy Seaborne <[email protected]> Authored: Tue Jan 2 16:23:17 2018 +0000 Committer: Andy Seaborne <[email protected]> Committed: Tue Jan 2 16:23:17 2018 +0000 ---------------------------------------------------------------------- .../jena/dboe/transaction/Transactional.java | 88 +------------------- 1 file changed, 2 insertions(+), 86 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/jena/blob/1d48cea2/jena-db/jena-dboe-transaction/src/main/java/org/apache/jena/dboe/transaction/Transactional.java ---------------------------------------------------------------------- diff --git a/jena-db/jena-dboe-transaction/src/main/java/org/apache/jena/dboe/transaction/Transactional.java b/jena-db/jena-dboe-transaction/src/main/java/org/apache/jena/dboe/transaction/Transactional.java index 91d5f6b..a961993 100644 --- a/jena-db/jena-dboe-transaction/src/main/java/org/apache/jena/dboe/transaction/Transactional.java +++ b/jena-db/jena-dboe-transaction/src/main/java/org/apache/jena/dboe/transaction/Transactional.java @@ -18,92 +18,8 @@ package org.apache.jena.dboe.transaction; -import org.apache.jena.dboe.jenax.Txn; -import org.apache.jena.query.ReadWrite; -import org.apache.jena.query.TxnType; - -/** Interface that encapsulates the begin/abort|commit/end operations. - * <p>The read lifecycle is: - * <pre> begin(READ) ... end()</pre> - * <p>{@code commit} and {@code abort} are allowed. - * <p>The write lifecycle is: - * <pre> begin(WRITE) ... abort() or commit()</pre> - * <p>{@code end()} is optional but preferred. - * <p> - * Helper code is available {@link Txn} so, for example: - * <pre>Txn.execRead(dataset, ()-> { ... sparql query ... });</pre> - * <pre>Txn.execWrite(dataset, ()-> { ... sparql update ... });</pre> - * <p> - * Directly called, code might look like: - * <pre> - * Transactional object = ... - * object.begin(ReadWrite.READ); - * try { - * ... actions inside a read transaction ... - * } finally { object.end(); } - * </pre> - * or - * <pre> - * Transactional object = ... - * object.begin(ReadWrite.WRITE); - * try { - * ... actions inside a write transaction ... - * object.commit(); - * } finally { - * // This causes an abort if {@code commit} has not been called. - * object.end(); - * } - * </pre> - * Exceptions will not be thrown. - * If any do occur, this indicates serious internal problems with the transaction system. - */ public interface Transactional extends org.apache.jena.sparql.core.Transactional { - /** Start either a READ or WRITE transaction */ - @Override - public default void begin(ReadWrite readWrite) { - begin(TxnType.convert(readWrite)); - } - - @Override - public void begin(TxnType type); - - /** Attempt to promote a read transaction to a write transaction. - * This is not guaranteed to succeed - any changes by another write transaction - * may restrict promotion. This depends on the transaction type as to whether - * it is "read commited" or not. - * <p> - * If not "read committed", any intervening write transaction will block promotion. - * Otherwise, at the point or promotion, changes by other writers become visible. - * <p> - * Promoting a transaction which is already a write transaction will return true. - * - * @return boolean indicating whether the transaction is now a write transaction or not. - */ - @Override - public boolean promote(); - - /** Commit a transaction - finish the transaction and make any changes permanent (if a "write" transaction) */ - @Override - public void commit(); - - /** Abort a transaction - finish the transaction and undo any changes (if a "write" transaction) */ - @Override - public void abort(); - - /** Finish the transaction - if a write transaction and commit() has not been called, then abort. */ - @Override - public void end(); - - /** Return the current mode of the transaction - "read" or "write" */ - @Override - public ReadWrite transactionMode(); - - /** Return the transaction type used in {@code begin(TxnType)}. */ - @Override - public TxnType transactionType(); - - /** Say whether inside a transaction. */ - @Override - public boolean isInTransaction(); + // Placeholder in case we need to add methods specific for DBOE/TDB2 + // before they migrate to sparql.core.Transactional } \ No newline at end of file
