Author: pmouawad
Date: Tue Feb 28 16:01:05 2012
New Revision: 1294708
URL: http://svn.apache.org/viewvc?rev=1294708&view=rev
Log:
Bug 52788 - HttpRequestHdr : Optimize code to avoid useless work
Modified:
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/HttpRequestHdr.java
jmeter/trunk/xdocs/changes.xml
Modified:
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/HttpRequestHdr.java
URL:
http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/HttpRequestHdr.java?rev=1294708&r1=1294707&r2=1294708&view=diff
==============================================================================
---
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/HttpRequestHdr.java
(original)
+++
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/HttpRequestHdr.java
Tue Feb 28 16:01:05 2012
@@ -255,17 +255,11 @@ public class HttpRequestHdr {
throws MalformedURLException, IOException {
// Instantiate the sampler
HTTPSamplerBase sampler =
HTTPSamplerFactory.newInstance(httpSamplerName);
- // Damn! A whole new GUI just to instantiate a test element?
- // Isn't there a beter way?
- HttpTestSampleGui tempGui = new HttpTestSampleGui();
-
- sampler.setProperty(TestElement.GUI_CLASS,
tempGui.getClass().getName());
+ sampler.setProperty(TestElement.GUI_CLASS,
HttpTestSampleGui.class.getName());
// Populate the sampler
populateSampler(sampler, pageEncodings, formEncodings);
- tempGui.configure(sampler);
- tempGui.modifyTestElement(sampler);
// Defaults
sampler.setFollowRedirects(false);
sampler.setUseKeepAlive(true);
Modified: jmeter/trunk/xdocs/changes.xml
URL:
http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1294708&r1=1294707&r2=1294708&view=diff
==============================================================================
--- jmeter/trunk/xdocs/changes.xml (original)
+++ jmeter/trunk/xdocs/changes.xml Tue Feb 28 16:01:05 2012
@@ -163,6 +163,7 @@ with other code that depends on an earli
</li>
<li>Bug 52675 - Refactor Proxy and HttpRequestHdr to allow Sampler Creation by
Proxy</li>
<li>Bug 52680 - Mention version in which function was introduced</li>
+<li>Bug 52788 - HttpRequestHdr : Optimize code to avoid useless work</li>
</ul>
</section>
