svn commit: r1663099 - in /jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/graphite: PickleGraphiteMetricsSender.java TextGraphiteMetricsSender.java

[pmouawad]

Author: pmouawad
Date: Sun Mar  1 13:47:19 2015
New Revision: 1663099

URL: http://svn.apache.org/r1663099
Log:
Document why writer/stream is not closed

Modified:
    
jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/graphite/PickleGraphiteMetricsSender.java
    
jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/graphite/TextGraphiteMetricsSender.java

Modified: 
jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/graphite/PickleGraphiteMetricsSender.java
URL: 
http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/graphite/PickleGraphiteMetricsSender.java?rev=1663099&r1=1663098&r2=1663099&view=diff
==============================================================================
--- 
jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/graphite/PickleGraphiteMetricsSender.java
 (original)
+++ 
jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/graphite/PickleGraphiteMetricsSender.java
 Sun Mar  1 13:47:19 2015
@@ -109,6 +109,7 @@ class PickleGraphiteMetricsSender extend
 
                 out = 
socketOutputStreamPool.borrowObject(socketConnectionInfos);
                 out.write(header);
+                //pickleWriter is not close as it would close the underlying 
pooled out
                 Writer pickleWriter = new OutputStreamWriter(out, 
CHARSET_NAME);
                 pickleWriter.write(payload);
                 pickleWriter.flush();

Modified: 
jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/graphite/TextGraphiteMetricsSender.java
URL: 
http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/graphite/TextGraphiteMetricsSender.java?rev=1663099&r1=1663098&r2=1663099&view=diff
==============================================================================
--- 
jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/graphite/TextGraphiteMetricsSender.java
 (original)
+++ 
jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/graphite/TextGraphiteMetricsSender.java
 Sun Mar  1 13:47:19 2015
@@ -85,6 +85,7 @@ class TextGraphiteMetricsSender extends
             SocketOutputStream out = null;
             try {
                 out = 
socketOutputStreamPool.borrowObject(socketConnectionInfos);
+                // pw is not close as it would close the underlying pooled out
                 PrintWriter pw = new PrintWriter(new OutputStreamWriter(out, 
CHARSET_NAME), false);
                 for (MetricTuple metric: metrics) {
                     pw.printf("%s %s %d%n", metric.name, metric.value, 
Long.valueOf(metric.timestamp));