svn commit: r1734743 - in /jmeter/trunk: src/core/org/apache/jmeter/save/converters/SampleSaveConfigurationConverter.java xdocs/changes.xml

[sebb]

Author: sebb
Date: Sat Mar 12 22:44:01 2016
New Revision: 1734743

URL: http://svn.apache.org/viewvc?rev=1734743&view=rev
Log:
SampleResult SaveConfig does not allow some fields to be disabled
Bugzilla Id: 59172

Modified:
    
jmeter/trunk/src/core/org/apache/jmeter/save/converters/SampleSaveConfigurationConverter.java
    jmeter/trunk/xdocs/changes.xml

Modified: 
jmeter/trunk/src/core/org/apache/jmeter/save/converters/SampleSaveConfigurationConverter.java
URL: 
http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/save/converters/SampleSaveConfigurationConverter.java?rev=1734743&r1=1734742&r2=1734743&view=diff
==============================================================================
--- 
jmeter/trunk/src/core/org/apache/jmeter/save/converters/SampleSaveConfigurationConverter.java
 (original)
+++ 
jmeter/trunk/src/core/org/apache/jmeter/save/converters/SampleSaveConfigurationConverter.java
 Sat Mar 12 22:44:01 2016
@@ -156,8 +156,9 @@ public class SampleSaveConfigurationConv
         if (requiredType != thisClass) {
             throw new IllegalArgumentException("Unexpected class: 
"+requiredType.getName());
         }
-        SampleSaveConfiguration result = new SampleSaveConfiguration();
-        result.setBytes(false); // Maintain backward compatibility (bytes was 
not in the JMX file)
+        // The default for missing tags is false, so preset all the fields 
accordingly
+        SampleSaveConfiguration result = new SampleSaveConfiguration(false);
+        // Now pick up any tags from the input file
         while (reader.hasMoreChildren()) {
             reader.moveDown();
             String nn = reader.getNodeName();

Modified: jmeter/trunk/xdocs/changes.xml
URL: 
http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1734743&r1=1734742&r2=1734743&view=diff
==============================================================================
--- jmeter/trunk/xdocs/changes.xml (original)
+++ jmeter/trunk/xdocs/changes.xml Sat Mar 12 22:44:01 2016
@@ -365,6 +365,7 @@ Summary
 <li><bug>58033</bug>SampleResultConverter should note that it cannot record 
non-TEXT data</li>
 <li><bug>58845</bug>Request http view doesn't display all the parameters. 
Contributed by Benoit Wiart (benoit dot wiart at gmail.com)</li>
 <li><bug>58413</bug>ViewResultsTree : Request HTTP Renderer does not show 
correctly parameters that contain ampersand (&amp;). Contributed by Benoit 
Wiart (benoit dot wiart at gmail.com)</li>
+<li><bug>59272</bug>SampleResult SaveConfig does not allow some fields to be 
disabled </li>
 </ul>
 
 <h3>Timers, Assertions, Config, Pre- &amp; Post-Processors</h3>