Author: pmouawad
Date: Sat Sep 17 13:21:37 2016
New Revision: 1761226

URL: http://svn.apache.org/viewvc?rev=1761226&view=rev
Log:
Bug 60106 - Settings defaults : Switch "jmeter.save.saveservice.connect_time" 
to true (after 3.0)
Bugzilla Id: 60106

Modified:
    jmeter/trunk/bin/jmeter.properties
    jmeter/trunk/bin/testfiles/jmeter-batch.properties
    
jmeter/trunk/src/core/org/apache/jmeter/samplers/SampleSaveConfiguration.java
    jmeter/trunk/xdocs/changes.xml
    jmeter/trunk/xdocs/usermanual/listeners.xml

Modified: jmeter/trunk/bin/jmeter.properties
URL: 
http://svn.apache.org/viewvc/jmeter/trunk/bin/jmeter.properties?rev=1761226&r1=1761225&r2=1761226&view=diff
==============================================================================
--- jmeter/trunk/bin/jmeter.properties (original)
+++ jmeter/trunk/bin/jmeter.properties Sat Sep 17 13:21:37 2016
@@ -551,7 +551,7 @@ log_level.jorphan=INFO
 #jmeter.save.saveservice.subresults=true
 #jmeter.save.saveservice.assertions=true
 #jmeter.save.saveservice.latency=true
-#jmeter.save.saveservice.connect_time=false
+#jmeter.save.saveservice.connect_time=true
 #jmeter.save.saveservice.samplerData=false
 #jmeter.save.saveservice.responseHeaders=false
 #jmeter.save.saveservice.requestHeaders=false

Modified: jmeter/trunk/bin/testfiles/jmeter-batch.properties
URL: 
http://svn.apache.org/viewvc/jmeter/trunk/bin/testfiles/jmeter-batch.properties?rev=1761226&r1=1761225&r2=1761226&view=diff
==============================================================================
--- jmeter/trunk/bin/testfiles/jmeter-batch.properties (original)
+++ jmeter/trunk/bin/testfiles/jmeter-batch.properties Sat Sep 17 13:21:37 2016
@@ -29,6 +29,8 @@ mode=Standard
 jmeter.save.saveservice.thread_counts=false
 # Since JMeter 3.0, defaults for this property is true
 jmeter.save.saveservice.idle_time=false
+# Since JMeter 3.1, defaults for this property is true
+jmeter.save.saveservice.connect_time=false
 
 HTTPResponse.parsers=htmlParser
 
htmlParser.className=org.apache.jmeter.protocol.http.parser.LagartoBasedHtmlParser

Modified: 
jmeter/trunk/src/core/org/apache/jmeter/samplers/SampleSaveConfiguration.java
URL: 
http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/samplers/SampleSaveConfiguration.java?rev=1761226&r1=1761225&r2=1761226&view=diff
==============================================================================
--- 
jmeter/trunk/src/core/org/apache/jmeter/samplers/SampleSaveConfiguration.java 
(original)
+++ 
jmeter/trunk/src/core/org/apache/jmeter/samplers/SampleSaveConfiguration.java 
Sat Sep 17 13:21:37 2016
@@ -309,7 +309,7 @@ public class SampleSaveConfiguration imp
         _subresults      = 
TRUE.equalsIgnoreCase(props.getProperty(SUBRESULTS_PROP, TRUE));
         _assertions      = 
TRUE.equalsIgnoreCase(props.getProperty(ASSERTIONS_PROP, TRUE));
         _latency         = 
TRUE.equalsIgnoreCase(props.getProperty(LATENCY_PROP, TRUE));
-        _connectTime     = 
TRUE.equalsIgnoreCase(props.getProperty(CONNECT_TIME_PROP, FALSE));
+        _connectTime     = 
TRUE.equalsIgnoreCase(props.getProperty(CONNECT_TIME_PROP, TRUE));
         _samplerData     = 
TRUE.equalsIgnoreCase(props.getProperty(SAMPLERDATA_PROP, FALSE));
         _responseHeaders = 
TRUE.equalsIgnoreCase(props.getProperty(RESPONSEHEADERS_PROP, FALSE));
         _requestHeaders  = 
TRUE.equalsIgnoreCase(props.getProperty(REQUESTHEADERS_PROP, FALSE));

Modified: jmeter/trunk/xdocs/changes.xml
URL: 
http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1761226&r1=1761225&r2=1761226&view=diff
==============================================================================
--- jmeter/trunk/xdocs/changes.xml [utf-8] (original)
+++ jmeter/trunk/xdocs/changes.xml [utf-8] Sat Sep 17 13:21:37 2016
@@ -70,6 +70,7 @@ Summary
     <li>Since 3.1 version, HTML report ignores Empty Transaction controller 
(possibly generated by If Controller or Throughput Controller) when computing 
metrics. This provides more accurate metrics</li>
     <li>Since 3.1 version, Summariser ignores SampleResults generated by 
TransactionController when computing the live statistics, see 
<bugzilla>60109</bugzilla></li>
     <li>Since 3.1 version, when using Stripped modes (by default StrippedBatch 
is used) , response will be stripped also for failing SampleResults, you can 
revert this to previous behaviour by setting 
<code>sample_sender_strip_also_on_error=false</code> in user.properties, see 
<bugzilla>60137</bugzilla></li>
+    <li>Since 3.1 version, <code>jmeter.save.saveservice.connect_time</code> 
property value is true, meaning CSV file for results will contain an additional 
column containing connection time, see <bugzilla>60106</bugzilla></li>
 </ul>
 
 <h3>Deprecated and removed elements</h3>
@@ -155,6 +156,7 @@ Summary
     <li><bug>59777</bug>Extract slf4j binding into its own jar and make it a 
jmeter lib</li>
     <li><bug>60085</bug>Remove cache for prepared statements, as it didn't 
work with the current jdbc pool implementation and current jdbc drivers should 
support caching of prepared statements themselves.</li>
     <li><bug>60137</bug>In Distributed testing when using StrippedXXXX modes 
strip response also on error</li>
+    <li><bug>60106</bug>Settings defaults : Switch 
"jmeter.save.saveservice.connect_time" to true (after 3.0)</li>
 </ul>
 
 <ch_section>Non-functional changes</ch_section>

Modified: jmeter/trunk/xdocs/usermanual/listeners.xml
URL: 
http://svn.apache.org/viewvc/jmeter/trunk/xdocs/usermanual/listeners.xml?rev=1761226&r1=1761225&r2=1761226&view=diff
==============================================================================
--- jmeter/trunk/xdocs/usermanual/listeners.xml (original)
+++ jmeter/trunk/xdocs/usermanual/listeners.xml Sat Sep 17 13:21:37 2016
@@ -135,7 +135,7 @@ The full set of properties that affect r
 #jmeter.save.saveservice.subresults=true
 #jmeter.save.saveservice.assertions=true
 #jmeter.save.saveservice.latency=true
-#jmeter.save.saveservice.connect_time=false
+#jmeter.save.saveservice.connect_time=true
 #jmeter.save.saveservice.samplerData=false
 #jmeter.save.saveservice.responseHeaders=false
 #jmeter.save.saveservice.requestHeaders=false


Reply via email to