Author: pmouawad
Date: Sat Nov 12 20:28:51 2016
New Revision: 1769410
URL: http://svn.apache.org/viewvc?rev=1769410&view=rev
Log:
Ignore false positive for synchro on non final field
Modified:
jmeter/trunk/src/core/org/apache/jmeter/reporters/Summariser.java
Modified: jmeter/trunk/src/core/org/apache/jmeter/reporters/Summariser.java
URL:
http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/reporters/Summariser.java?rev=1769410&r1=1769409&r2=1769410&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/reporters/Summariser.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/reporters/Summariser.java Sat Nov
12 20:28:51 2016
@@ -170,6 +170,7 @@ public class Summariser extends Abstract
* @see
org.apache.jmeter.samplers.SampleListener#sampleOccurred(org.apache.jmeter.samplers.SampleEvent)
*/
@Override
+ @SuppressWarnings("SynchronizeOnNonFinalField")
public void sampleOccurred(SampleEvent e) {
SampleResult s = e.getResult();
if(IGNORE_TC_GENERATED_SAMPLERESULT &&
TransactionController.isFromTransactionController(s)) {
@@ -187,6 +188,7 @@ public class Summariser extends Abstract
* Need to allow for a margin of error, otherwise can miss the slot.
* Also need to check we've not hit the window already
*/
+
synchronized (myTotals) {
if (s != null) {
myTotals.delta.addSample(s);