Author: pmouawad
Date: Sat Feb 4 14:38:21 2017
New Revision: 1781674
URL: http://svn.apache.org/viewvc?rev=1781674&view=rev
Log:
Bug 60690 - Default values for "httpclient4.validate_after_inactivity" and
"httpclient4.time_to_live" which are equal to each other makes validation
useless
Bugzilla Id: 60690
Modified:
jmeter/trunk/bin/jmeter.properties
jmeter/trunk/src/protocol/http/org/apache/http/impl/conn/JMeterPoolingClientConnectionManager.java
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java
jmeter/trunk/xdocs/changes.xml
jmeter/trunk/xdocs/usermanual/properties_reference.xml
Modified: jmeter/trunk/bin/jmeter.properties
URL:
http://svn.apache.org/viewvc/jmeter/trunk/bin/jmeter.properties?rev=1781674&r1=1781673&r2=1781674&view=diff
==============================================================================
--- jmeter/trunk/bin/jmeter.properties (original)
+++ jmeter/trunk/bin/jmeter.properties Sat Feb 4 14:38:21 2017
@@ -482,7 +482,7 @@ log_level.jorphan=INFO
# Check connections if the elapsed time (Milliseconds) since the last
# use of the connection exceed this value
-#httpclient4.validate_after_inactivity=2000
+#httpclient4.validate_after_inactivity=1700
# TTL (in Milliseconds) represents an absolute value.
# No matter what, the connection will not be re-used beyond its TTL.
Modified:
jmeter/trunk/src/protocol/http/org/apache/http/impl/conn/JMeterPoolingClientConnectionManager.java
URL:
http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/http/impl/conn/JMeterPoolingClientConnectionManager.java?rev=1781674&r1=1781673&r2=1781674&view=diff
==============================================================================
---
jmeter/trunk/src/protocol/http/org/apache/http/impl/conn/JMeterPoolingClientConnectionManager.java
(original)
+++
jmeter/trunk/src/protocol/http/org/apache/http/impl/conn/JMeterPoolingClientConnectionManager.java
Sat Feb 4 14:38:21 2017
@@ -57,7 +57,7 @@ import org.apache.http.util.Asserts;
@Deprecated
public class JMeterPoolingClientConnectionManager implements
ClientConnectionManager, ConnPoolControl<HttpRoute> {
- private static final int VALIDATE_AFTER_INACTIVITY_DEFAULT = 2000;
+ private static final int VALIDATE_AFTER_INACTIVITY_DEFAULT = 1700;
private final Log log = LogFactory.getLog(getClass());
Modified:
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java
URL:
http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java?rev=1781674&r1=1781673&r2=1781674&view=diff
==============================================================================
---
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java
(original)
+++
jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/HTTPHC4Impl.java
Sat Feb 4 14:38:21 2017
@@ -156,7 +156,7 @@ public class HTTPHC4Impl extends HTTPHCA
/** Idle timeout to be applied to connections if no Keep-Alive header is
sent by the server (default 0 = disable) */
private static final int IDLE_TIMEOUT =
JMeterUtils.getPropDefault("httpclient4.idletimeout", 0);
- private static final int VALIDITY_AFTER_INACTIVITY_TIMEOUT =
JMeterUtils.getPropDefault("httpclient4.validate_after_inactivity", 2000);
+ private static final int VALIDITY_AFTER_INACTIVITY_TIMEOUT =
JMeterUtils.getPropDefault("httpclient4.validate_after_inactivity", 1700);
private static final int TIME_TO_LIVE =
JMeterUtils.getPropDefault("httpclient4.time_to_live", 2000);
Modified: jmeter/trunk/xdocs/changes.xml
URL:
http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1781674&r1=1781673&r2=1781674&view=diff
==============================================================================
--- jmeter/trunk/xdocs/changes.xml [utf-8] (original)
+++ jmeter/trunk/xdocs/changes.xml [utf-8] Sat Feb 4 14:38:21 2017
@@ -205,6 +205,7 @@ JMeter now requires Java 8. Ensure you u
<li><bug>60643</bug>HTTP(S) Test Script Recorder doesn't correctly handle
restart or start after stop. Contributed by Ubik Load Pack (support at
ubikloadpack.com)</li>
<li><bug>60652</bug>PUT might leak file descriptors.</li>
<li><bug>60689</bug><code>httpclient4.validate_after_inactivity</code> has
no impact leading to usage of potentially stale/closed connections</li>
+ <li><bug>60690</bug>Default values for
"httpclient4.validate_after_inactivity" and "httpclient4.time_to_live" which
are equal to each other makes validation useless</li>
</ul>
<h3>Other Samplers</h3>
@@ -274,6 +275,7 @@ JMeter now requires Java 8. Ensure you u
<p>We also thank bug reporters who helped us improve JMeter. <br/>
For this release we want to give special thanks to the following reporters for
the clear reports and tests made after our fixes:</p>
<ul>
+<li>Tuukka Mustonen (tuukka.mustonen at gmail.com) who gave us a lot of useful
feedback which helped resolve <bugzilla>60689</bugzilla> and
<bugzilla>60690</bugzilla></li>
</ul>
<p>
Apologies if we have omitted anyone else.
Modified: jmeter/trunk/xdocs/usermanual/properties_reference.xml
URL:
http://svn.apache.org/viewvc/jmeter/trunk/xdocs/usermanual/properties_reference.xml?rev=1781674&r1=1781673&r2=1781674&view=diff
==============================================================================
--- jmeter/trunk/xdocs/usermanual/properties_reference.xml (original)
+++ jmeter/trunk/xdocs/usermanual/properties_reference.xml Sat Feb 4 14:38:21
2017
@@ -531,13 +531,13 @@ log_level.org.apache.http.client=DEBUG
Defaults to: <code>0</code>
</property>
<property name="httpclient4.idletimeout">
- Idle connection timeout (in milliseconds) to apply if the server does not
send <code>Keep-Alive</code> headers.<br/>
- Defaults to: <code>0</code> (no suggested duration for
<code>Keep-Alive</code>)
+ Idle connection timeout (in milliseconds) to apply if the server does not
send <code>Keep-Alive</code> timeout headers.<br/>
+ Defaults to: <code>0</code> (no suggested duration for
<code>Keep-Alived</code> connections)
</property>
<property name="httpclient4.validate_after_inactivity">
- Check connections if the elapsed time (in milliseconds) since the last use
of the connection
+ Check connection if the elapsed time (in milliseconds) since the last use
of the connection
exceeds this value.<br/>
- Defaults to: <code>2000</code>
+ Defaults to: <code>1700</code>
</property>
<property name="httpclient4.time_to_live">
<abbr title="time to live">TTL</abbr> (in milliseconds) represents an
absolute value.
