svn commit: r1815919 - in /jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/influxdb: HttpMetricsSender.java InfluxdbMetricsSender.java

[pmouawad]

Author: pmouawad
Date: Tue Nov 21 13:14:05 2017
New Revision: 1815919

URL: http://svn.apache.org/viewvc?rev=1815919&view=rev
Log:
Fix SONAR warnings

Modified:
    
jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/influxdb/HttpMetricsSender.java
    
jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/influxdb/InfluxdbMetricsSender.java

Modified: 
jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/influxdb/HttpMetricsSender.java
URL: 
http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/influxdb/HttpMetricsSender.java?rev=1815919&r1=1815918&r2=1815919&view=diff
==============================================================================
--- 
jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/influxdb/HttpMetricsSender.java
 (original)
+++ 
jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/influxdb/HttpMetricsSender.java
 Tue Nov 21 13:14:05 2017
@@ -122,10 +122,10 @@ class HttpMetricsSender extends Abstract
                 
.setConnectionRequestTimeout(JMeterUtils.getPropDefault("backend_influxdb.connection_request_timeout",
 100))
                 .build();
         
-        HttpPost httpRequest = new HttpPost(url.toURI());
-        httpRequest.setConfig(defaultRequestConfig);
+        HttpPost currentHttpRequest = new HttpPost(url.toURI());
+        currentHttpRequest.setConfig(defaultRequestConfig);
         log.debug("Created InfluxDBMetricsSender with url: {}", url);
-        return httpRequest;
+        return currentHttpRequest;
     }
 
     @Override
@@ -180,14 +180,12 @@ class HttpMetricsSender extends Abstract
                          * could not understand the request. 5xx: The system is
                          * overloaded or significantly impaired.
                          */
-                        switch (code) {
-                        case 204:
-                            if (log.isDebugEnabled()) {
+                        if(log.isDebugEnabled()) {
+                            if(code == 204) {
                                 log.debug("Success, number of metrics written: 
{}", copyMetrics.size());
+                            } else {
+                                log.debug("Error writing metrics to influxDB 
Url: {}, responseCode: {}", url, code);
                             }
-                            break;
-                        default:
-                            log.debug("Error writing metrics to influxDB Url: 
{}, responseCode: {}", url, code);
                         }
                     }
                     @Override

Modified: 
jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/influxdb/InfluxdbMetricsSender.java
URL: 
http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/influxdb/InfluxdbMetricsSender.java?rev=1815919&r1=1815918&r2=1815919&view=diff
==============================================================================
--- 
jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/influxdb/InfluxdbMetricsSender.java
 (original)
+++ 
jmeter/trunk/src/components/org/apache/jmeter/visualizers/backend/influxdb/InfluxdbMetricsSender.java
 Tue Nov 21 13:14:05 2017
@@ -60,7 +60,7 @@ interface InfluxdbMetricsSender {
      * @param influxDBUrl url pointing to influxdb
      * @throws Exception when setup fails
      */
-    public void setup(String influxDBUrl) throws Exception;
+    public void setup(String influxDBUrl) throws Exception; // NOSONAR
 
     /**
      * Destroy sender