This is an automated email from the ASF dual-hosted git repository.
pmouawad pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/jmeter.git
The following commit(s) were added to refs/heads/master by this push:
new d1be9fe Fix checkstyle warning
d1be9fe is described below
commit d1be9fe1d3211225c4b4caa39bc7c5ec4c44d514
Author: pmouawad <[email protected]>
AuthorDate: Mon Jul 22 21:56:47 2019 +0200
Fix checkstyle warning
---
.../jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElement.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
a/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElement.java
b/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElement.java
index 8887dcb..74e1fd3 100644
---
a/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElement.java
+++
b/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElement.java
@@ -294,7 +294,8 @@ public class DataSourceElement extends AbstractTestElement
if(isPreinit()) {
// side effect - connection pool init - that is what we want
// see also
https://commons.apache.org/proper/commons-dbcp/apidocs/org/apache/commons/dbcp2/BasicDataSource.html#setInitialSize-int-
- // it says: "The pool is initialized the first time one of the
following methods is invoked: getConnection, setLogwriter, setLoginTimeout,
getLoginTimeout, getLogWriter."
+ // it says: "The pool is initialized the first time one of the
following methods is invoked:
+ // getConnection, setLogwriter, setLoginTimeout, getLoginTimeout,
getLogWriter."
// so we get a connection and close it - which releases it back to
the pool (but stays open)
try {
dataSource.getConnection().close();